Tickets: every way out of Resolved into a working status (ticket reply, bulk reply, portal comment, API reply) clears the resolved time and restarts the resolution SLA; an emailed client reply on an open ticket keeps its SLA alerts; portal Resolve needs an unresolved ticket with its tasks done and Close needs a resolved one; API replies refuse closed tickets, New, Closed or unknown statuses and resolving with open tasks, and sync the SLA clock on a status change; API ticket update re-applies the SLA on a priority change; merging with replies moved takes their attachments and files along; 26.11.9 changelog entries

This commit is contained in:
johnnyq
2026-11-17 16:14:18 -05:00
parent 2ba1074e0e
commit 58cbce83cc
6 changed files with 95 additions and 7 deletions

View File

@@ -34,6 +34,8 @@ require_once '../validate_api_key.php';
require_once '../require_post_method.php';
require_once '../form_input.php';
// Ticket/mail settings for public reply notifications
require_once "../../../includes/load_global_settings.php";
@@ -62,6 +64,18 @@ if (!empty($ticket_id) && !empty($reply)) {
$ticket_row = null;
}
// As on the ticket page: a closed ticket takes no replies, a reply sets only a status a reply may (not New or
// Closed, which ITFlow sets, nor one that doesn't exist), and resolves only once its tasks are done
if ($ticket_row && ($ticket_row['ticket_closed_at'] !== null || intval($ticket_row['ticket_status']) === TICKET_STATUS_CLOSED)) {
apiFormRefuse('That ticket is closed - it takes no replies');
}
if ($ticket_row && !empty($reply_ticket_status) && !in_array($reply_ticket_status, ticketReplyStatuses($ticket_row['ticket_status']), true)) {
apiFormRefuse('ticket_status must be the id of an active status a reply may set - not New or Closed');
}
if ($ticket_row && $reply_ticket_status === TICKET_STATUS_RESOLVED && intval($ticket_row['ticket_status']) !== TICKET_STATUS_RESOLVED && ticketOpenTaskCount($ticket_id)) {
apiFormRefuse("The ticket's tasks aren't all done - it can't be resolved yet");
}
if ($ticket_row) {
$ticket_prefix = escapeSql($ticket_row['ticket_prefix']);
@@ -86,7 +100,13 @@ if (!empty($ticket_id) && !empty($reply)) {
// Optional status change alongside the reply
if (!empty($reply_ticket_status)) {
mysqli_query($mysqli, "UPDATE tickets SET ticket_status = $reply_ticket_status WHERE ticket_id = $ticket_id LIMIT 1");
// Out of Resolved into a working status is a reopen - the resolved time goes and the resolution clock runs again
$reopen = $original_ticket_status === TICKET_STATUS_RESOLVED && $reply_ticket_status !== TICKET_STATUS_RESOLVED;
mysqli_query($mysqli, "UPDATE tickets SET ticket_status = $reply_ticket_status" . ($reopen ? ", ticket_resolved_at = NULL" : "") . " WHERE ticket_id = $ticket_id LIMIT 1");
syncTicketSlaClock($ticket_id);
if ($reopen) {
resetTicketResolutionSla($ticket_id);
}
// Only record a status change when the status actually changed -
// Resolved is left out because the resolve block below logs it

View File

@@ -30,6 +30,11 @@ if (!empty($ticket_id)) {
logTicketHistory($ticket_id, "Edited via the API ($api_key_name)");
// A new priority can mean another SLA - as the priority picker on the ticket page
if (stripslashes($priority) !== (string) $ticket_row['ticket_priority']) {
applyTicketSla($ticket_id);
}
// On or off a project
if ($ticket_project_id !== intval($ticket_row['ticket_project_id'])) {
$project = $ticket_project_id ? projectRow($ticket_project_id) : null;