AS1024/itflow
1
0
Fork 0
mirror of https://github.com/itflow-org/itflow synced 2026-03-03 12:24:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Dynamic modals: codesmell

Browse Source
This commit is contained in:
Marcus Hill
2023-04-09 20:14:15 +01:00
parent bdf74e77ba
commit 5f79931787
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ajax.php
View File

@@ -332,8 +332,9 @@ if (isset($_GET['quote_get_json_details'])) {
$category_sql = mysqli_query( $category_sql = mysqli_query(
$mysqli, $mysqli,
"SELECT category_id, category_name FROM categories "SELECT category_id, category_name FROM categories
WHERE category_type = 'Income' AND (category_archived_at > '$quote_created_at' OR category_archived_at IS NULL) WHERE category_type = 'Income' AND (category_archived_at > '$quote_created_at' OR category_archived_at IS NULL)
ORDER BY category_name"); ORDER BY category_name"
);
while ($row = mysqli_fetch_array($category_sql)) { while ($row = mysqli_fetch_array($category_sql)) {
$response['categories'][] = $row; $response['categories'][] = $row;

2
js/quote_edit_modal.js
View File

@@ -27,7 +27,7 @@ function populateQuoteEditModal(quote_id) {
// Clear Category dropdown // Clear Category dropdown
var i, L = categoryDropdown.options.length -1; var i, L = categoryDropdown.options.length -1;
for(i = L; i >= 0; i--) { for (i = L; i >= 0; i--) {
categoryDropdown.remove(i); categoryDropdown.remove(i);
} }
categoryDropdown[categoryDropdown.length] = new Option('- Category -', '0'); categoryDropdown[categoryDropdown.length] = new Option('- Category -', '0');