From 63b8d9a16a8c3b668d4e7da917fde739ca3c4f3a Mon Sep 17 00:00:00 2001
From: Marcus Hill <bcf8c9f2@opayq.com>
Date: Sun, 11 Dec 2022 14:37:50 +0000
Subject: [PATCH 1/3] Redirect financials dashboard to clients page if user is
 a tech

---
 dashboard_financial.php | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/dashboard_financial.php b/dashboard_financial.php
index eba3b0ce..696eab02 100644
--- a/dashboard_financial.php
+++ b/dashboard_financial.php
@@ -1,6 +1,17 @@
 <?php include("inc_all.php"); ?>
 
-<?php 
+<?php
+
+// Quick fix to prevent non-admins (i.e. techs) seeing financials - redirect to client list
+//  To be removed when we have a proper technical dashboard for techs
+if ($_SESSION['user_role'] != 3) { ?>
+  <script type="text/javascript">
+      window.location.href = 'clients.php';
+  </script>
+<?php
+  exit();
+}
+
 
 function roundUpToNearestMultiple($n, $increment = 1000)
 {

From 1917b3413c210dbf6193763e8562affb8eaff68d Mon Sep 17 00:00:00 2001
From: Marcus Hill <bcf8c9f2@opayq.com>
Date: Sun, 11 Dec 2022 14:41:47 +0000
Subject: [PATCH 2/3] Hide the client actions (edit/delete) button for
 non-admins - they aren't able to use the actions anyway as post.php enforces
 an admin rolecheck

---
 clients.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clients.php b/clients.php
index b62b2f50..c9abb0d6 100644
--- a/clients.php
+++ b/clients.php
@@ -320,7 +320,7 @@ $num_rows = mysqli_fetch_row(mysqli_query($mysqli,"SELECT FOUND_ROWS()"));
             <?php } ?>
 
             <!-- Show actions for Admin role only -->
-            <?php //if($session_user_role == 3) { ?>
+            <?php if($session_user_role == 3) { ?>
               <td>
                 <div class="dropdown dropleft text-center">
                   <button class="btn btn-secondary btn-sm" type="button" data-toggle="dropdown">
@@ -335,7 +335,7 @@ $num_rows = mysqli_fetch_row(mysqli_query($mysqli,"SELECT FOUND_ROWS()"));
                   </div>
                 </div>
               </td>
-            <?php //} ?>
+            <?php } ?>
           </tr>
 
           <?php

From 5c1653dc0abf7634a2883c763bda154b915f1080 Mon Sep 17 00:00:00 2001
From: Marcus Hill <bcf8c9f2@opayq.com>
Date: Sun, 11 Dec 2022 14:47:16 +0000
Subject: [PATCH 3/3] Sonarcloud codesmell, add space after IF

---
 clients.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clients.php b/clients.php
index c9abb0d6..dc075342 100644
--- a/clients.php
+++ b/clients.php
@@ -320,7 +320,7 @@ $num_rows = mysqli_fetch_row(mysqli_query($mysqli,"SELECT FOUND_ROWS()"));
             <?php } ?>
 
             <!-- Show actions for Admin role only -->
-            <?php if($session_user_role == 3) { ?>
+            <?php if ($session_user_role == 3) { ?>
               <td>
                 <div class="dropdown dropleft text-center">
                   <button class="btn btn-secondary btn-sm" type="button" data-toggle="dropdown">