diff --git a/CHANGELOG.md b/CHANGELOG.md index 7ec578d80..b6decdf06 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,17 +2,17 @@ This file documents all notable changes made to ITFlow. -## [26.11.5] +## [26.11.6] ### Upgrading -Update from Maintenance > Update — Queue Update hands the job to cron, which updates the files and applies this release's one database change (3.6.2 to 3.6.3) in the same pass. Nothing else is required. From 26.11.3 or earlier, the same update also brings 26.11.4 and its database changes - see its notes below. Nobody needs to clear their browser's cache afterwards. +Update from Maintenance > Update — Queue Update hands the job to cron, which updates the files and applies this release's one database change (3.6.2 to 3.6.3) in the same pass. Nothing else is required. This release has three security fixes - see Security. From 26.11.3 or earlier, the same update also brings 26.11.4 and its database changes - see its notes below. ### Security -- API: a key whose user has Full access to Clients could read anything in the database - other clients' records, users and their password hashes - whatever that user's role and client access allow. Deleting a client through the API (`clients/delete`) wrote the client's name into the audit log as it was, so a client given a name made for the purpose ran a database query when it was deleted. Every release from 26.09 to 26.11.4 is affected, and there is nothing to do after updating. The audit log, notifications, and the ticket and invoice histories now take any text safely, wherever in ITFlow it comes from. -- Sign-in: the lockout after 15 failed sign-ins in 10 minutes, and the limit of 5 wrong two-step codes, could be got around. A request whose browser identification (its User-Agent) was longer than 250 characters failed to write to the audit log, and both limits count what the log holds - so failed sign-ins sent that way were never counted, never showed in Admin > Sign-ins and never alerted anyone. Anything an agent or an API key did from such a browser went unlogged as well, and ended on an error page although it had been done. Everything is logged now whatever the browser sends, with a long identification cut to fit. Every release up to 26.11.4 is affected. -- Invoices: Charge Saved Card could charge a different client's card. The window only ever listed the cards of the invoice's own client, but an agent who can take payments could send the request with another client's saved card in its place - a client they have no access to included. That client's card was charged, and the payment recorded on the invoice it was sent for. Only a card on file for the invoice's client is accepted now, and only while its payment provider is turned on. Every release up to 26.11.4 is affected. In Stripe, a payment made this way shows one client as the customer and names another in its description. +- API: a key whose user has Full access to Clients could read anything in the database - other clients' records, users and their password hashes - whatever that user's role and client access allow. Deleting a client through the API (`clients/delete`) wrote the client's name into the audit log as it was, so a client given a name made for the purpose ran a database query when it was deleted. Every release from 26.09 to 26.11.5 is affected, and there is nothing to do after updating. The audit log, notifications, and the ticket and invoice histories now take any text safely, wherever in ITFlow it comes from. +- Sign-in: the lockout after 15 failed sign-ins in 10 minutes, and the limit of 5 wrong two-step codes, could be got around. A request whose browser identification (its User-Agent) was longer than 250 characters failed to write to the audit log, and both limits count what the log holds - so failed sign-ins sent that way were never counted, never showed in Admin > Sign-ins and never alerted anyone. Anything an agent or an API key did from such a browser went unlogged as well, and ended on an error page although it had been done. Everything is logged now whatever the browser sends, with a long identification cut to fit. Every release up to 26.11.5 is affected. +- Invoices: Charge Saved Card could charge a different client's card. The window only ever listed the cards of the invoice's own client, but an agent who can take payments could send the request with another client's saved card in its place - a client they have no access to included. That client's card was charged, and the payment recorded on the invoice it was sent for. Only a card on file for the invoice's client is accepted now, and only while its payment provider is turned on. Every release up to 26.11.5 is affected. In Stripe, a payment made this way shows one client as the customer and names another in its description. ### New Features & Updates @@ -20,7 +20,6 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u ### Bug Fixes -- Updates: after an update, pages could act up - menus, buttons, editors and forms not working, or pages looking half old and half new - until each person cleared their browser's cache, and sometimes closed the browser and cleared it again. Browsers kept the copies of ITFlow's scripts and stylesheets from before the update and went on using them with the new pages, for days or weeks. Each one is now asked for by an address that changes when the file does, so after an update browsers fetch what changed straight away and keep using what didn't. This starts with this update: nobody needs to clear their cache for it. - Contract Templates: on an install updated in 25.11, adding a contract template could fail with "Field 'company_id' doesn't have a default value", and Maintenance > Debug listed `contract_templates.company_id` as an extra column. 25.11's update gave the table a column nothing used, and no later update took it away. This update removes it. Installs set up or updated after 25.11 never had it. - Contracts: in Safari, New Contract opened from the Contracts page listed every client's contacts under Contact at the client, whichever client was picked. The list now holds only the contacts of the client picked, in every browser, with its primary contact picked. - Contracts: the contract windows use the same pickers as the rest of ITFlow. Contacts and owners show with their picture or initials and their title, and templates, types, terms, SLAs and categories open as the searchable list used everywhere else - in New, Edit and Copy Contract, sending one to be signed, adding hours, its recurring invoice, and Admin > Contract Templates. @@ -31,9 +30,6 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u ### Developer Updates -- `staticFileUrl($path)` in `functions/app.php` returns `$path?v=` and the file's `filemtime()`, or the path as it is when the file isn't there. Every `