From 746e919affbd685834d40f49df644f8578141f7a Mon Sep 17 00:00:00 2001
From: johnnyq <johnny@pittpc.com>
Date: Tue, 14 Jul 2026 18:00:12 -0400
Subject: [PATCH] Replace Function getFallBack with valueOrDash()

---
 admin/document_template.php                 |  2 +-
 agent/modals/credential/credential_view.php | 16 ++++++++--------
 agent/post/client.php                       |  6 +++---
 functions/app.php                           |  2 +-
 4 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/admin/document_template.php b/admin/document_template.php
index 131ac3c9..e42c6f13 100644
--- a/admin/document_template.php
+++ b/admin/document_template.php
@@ -73,7 +73,7 @@
                             $document_template_content = escapeHtml($row['document_template_content']);
                             $document_template_created_by_name = escapeHtml($row['user_name']);
                             $document_template_created_at = escapeHtml($row['document_template_created_at']);
-                            $document_template_updated_at = escapeHtml(getFallback($row['document_template_updated_at']));
+                            $document_template_updated_at = escapeHtml(valueOrDash($row['document_template_updated_at']));
 
                     ?>
 
diff --git a/agent/modals/credential/credential_view.php b/agent/modals/credential/credential_view.php
index e8db04e0..247f27da 100644
--- a/agent/modals/credential/credential_view.php
+++ b/agent/modals/credential/credential_view.php
@@ -37,7 +37,7 @@ ob_start();
         <i class="fas fa-fw fa-building fa-2x mr-3"></i>
         <div>
             <h5 class="modal-title mb-0"><?php echo $name; ?></h5>
-            <div class="text-muted"><?php echo getFallback($description); ?></div>
+            <div class="text-muted"><?php echo valueOrDash($description); ?></div>
         </div>
     </div>
     <button type="button" class="close text-white" data-dismiss="modal">
@@ -53,12 +53,12 @@ ob_start();
             <h6 class="text-secondary"><i class="fas fa-info-circle mr-2"></i>Vendor Details</h6>
             <div class="row">
                 <div class="col-sm-6">
-                    <div><strong>Account Number:</strong> <?php echo getFallback($account_number); ?></div>
-                    <div><strong>Hours:</strong> <?php echo getFallback($hours); ?></div>
-                    <div><strong>SLA:</strong> <?php echo getFallback($sla); ?></div>
+                    <div><strong>Account Number:</strong> <?php echo valueOrDash($account_number); ?></div>
+                    <div><strong>Hours:</strong> <?php echo valueOrDash($hours); ?></div>
+                    <div><strong>SLA:</strong> <?php echo valueOrDash($sla); ?></div>
                 </div>
                 <div class="col-sm-6">
-                    <div><strong>Code:</strong> <?php echo getFallback($code); ?></div>
+                    <div><strong>Code:</strong> <?php echo valueOrDash($code); ?></div>
                     <div><strong>Website:</strong> <?php echo !empty($website) ? '<a href="' . $website . '" target="_blank" class="text-primary">' . $website . '</a>' : '<span class="text-muted">Not Available</span>'; ?></div>
                 </div>
             </div>
@@ -71,8 +71,8 @@ ob_start();
             <h6 class="text-secondary"><i class="fas fa-user mr-2"></i>Contact Information</h6>
             <div class="row">
                 <div class="col-sm-6">
-                    <div><strong>Contact Name:</strong> <?php echo getFallback($contact_name); ?></div>
-                    <div><strong>Phone:</strong> <?php echo getFallback($phone); ?></div>
+                    <div><strong>Contact Name:</strong> <?php echo valueOrDash($contact_name); ?></div>
+                    <div><strong>Phone:</strong> <?php echo valueOrDash($phone); ?></div>
                 </div>
                 <div class="col-sm-6">
                     <div><strong>Email:</strong> <?php echo !empty($email) ? '<a href="mailto:' . $email . '" class="text-primary">' . $email . '</a>' : '<span class="text-muted">Not Available</span>'; ?></div>
@@ -86,7 +86,7 @@ ob_start();
         <div class="card-body">
             <h6 class="text-secondary"><i class="fas fa-sticky-note mr-2"></i>Notes</h6>
             <div>
-                <?php echo getFallback($notes); ?>
+                <?php echo valueOrDash($notes); ?>
             </div>
         </div>
     </div>
diff --git a/agent/post/client.php b/agent/post/client.php
index 17ca742b..6183219a 100644
--- a/agent/post/client.php
+++ b/agent/post/client.php
@@ -1608,11 +1608,11 @@ if (isset($_POST["export_client_pdf"])) {
           <tbody>";
         while ($row = mysqli_fetch_assoc($sql_credentials)) {
             $credential_name = escapeHtml($row["credential_name"]);
-            $credential_description = getFallback(escapeHtml($row["credential_description"]));
+            $credential_description = valueOrDash(escapeHtml($row["credential_description"]));
             $credential_username = escapeHtml(decryptCredentialEntry($row["credential_username"]));
             $credential_password = escapeHtml(decryptCredentialEntry($row["credential_password"]));
-            $credential_totp_secret = getFallback(escapeHtml($row['credential_otp_secret']));
-            $credential_uri = getFallback(escapeHtml($row["credential_uri"]));
+            $credential_totp_secret = valueOrDash(escapeHtml($row['credential_otp_secret']));
+            $credential_uri = valueOrDash(escapeHtml($row["credential_uri"]));
             $html .= "
             <tr>
               <td>$credential_name</td>
diff --git a/functions/app.php b/functions/app.php
index 0d0b7c7f..7bcc9e1b 100644
--- a/functions/app.php
+++ b/functions/app.php
@@ -75,7 +75,7 @@ function getTicketStatusName($ticket_status) {
 }
 
 // Helper function for missing data fallback
-function getFallback($data) {
+function valueOrDash($data) {
     return !empty($data) ? $data : '-';
 }