From 8b332846b48c2fc81a5137f9711fd795517fe771 Mon Sep 17 00:00:00 2001 From: johnnyq Date: Sat, 21 Nov 2026 01:12:31 -0500 Subject: [PATCH] QoL 53: every badge a rounded pill including the menu counts, the client menu Domains count coloured from the right counts and the Certificates and Licenses counts with one text colour, a grey dash for empty values, flashAlert and itflowToast called with error in place of danger and alert, the errpr alias removed, sentence case column headings, and the client portal search boxes reading Search with hints in the tooltip --- CHANGELOG.md | 3 ++ admin/agent_banners.php | 2 +- admin/ai_models.php | 2 +- admin/ai_providers.php | 6 +-- admin/backup.php | 6 +-- admin/cron.php | 6 +-- admin/debug.php | 2 +- admin/identity_providers.php | 2 +- admin/includes/side_nav.php | 6 +-- admin/mail_queue.php | 4 +- admin/managed_instance.php | 2 +- admin/managed_instances.php | 6 +-- .../mail_queue/mail_queue_message_view.php | 4 +- .../payment_provider_edit.php | 2 +- admin/payment_providers.php | 8 +-- admin/rmm_clients.php | 6 +-- admin/rmm_providers.php | 4 +- admin/saved_payment_methods.php | 10 ++-- admin/settings_client_portal.php | 4 +- admin/settings_mail.php | 8 +-- admin/settings_notification.php | 2 +- admin/text_messages.php | 4 +- admin/text_messaging.php | 4 +- admin/update.php | 6 +-- admin/vendor_template.php | 2 +- agent/asset.php | 2 +- agent/assets.php | 4 +- agent/contact.php | 2 +- agent/contract.php | 2 +- agent/dispatch.php | 8 +-- agent/global_search.php | 4 +- agent/includes/client_overview_side_nav.php | 22 ++++---- agent/includes/client_side_nav.php | 50 +++++++++---------- agent/includes/side_nav.php | 28 +++++------ agent/includes/statement_columns.php | 2 +- agent/js/calendar.js | 2 +- agent/js/files.js | 4 +- agent/modals/expense/expense_import_rules.php | 2 +- agent/modals/import/import.php | 4 +- agent/post/payment.php | 4 +- agent/rack.php | 2 +- agent/reports/audit_activity.php | 2 +- agent/reports/budget.php | 4 +- agent/reports/canned_responses.php | 2 +- agent/reports/client_ticket_time_detail.php | 2 +- agent/reports/document_templates.php | 2 +- agent/reports/license_templates.php | 2 +- agent/reports/profit_loss.php | 2 +- agent/reports/tax_package.php | 2 +- agent/reports/ticket_templates.php | 2 +- agent/reports/time_by_tech.php | 2 +- agent/reports/vendor_templates.php | 2 +- agent/texts.php | 2 +- agent/ticket.php | 18 +++---- client/assets.php | 2 +- client/contacts.php | 2 +- client/contracts.php | 2 +- client/documents.php | 2 +- client/includes/header.php | 4 +- client/invoices.php | 2 +- client/kb.php | 2 +- client/licenses.php | 2 +- client/post.php | 30 +++++------ client/quotes.php | 2 +- client/search.php | 2 +- client/tickets.php | 2 +- functions/offices.php | 2 +- functions/reports.php | 2 +- functions/sanitize.php | 7 ++- functions/ticket.php | 2 +- functions/user_timezone.php | 2 +- includes/inc_alert_feedback.php | 7 ++- includes/top_nav.php | 6 +-- js/ai_review.js | 4 +- js/notifications.js | 4 +- js/ticket_timers.js | 2 +- 76 files changed, 195 insertions(+), 194 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ccb4a0ae2..f7d33b655 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -223,6 +223,7 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u - Dropdowns: the empty first choice reads the same way everywhere - - Select a client -, - Select an account - and so on where you pick one, - Any client -, - Any status - where a list is filtered, and - None -, - No contact -, - Nobody - where it can be left blank. They had said - Select Client -, - Pick a role -, - Which account -, - How it was paid -, - All Clients -, Not Assigned and the like. - Capitals: page and window titles, menu items and buttons are in Title Case - New Ticket, Mark Reviewed, Back Up Now, Turn Off Portal Access - and field labels, section headings, tabs and help are in sentence case - Postal code, Tax rate, Physical location - in the agent pages, Admin and the client portal alike. The settings pages in the menu are now Company Details, Invoices and Billing, Purchase Orders, Client Portal and Single Sign-on. - Lists: the first click on a column you aren't sorting by sorts names A-Z and dates, money and counts newest or largest first, and a second click flips it. It used to go the opposite way to the column you were on, so the first click could go either way. +- Badges and blanks: every badge is a rounded pill, the menu counts included, and an empty value shows as a grey dash everywhere. A request that can't be done - credit over the balance, say - shows in red like every other error, and the client portal's search boxes read Search ... like the agent pages'. ### Bug Fixes @@ -282,6 +283,7 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u - Contacts: the button in the archive window read Arhive. - Tickets: cancelling Reset the timer still marked the timer as stopped in that browser, so it showed as stopped after a reload while it was still counting. - Browser tabs: many pages were named after their file - Kb, Ai Providers, Rmm Providers, Sla, Settings Ticket, Profit Loss - and one with & in its name showed &. Each tab now has the name the menu gives the page, and a rack, an instance and a ticket, document or project template show their own name. +- Client menu: a client's Domains count never turned amber or red for domains about to expire or expired, and the Certificates and Licenses counts carried two text colours at once. ### Developer Updates @@ -450,6 +452,7 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u - Lists: `sortLink($column, $label, $first, $title, $class)` in `functions/format.php` draws a sortable column header from what `includes/filter_header.php` sets, and `sortFirstOrder()` picks the first direction from the column's name. It replaces the 48 copied `$sort_link` closures and the 115 header links written out by hand; a page with its own first directions passes `$first`. - Tab titles: `includes/page_title.php` takes a report's title from `reportCatalog()`, a settings page's from `settingsPages()` and a few others from a short list, and makes the rest from the file name with its acronyms in capitals. `$page_title` is no longer HTML-escaped there - the footer writes it with `json_encode()` and `emptyStateHtml()` escapes it. - Bootstrap 5 classes: `fw-bold` in place of the `text-bold` shim, `text-body-secondary` in place of `text-muted`, and `fas` as the icon prefix in place of Font Awesome 5's `fa` alias, everywhere. The user menu's buttons are `btn-light border`. `css/itflow_custom.css` loses the shims for `text-bold`, `text-xs`, `btn-default`, `btn-flat`, `bg-olive`, `bg-pink` and `bg-purple` and the unused `.small-box` styles. The `data-bs-toggle="tooltip"` on the menu counts did nothing - their `title` still shows - and is gone. +- Messages: `flashAlert()` and `itflowToast()` are called with 'success', 'info', 'warning' and 'error' only - the 'danger' and 'alert' callers now say 'error' (both are still understood), and the unused 'errpr' alias is gone. Column headings are sentence case like field labels. ## [26.11.8] diff --git a/admin/agent_banners.php b/admin/agent_banners.php index 04d6a95f6..9ca549f07 100644 --- a/admin/agent_banners.php +++ b/admin/agent_banners.php @@ -140,7 +140,7 @@ $csrf = $_SESSION['csrf_token']; $preview = mb_strimwidth(trim(preg_replace('/\s+/', ' ', (string) $row['announcement_body'])), 0, 140, '...'); $for_html = intval($row['announcement_client_id']) ? ($row['client_name'] !== null ? '' . escapeHtml($row['client_name']) . '' : 'A client no longer here') - : 'Every client'; + : 'Every client'; $from = $row['announcement_starts_at'] ? date('M j, Y g:i A', strtotime($row['announcement_starts_at'])) : date('M j, Y', strtotime($row['announcement_created_at'])); $until = $row['announcement_ends_at'] ? date('M j, Y g:i A', strtotime($row['announcement_ends_at'])) : 'Until archived'; ?> diff --git a/admin/ai_models.php b/admin/ai_models.php index cdb9eee7e..7df61aec0 100644 --- a/admin/ai_models.php +++ b/admin/ai_models.php @@ -137,7 +137,7 @@ $csrf = $_SESSION['csrf_token']; - ">Not used + ">Not used
diff --git a/admin/ai_providers.php b/admin/ai_providers.php index 1c32a7da7..df0c80e05 100644 --- a/admin/ai_providers.php +++ b/admin/ai_providers.php @@ -123,10 +123,10 @@ $csrf = $_SESSION['csrf_token'];
- Your network + Your network - Secrets sent + Secrets sent
@@ -152,7 +152,7 @@ $csrf = $_SESSION['csrf_token']; · - Not used + Not used
diff --git a/admin/backup.php b/admin/backup.php index eb174555d..ddd77635c 100644 --- a/admin/backup.php +++ b/admin/backup.php @@ -378,9 +378,9 @@ $status_looks = [
- 0 ? escapeHtml(backupFormatBytes($backup['backup_size'])) : '—' ?> + 0 ? escapeHtml(backupFormatBytes($backup['backup_size'])) : '-' ?> - +
@@ -593,7 +593,7 @@ $status_looks = [

Development mode - +

diff --git a/admin/cron.php b/admin/cron.php index 910748af6..12064c892 100644 --- a/admin/cron.php +++ b/admin/cron.php @@ -364,7 +364,7 @@ $status_looks = [ - Off + Off @@ -380,11 +380,11 @@ $status_looks = [
Took
- — + - - + diff --git a/admin/debug.php b/admin/debug.php index 783cb1c2e..622b17497 100644 --- a/admin/debug.php +++ b/admin/debug.php @@ -139,7 +139,7 @@ $action_link = function (array $item, $class) {

- to look at + to look at diff --git a/admin/identity_providers.php b/admin/identity_providers.php index 25f672f9b..e65a9cd06 100644 --- a/admin/identity_providers.php +++ b/admin/identity_providers.php @@ -28,7 +28,7 @@ echo settingsPageStart('identity');
- +
diff --git a/admin/includes/side_nav.php b/admin/includes/side_nav.php index 91a4aa45a..6a8072bec 100644 --- a/admin/includes/side_nav.php +++ b/admin/includes/side_nav.php @@ -20,7 +20,7 @@

Get Started - / + /

@@ -158,7 +158,7 @@ Managed Instances - +

@@ -188,7 +188,7 @@ Mail Queue - +

diff --git a/admin/mail_queue.php b/admin/mail_queue.php index 727105d2a..c154dc108 100644 --- a/admin/mail_queue.php +++ b/admin/mail_queue.php @@ -193,7 +193,7 @@ $filtered_dates = isset($_GET['dtf']) && $_GET['dtf'] !== '' && $_GET['dtf'] !== - +
@@ -205,7 +205,7 @@ $filtered_dates = isset($_GET['dtf']) && $_GET['dtf'] !== '' && $_GET['dtf'] !==
-
+
diff --git a/admin/managed_instance.php b/admin/managed_instance.php index 313d87984..b6c0dca65 100644 --- a/admin/managed_instance.php +++ b/admin/managed_instance.php @@ -371,7 +371,7 @@ $size = function ($mb) { ') ? ' → ' . escapeHtml($app['db_latest']) . '' : '')) ?> ' . (intval($agents['active'] ?? 0) + intval($agents['invites'] ?? 0)) . '' . (intval($agents['limit'] ?? 0) > 0 ? ' of ' . intval($agents['limit']) : '') - . (intval($agents['invites'] ?? 0) > 0 ? '
' . intval($agents['invites']) . ' invited
' : '') : '—') ?> + . (intval($agents['invites'] ?? 0) > 0 ? '
' . intval($agents['invites']) . ' invited
' : '') : '-') ?> Switched off' : 'Last ran ' . $when($cron['last_dispatch_at'] ?? null)) ?> diff --git a/admin/managed_instances.php b/admin/managed_instances.php index f399b013f..b0639c64a 100644 --- a/admin/managed_instances.php +++ b/admin/managed_instances.php @@ -147,12 +147,12 @@ $csrf = $_SESSION['csrf_token'];
- — + - - — + - All good @@ -167,7 +167,7 @@ $csrf = $_SESSION['csrf_token']; 0 ? ' of ' . $seat_limit : '' ?>
0 ? 'seats' : 'agents, no limit' ?>
- — + - diff --git a/admin/modals/mail_queue/mail_queue_message_view.php b/admin/modals/mail_queue/mail_queue_message_view.php index 6ff060071..f5dcd695b 100644 --- a/admin/modals/mail_queue/mail_queue_message_view.php +++ b/admin/modals/mail_queue/mail_queue_message_view.php @@ -70,7 +70,7 @@ if (!$row) { ?>