From 94c020f68989590b97898969ed140557b499dad5 Mon Sep 17 00:00:00 2001 From: johnnyq Date: Tue, 28 Feb 2023 22:15:09 -0500 Subject: [PATCH] Fix issue clients listing being broken with MySQL server due to not specifiying all non aggregate columns be in the GROUP BY Field, this was not an issue with mariaDB --- clients.php | 2 +- js/multi_actions.js | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/clients.php b/clients.php index 079269b5..589cf52a 100644 --- a/clients.php +++ b/clients.php @@ -21,7 +21,7 @@ $sql = mysqli_query( AND client_archived_at IS NULL AND DATE(client_created_at) BETWEEN '$dtf' AND '$dtt' AND clients.company_id = $session_company_id - GROUP BY client_id + GROUP BY clients.client_id, contacts.contact_id, locations.location_id, client_tags.client_tag_tag_id, tags.tag_id ORDER BY $sb $o LIMIT $record_from, $record_to "); diff --git a/js/multi_actions.js b/js/multi_actions.js index d81905e0..51c73de3 100644 --- a/js/multi_actions.js +++ b/js/multi_actions.js @@ -1,5 +1,3 @@ - - var checkboxes = document.querySelectorAll('form input[type="checkbox"]'); var selectedCount = document.getElementById("selectedCount"); @@ -25,9 +23,7 @@ function updateSelectedCount() { } function checkAll(source) { - for (var i = 0; i < checkboxes.length; i++) { checkboxes[i].checked = source.checked; - } }