From 950d02d6ab1787cf3b1123289493bd478917601d Mon Sep 17 00:00:00 2001
From: johnnyq <johnny@pittpc.com>
Date: Fri, 28 Aug 2026 19:41:00 -0400
Subject: [PATCH] Fix: Six ajax modals had dead JS - DOMContentLoaded had
 already fired before their scripts were injected. New itflowReady() helper
 restores jQuery .ready() semantics. Fixes notification pagination, asset OS
 autocomplete, contact auth toggle, AI ticket summary, AI document template
 generation

---
 .../document_template_add.php                 |  2 +-
 agent/modals/asset/asset_add.php              |  2 +-
 agent/modals/contact/contact_add.php          |  2 +-
 agent/modals/contact/contact_edit.php         |  2 +-
 agent/modals/ticket/ticket_summary.php        |  2 +-
 js/app.js                                     | 25 +++++++++++++++----
 modals/notifications.php                      |  5 ++--
 7 files changed, 28 insertions(+), 12 deletions(-)

diff --git a/admin/modals/document_template/document_template_add.php b/admin/modals/document_template/document_template_add.php
index e9361181b..c38fe28e4 100644
--- a/admin/modals/document_template/document_template_add.php
+++ b/admin/modals/document_template/document_template_add.php
@@ -49,7 +49,7 @@ ob_start();
 </form>
 
 <script>
-document.addEventListener('DOMContentLoaded', function () {
+itflowReady(function () {
 
     var button = document.getElementById('generateAIContent');
     var promptField = document.getElementById('aiPrompt');
diff --git a/agent/modals/asset/asset_add.php b/agent/modals/asset/asset_add.php
index cc3f2f48b..20255c239 100644
--- a/agent/modals/asset/asset_add.php
+++ b/agent/modals/asset/asset_add.php
@@ -461,7 +461,7 @@ ob_start();
 
 <!-- JSON Autocomplete / type ahead -->
 <script>
-    document.addEventListener('DOMContentLoaded', function () {
+    itflowReady(function () {
 
         var operatingSystems = <?= $json_os ?>;
 
diff --git a/agent/modals/contact/contact_add.php b/agent/modals/contact/contact_add.php
index 91cf43ec9..f5f932f65 100644
--- a/agent/modals/contact/contact_add.php
+++ b/agent/modals/contact/contact_add.php
@@ -315,7 +315,7 @@ function generatePassword() {
     );
 }
 
-document.addEventListener('DOMContentLoaded', function () {
+itflowReady(function () {
     function syncAuthForm(select) {
         var form = select.closest('.authForm');
         if (!form) {
diff --git a/agent/modals/contact/contact_edit.php b/agent/modals/contact/contact_edit.php
index ab0e6a260..51badbbc4 100644
--- a/agent/modals/contact/contact_edit.php
+++ b/agent/modals/contact/contact_edit.php
@@ -351,7 +351,7 @@ function generatePassword() {
     );
 }
 
-document.addEventListener('DOMContentLoaded', function () {
+itflowReady(function () {
     function syncAuthForm(select) {
         var form = select.closest('.authForm');
         if (!form) {
diff --git a/agent/modals/ticket/ticket_summary.php b/agent/modals/ticket/ticket_summary.php
index dfd3fa5c6..eb1b8d1e9 100644
--- a/agent/modals/ticket/ticket_summary.php
+++ b/agent/modals/ticket/ticket_summary.php
@@ -19,7 +19,7 @@ ob_start();
 </div>
 
 <script>
-document.addEventListener('DOMContentLoaded', function () {
+itflowReady(function () {
     var target = document.getElementById('summaryContent');
     if (!target) {
         return;
diff --git a/js/app.js b/js/app.js
index 9bfb0c6d2..116e11af2 100644
--- a/js/app.js
+++ b/js/app.js
@@ -108,6 +108,25 @@ function itflowBindOnce(name, type, selector, handler) {
     });
 }
 
+/**
+ * Run fn once the DOM is ready, the way jQuery's .ready() did.
+ *
+ * js/ajax_modal.js injects a modal payload's <script> tags long after
+ * DOMContentLoaded has fired, so a bare
+ * document.addEventListener('DOMContentLoaded', ...) inside one of them
+ * registers for an event that will never come again and the body silently
+ * never runs. jQuery's .ready() invoked the callback immediately when the
+ * document was already parsed, which is why that pattern worked before the
+ * vanilla conversion. Modal payload scripts must use this instead.
+ */
+function itflowReady(fn) {
+    if (document.readyState === 'loading') {
+        document.addEventListener('DOMContentLoaded', fn);
+    } else {
+        fn();
+    }
+}
+
 function itflowInit() {
     // Prevents resubmit on forms
     if (window.history.replaceState) {
@@ -636,11 +655,7 @@ function itflowInit() {
 
 // modal_footer.php re-loads this file on every ajax modal open, so run now if
 // the document is already parsed, otherwise wait for it.
-if (document.readyState === 'loading') {
-    document.addEventListener('DOMContentLoaded', itflowInit);
-} else {
-    itflowInit();
-}
+itflowReady(itflowInit);
 
 /*
  * Calendar event modals - the All day switch shows or hides the time row.
diff --git a/modals/notifications.php b/modals/notifications.php
index 788880e89..d2fb0d5f3 100644
--- a/modals/notifications.php
+++ b/modals/notifications.php
@@ -65,7 +65,8 @@ ob_start();
         </table>
         <div class="text-center mt-2">
             <button id="prev-btn" class="btn btn-sm btn-outline-secondary me-2"><i class="fas fa-caret-left"></i></button>
-            <button id="next-btn" class="btn btn-sm btn-outline-secondary"><i class="fas fa-caret-right"></i></button>
+            <span id="page-indicator" class="small text-muted mx-2"></span>
+            <button id="next-btn" class="btn btn-sm btn-outline-secondary ms-2"><i class="fas fa-caret-right"></i></button>
         </div>
     <?php } else { ?>
     <div class="text-center text-secondary pt-3">
@@ -94,7 +95,7 @@ ob_start();
 </div>
 
 <script>
-document.addEventListener('DOMContentLoaded', function () {
+itflowReady(function () {
     var perPage = 8;
     var items = Array.from(document.querySelectorAll('.notification-item'));
     var totalItems = items.length;