From 85a759f7db916eb576415325fbf63862e069e0aa Mon Sep 17 00:00:00 2001
From: Andrew Malsbury <andymalsb@gmail.com>
Date: Wed, 25 Oct 2023 14:07:47 +0000
Subject: [PATCH] Removed useless assignment

---
 top_nav.php | 230 +++++++++++++++++++++++++++-------------------------
 1 file changed, 120 insertions(+), 110 deletions(-)

diff --git a/top_nav.php b/top_nav.php
index 28851c00..4973b63a 100644
--- a/top_nav.php
+++ b/top_nav.php
@@ -1,61 +1,65 @@
 <!-- Navbar -->
 <nav class="main-header navbar navbar-expand navbar-<?php echo nullable_htmlentities($config_theme); ?> navbar-dark">
 
-  <!-- Left navbar links -->
-  <ul class="navbar-nav">
-    <li class="nav-item">
-      <a class="nav-link" data-widget="pushmenu" data-enable-remember="TRUE" href="#"><i class="fas fa-bars"></i></a>
-    </li>
-  </ul>
+    <!-- Left navbar links -->
+    <ul class="navbar-nav">
+        <li class="nav-item">
+            <a class="nav-link" data-widget="pushmenu" data-enable-remember="TRUE" href="#"><i
+                    class="fas fa-bars"></i></a>
+        </li>
+    </ul>
 
-   <!-- Center navbar links -->
+    <!-- Center navbar links -->
 
-  <ul class="navbar-nav ml-auto">
+    <ul class="navbar-nav ml-auto">
 
-    <!-- SEARCH FORM -->
-    <form class="form-inline" action="global_search.php">
-      <div class="input-group input-group-sm">
-        <input class="form-control form-control-navbar" type="search" placeholder="Search" name="query" value="<?php if (isset($_GET['query'])) { echo nullable_htmlentities($_GET['query']); } ?>">
-        <div class="input-group-append">
-          <button class="btn btn-navbar" type="submit">
-            <i class="fas fa-search"></i>
-          </button>
-        </div>
-      </div>
-    </form>
-  </ul>
+        <!-- SEARCH FORM -->
+        <form class="form-inline" action="global_search.php">
+            <div class="input-group input-group-sm">
+                <input class="form-control form-control-navbar" type="search" placeholder="Search" name="query"
+                    value="<?php if (isset($_GET['query'])) { echo nullable_htmlentities($_GET['query']); } ?>">
+                <div class="input-group-append">
+                    <button class="btn btn-navbar" type="submit">
+                        <i class="fas fa-search"></i>
+                    </button>
+                </div>
+            </div>
+        </form>
+    </ul>
 
-  <!-- Right navbar links -->
+    <!-- Right navbar links -->
 
-  <ul class="navbar-nav ml-auto">
+    <ul class="navbar-nav ml-auto">
 
-    <li class="nav-item">
-      <a class="nav-link" href="https://docs.itflow.org" target="_blank">
-        <i class="fas fa-fw fa-question"></i>
-      </a>
-    </li>
+        <li class="nav-item">
+            <a class="nav-link" href="https://docs.itflow.org" target="_blank">
+                <i class="fas fa-fw fa-question"></i>
+            </a>
+        </li>
 
-    <!-- New Notifications Dropdown -->
-    <?php
+        <!-- New Notifications Dropdown -->
+        <?php
     $sql_notifications = mysqli_query($mysqli, "SELECT * FROM notifications 
-      LEFT JOIN clients ON notification_client_id = client_id 
-      WHERE notification_dismissed_at IS NULL 
-      AND (notification_user_id = $session_user_id OR notification_user_id = 0) 
-      ORDER BY notification_id DESC LIMIT 5"
+        LEFT JOIN clients ON notification_client_id = client_id 
+        WHERE notification_dismissed_at IS NULL 
+        AND (notification_user_id = $session_user_id OR notification_user_id = 0) 
+        ORDER BY notification_id DESC LIMIT 5"
     );
     ?>
 
-    <?php if ($num_notifications > 0) { ?>
-    <li class="nav-item dropdown">
-      <a class="nav-link" data-toggle="dropdown" href="#" aria-expanded="false">
-        <i class="far fa-bell"></i>
-        <span class="badge badge-danger navbar-badge"><?php echo $num_notifications; ?></span>
+        <?php if ($num_notifications > 0) { ?>
+        <li class="nav-item dropdown">
+            <a class="nav-link" data-toggle="dropdown" href="#" aria-expanded="false">
+                <i class="far fa-bell"></i>
+                <span class="badge badge-danger navbar-badge"><?php echo $num_notifications; ?></span>
 
-      </a>
-      <div class="dropdown-menu dropdown-menu-xlg dropdown-menu-right" style="left: inherit; right: 0px;">
-        <a href="notifications.php" class="dropdown-item dropdown-header"><i class="fas fa-fw fa-bell mr-2"></i><strong><?php echo $num_notifications; ?></strong> Notifications</a>
-        <div class="dropdown-divider"></div>
-        <?php
+            </a>
+            <div class="dropdown-menu dropdown-menu-xlg dropdown-menu-right" style="left: inherit; right: 0px;">
+                <a href="notifications.php" class="dropdown-item dropdown-header"><i
+                        class="fas fa-fw fa-bell mr-2"></i><strong><?php echo $num_notifications; ?></strong>
+                    Notifications</a>
+                <div class="dropdown-divider"></div>
+                <?php
         while ($row = mysqli_fetch_array($sql_notifications)) {
             $notification_id = intval($row['notification_id']);
             $notification_type = nullable_htmlentities($row['notification_type']);
@@ -63,82 +67,88 @@
             $notification_action = nullable_htmlentities($row['notification_action']);
             $notification_timestamp = date('M d g:ia',strtotime($row['notification_timestamp']));
             $notification_client_id = intval($row['notification_client_id']);
-            if(!empty($notification_action)){
-              $notification_action = $notification_action;
-            } else {
-              $notification_action = "#";
+            if(empty($notification_action)){
+                $notification_action = "#";
             }
         ?>
-        <div class="dropdown-item">
-          <a class="text-dark" href="<?php echo $notification_action; ?>">
-            <p class="mb-1">
-              <span class="text-bold"><i class="fas fa-bullhorn mr-2"></i><?php echo $notification_type; ?></span>
-              <small class="text-muted mt-1 float-right"><?php echo $notification_timestamp; ?></small>
-            </p>
-            <small class="text-secondary"><?php echo $notification; ?></small>
-          </a>
-        </div>
+                <div class="dropdown-item">
+                    <a class="text-dark" href="<?php echo $notification_action; ?>">
+                        <p class="mb-1">
+                            <span class="text-bold"><i
+                                    class="fas fa-bullhorn mr-2"></i><?php echo $notification_type; ?></span>
+                            <small class="text-muted mt-1 float-right"><?php echo $notification_timestamp; ?></small>
+                        </p>
+                        <small class="text-secondary"><?php echo $notification; ?></small>
+                    </a>
+                </div>
 
-        <?php
+                <?php
         }
         ?>
 
-        <div class="dropdown-divider"></div>
-        <a href="post.php?dismiss_all_notifications" class="dropdown-item dropdown-footer text-secondary text-bold"><i class="fa fa-fw fa-check mr-2"></i>Dismiss Notifications</a>
-      </div>
-    </li>
-    <?php } else { ?>
+                <div class="dropdown-divider"></div>
+                <a href="post.php?dismiss_all_notifications"
+                    class="dropdown-item dropdown-footer text-secondary text-bold"><i
+                        class="fa fa-fw fa-check mr-2"></i>Dismiss Notifications</a>
+            </div>
+        </li>
+        <?php } else { ?>
 
-    <li class="nav-item dropdown">
-      <a class="nav-link" data-toggle="dropdown" href="#" aria-expanded="false">
-        <i class="far fa-bell"></i>
-      </a>
-      <div class="dropdown-menu dropdown-menu dropdown-menu-right" style="left: inherit; right: 0px;">
-        <span class="dropdown-item dropdown-header">No Notifications</span>
-        <div class="dropdown-divider"></div>
-        <div class="text-center text-secondary p-3">
-          <i class='far fa-fw fa-4x fa-bell'></i>
-        </div>
-        <div class="dropdown-divider"></div>
-        <a href="notifications_dismissed.php" class="dropdown-item dropdown-footer">See Dismissed Notifications</a>
-      </div>
-    </li>
+        <li class="nav-item dropdown">
+            <a class="nav-link" data-toggle="dropdown" href="#" aria-expanded="false">
+                <i class="far fa-bell"></i>
+            </a>
+            <div class="dropdown-menu dropdown-menu dropdown-menu-right" style="left: inherit; right: 0px;">
+                <span class="dropdown-item dropdown-header">No Notifications</span>
+                <div class="dropdown-divider"></div>
+                <div class="text-center text-secondary p-3">
+                    <i class='far fa-fw fa-4x fa-bell'></i>
+                </div>
+                <div class="dropdown-divider"></div>
+                <a href="notifications_dismissed.php" class="dropdown-item dropdown-footer">See Dismissed
+                    Notifications</a>
+            </div>
+        </li>
 
-    <?php } ?>
-
-    <!-- End New Notifications Dropdown -->
-
-    <li class="nav-item dropdown user-menu">
-      <a href="#" class="nav-link" data-toggle="dropdown">
-        <?php if (empty($session_avatar)) { ?>
-        	<i class="fa fa-fw fa-user"></i>
-        <?php }else{ ?>
-        <img src="<?php echo "uploads/users/$session_user_id/$session_avatar"; ?>" class="user-image img-circle">
         <?php } ?>
-        <span class="d-none d-md-inline dropdown-toggle"><?php echo stripslashes(nullable_htmlentities($session_name)); ?></span>
-      </a>
-      <ul class="dropdown-menu dropdown-menu-lg dropdown-menu-right">
-        <!-- User image -->
-        <li class="user-header bg-gray-dark">
-          <?php if (empty($session_avatar)) { ?>
-          	<i class="fas fa-user-circle fa-6x"></i>
-          <?php }else{ ?>
 
-          	<img src="<?php echo "uploads/users/$session_user_id/$session_avatar"; ?>" class="img-circle">
-					<?php } ?>
-          <p>
-            <?php echo stripslashes(nullable_htmlentities($session_name)); ?>
-            <small><?php echo nullable_htmlentities($session_user_role_display); ?></small>
-          </p>
-        </li>
-        <!-- Menu Footer-->
-        <li class="user-footer">
-          <a href="user_profile.php" class="btn btn-default btn-flat"><i class="fas fa-cog mr-2"></i>Profile</a>
-          <a href="post.php?logout" class="btn btn-default btn-flat float-right"><i class="fas fa-sign-out-alt mr-2"></i>Sign out</a>
-        </li>
-      </ul>
-    </li>
+        <!-- End New Notifications Dropdown -->
 
-  </ul>
+        <li class="nav-item dropdown user-menu">
+            <a href="#" class="nav-link" data-toggle="dropdown">
+                <?php if (empty($session_avatar)) { ?>
+                <i class="fa fa-fw fa-user"></i>
+                <?php }else{ ?>
+                <img src="<?php echo "uploads/users/$session_user_id/$session_avatar"; ?>"
+                    class="user-image img-circle">
+                <?php } ?>
+                <span
+                    class="d-none d-md-inline dropdown-toggle"><?php echo stripslashes(nullable_htmlentities($session_name)); ?></span>
+            </a>
+            <ul class="dropdown-menu dropdown-menu-lg dropdown-menu-right">
+                <!-- User image -->
+                <li class="user-header bg-gray-dark">
+                    <?php if (empty($session_avatar)) { ?>
+                    <i class="fas fa-user-circle fa-6x"></i>
+                    <?php }else{ ?>
+
+                    <img src="<?php echo "uploads/users/$session_user_id/$session_avatar"; ?>" class="img-circle">
+                    <?php } ?>
+                    <p>
+                        <?php echo stripslashes(nullable_htmlentities($session_name)); ?>
+                        <small><?php echo nullable_htmlentities($session_user_role_display); ?></small>
+                    </p>
+                </li>
+                <!-- Menu Footer-->
+                <li class="user-footer">
+                    <a href="user_profile.php" class="btn btn-default btn-flat"><i
+                            class="fas fa-cog mr-2"></i>Profile</a>
+                    <a href="post.php?logout" class="btn btn-default btn-flat float-right"><i
+                            class="fas fa-sign-out-alt mr-2"></i>Sign out</a>
+                </li>
+            </ul>
+        </li>
+
+    </ul>
 </nav>
-<!-- /.navbar -->
+<!-- /.navbar -->
\ No newline at end of file