AS1024/itflow
1
0
Fork 0
mirror of https://github.com/itflow-org/itflow synced 2026-02-28 02:44:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change client - fix code smell

Browse Source
This commit is contained in:
Marcus Hill
2023-04-10 19:13:31 +01:00
parent c55d2a8cda
commit a26f3087fc
4 changed files with 12 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
js/ticket_change_client.js
View File

@@ -3,16 +3,15 @@
*/
// Modal loaded listener - populate client select
changeClientModalLoad = document.getElementById('clientChangeTicketModalLoad');
const changeClientModalLoad = document.getElementById('clientChangeTicketModalLoad');
changeClientModalLoad.addEventListener('click', function() {
populateChangeClientModal_Clients();
})
// Client selected listener - populate contact select
// We seem to have to use jQuery to listen for events, as the client input is a select2 component?
clientSelectDropdown = document.getElementById("changeClientSelect");
const clientSelectDropdown = document.getElementById("changeClientSelect");
$(clientSelectDropdown).on('select2:select', function (e) {
console.log("Fired contacts listener!!!!!!")
let client_id = $(this).find(':selected').val();
populateChangeClientModal_Contacts(client_id);
});
@@ -43,7 +42,7 @@ function populateChangeClientModal_Clients() {
// Client dropdown already defined in listeners as clientSelectDropdown
// Clear dropdown
var i, L = clientSelectDropdown.options.length -1;
let i, L = clientSelectDropdown.options.length - 1;
for (i = L; i >= 0; i--) {
clientSelectDropdown.remove(i);
}
@@ -76,10 +75,10 @@ function populateChangeClientModal_Contacts(client_id) {
const contacts = response.contacts;
// Contacts dropdown
var contactSelectDropdown = document.getElementById("changeContactSelect");
const contactSelectDropdown = document.getElementById("changeContactSelect");
// Clear Category dropdown
var i, L = contactSelectDropdown.options.length -1;
let i, L = contactSelectDropdown.options.length - 1;
for (i = L; i >= 0; i--) {
contactSelectDropdown.remove(i);
}