mirror of
https://github.com/itflow-org/itflow
synced 2026-08-05 07:07:14 +00:00
Encrypted backups with types, scheduling and CLI restore
Backups are now AES-256 encrypted zips in three types (full, database only, master key), catalogued in a new backups table, built by cron rather than the web request, and kept under uploads/backups with retention in the nightly job. The encryption key is one value per install held in config.php, never in the database and never in the file name. Restore is shared by the setup wizard and the new scripts/restore_cli.php, which is the only path without an upload size limit. It verifies the key and unpacks the archive before dropping anything, and dumps the current database first so a failed import is rolled back. A backup dumps, zips and encrypts for minutes without issuing a query, so on a server with a short wait_timeout the connection is closed underneath it and the UPDATE marking the backup complete is what fails - long after the archive was written correctly. The connection is now held open for the job and re-established before any write that follows long file work, including the database phase of a restore. Retention recovers rows a dropped connection left behind: still Running after six hours becomes Complete if the archive is on disk, Failed if it is not. cron.php's own failure path is hardened to match. It recorded job failures through the same connection the failing job had just killed, so an uncaught exception ended the dispatch and no trace of the original error survived. Failures now also echo to stdout, so cron mails something useful when the database is unreachable. Security: the setup wizard's restore step is now closed on any install that has users, whatever config.php says. $config_enable_setup defaulted to enabled when the flag was absent, and the flag is only written at the end of a successful install, so an install abandoned partway left an unauthenticated endpoint that would drop every table, import an attacker-supplied archive, and overwrite uploads/ including the .htaccess that stops PHP running there. Affects 26.07 and earlier. Restoring over a live install is now CLI only.
This commit is contained in:
@@ -23,6 +23,10 @@
|
||||
* That shared use is why this sits here rather than in cron/includes/ with the lock, which
|
||||
* only cron loads: the admin pages would otherwise be reaching into the cron directory.
|
||||
*
|
||||
* 'enabled' => 0 ships a job switched off - the row is seeded disabled and stays that way
|
||||
* until somebody turns it on in Settings > Cron. Used for work an install should opt into
|
||||
* rather than inherit from an upgrade, like the backup job filling a disk overnight.
|
||||
*
|
||||
* 'interval_safe' => false marks a job whose work repeats if the day repeats - nightly's
|
||||
* late fees and overdue reminders fire again on a second run of the same day. Settings >
|
||||
* Cron only offers the daily schedule for such a job, and the dispatcher refuses to run
|
||||
@@ -73,6 +77,16 @@ function cronJobRegistry(): array
|
||||
'daily_at' => '03:00',
|
||||
'interval_safe' => false,
|
||||
],
|
||||
[
|
||||
'name' => 'backup',
|
||||
'label' => 'Backup',
|
||||
'script' => 'backup.php',
|
||||
'description' => 'Builds the scheduled backup and anything queued from Settings > Backup. Off by default.',
|
||||
'schedule' => 'Daily',
|
||||
'daily_at' => '02:00',
|
||||
'enabled' => 0,
|
||||
'interval_safe' => false,
|
||||
],
|
||||
[
|
||||
'name' => 'certificate_refresher',
|
||||
'label' => 'Certificate Refresher',
|
||||
|
||||
Reference in New Issue
Block a user