More sweeps to replace select * with actual returned column names dramatically reduces php memory usage and speeds up processing dramatically especially in the crons since they run all the time

This commit is contained in:
johnnyq
2026-08-06 13:10:23 -04:00
parent b8c9d5b4cf
commit b3744e9ed5
247 changed files with 816 additions and 457 deletions

View File

@@ -20,7 +20,7 @@
<select class="form-control select2" name="file_id">
<option value="">- Select a File -</option>
<?php
$sql_files_select = mysqli_query($mysqli, "SELECT * FROM files
$sql_files_select = mysqli_query($mysqli, "SELECT file_id, file_name, folder_name FROM files
LEFT JOIN folders ON folder_id = file_folder_id
WHERE file_client_id = $client_id ORDER BY folder_name ASC, file_name ASC");
while ($row = mysqli_fetch_assoc($sql_files_select)) {

View File

@@ -77,7 +77,7 @@ ob_start();
<select class="form-control" name="folder">
<option value="0">/</option>
<?php
$sql_folders = mysqli_query($mysqli, "SELECT * FROM folders WHERE folder_client_id = $client_id ORDER BY folder_name ASC");
$sql_folders = mysqli_query($mysqli, "SELECT folder_id, folder_name FROM folders WHERE folder_client_id = $client_id ORDER BY folder_name ASC");
while ($row = mysqli_fetch_assoc($sql_folders)) {
$folder_id = intval($row['folder_id']);
$folder_name = escapeHtml($row['folder_name']);

View File

@@ -6,7 +6,8 @@ enforceUserPermission('module_support', 2);
$document_id = intval($_GET['id']);
$sql = mysqli_query($mysqli, "SELECT * FROM documents WHERE document_id = $document_id LIMIT 1");
$sql = mysqli_query($mysqli, "SELECT document_client_id, document_client_visible, document_content, document_description,
document_folder_id, document_name FROM documents WHERE document_id = $document_id LIMIT 1");
$row = mysqli_fetch_assoc($sql);
$document_name = escapeHtml($row['document_name']);

View File

@@ -4,7 +4,7 @@ require_once '../../../includes/modal_header.php';
$document_id = intval($_GET['document_id']);
$sql = mysqli_query($mysqli, "SELECT * FROM documents
$sql = mysqli_query($mysqli, "SELECT document_client_id, document_client_visible, document_name FROM documents
WHERE document_id = $document_id
LIMIT 1
");

View File

@@ -4,7 +4,7 @@ require_once '../../../includes/modal_header.php';
$document_id = intval($_GET['document_id']);
$sql = mysqli_query($mysqli, "SELECT * FROM documents
$sql = mysqli_query($mysqli, "SELECT document_client_id, document_name FROM documents
WHERE document_id = $document_id
LIMIT 1
");

View File

@@ -4,7 +4,7 @@ require_once '../../../includes/modal_header.php';
$document_id = intval($_GET['document_id']);
$sql = mysqli_query($mysqli, "SELECT * FROM documents
$sql = mysqli_query($mysqli, "SELECT document_client_id, document_name FROM documents
WHERE document_id = $document_id
LIMIT 1
");

View File

@@ -4,7 +4,7 @@ require_once '../../../includes/modal_header.php';
$document_id = intval($_GET['document_id']);
$sql = mysqli_query($mysqli, "SELECT * FROM documents
$sql = mysqli_query($mysqli, "SELECT document_client_id, document_name FROM documents
WHERE document_id = $document_id
LIMIT 1
");

View File

@@ -4,7 +4,7 @@ require_once '../../../includes/modal_header.php';
$document_id = intval($_GET['document_id']);
$sql = mysqli_query($mysqli, "SELECT * FROM documents
$sql = mysqli_query($mysqli, "SELECT document_client_id, document_name FROM documents
WHERE document_id = $document_id
LIMIT 1
");

View File

@@ -4,7 +4,7 @@ require_once '../../../includes/modal_header.php';
$document_id = intval($_GET['document_id']);
$sql = mysqli_query($mysqli, "SELECT * FROM documents
$sql = mysqli_query($mysqli, "SELECT document_client_id, document_name FROM documents
WHERE document_id = $document_id
LIMIT 1
");

View File

@@ -6,7 +6,7 @@ enforceUserPermission('module_support', 2);
$document_id = intval($_GET['id']);
$sql = mysqli_query($mysqli, "SELECT * FROM documents WHERE document_id = $document_id LIMIT 1");
$sql = mysqli_query($mysqli, "SELECT document_client_id, document_folder_id, document_name FROM documents WHERE document_id = $document_id LIMIT 1");
$row = mysqli_fetch_assoc($sql);
$client_id = intval($row['document_client_id']);

View File

@@ -6,7 +6,7 @@ enforceUserPermission('module_support', 2);
$document_id = intval($_GET['id']);
$sql = mysqli_query($mysqli, "SELECT * FROM documents WHERE document_id = $document_id LIMIT 1");
$sql = mysqli_query($mysqli, "SELECT document_client_id, document_name FROM documents WHERE document_id = $document_id LIMIT 1");
$row = mysqli_fetch_assoc($sql);
$client_id = intval($row['document_client_id']);

View File

@@ -14,7 +14,7 @@ $purifier = new HTMLPurifier($purifier_config);
$document_version_id = intval($_GET['id']);
$sql = mysqli_query($mysqli, "SELECT * FROM document_versions LEFT JOIN documents ON document_id = document_version_document_id WHERE document_version_id = $document_version_id LIMIT 1");
$sql = mysqli_query($mysqli, "SELECT document_client_id, document_version_content, document_version_name FROM document_versions LEFT JOIN documents ON document_id = document_version_document_id WHERE document_version_id = $document_version_id LIMIT 1");
$row = mysqli_fetch_assoc($sql);
$document_version_name = escapeHtml($row['document_version_name']);

View File

@@ -14,7 +14,7 @@ $purifier = new HTMLPurifier($purifier_config);
$document_id = intval($_GET['id']);
$sql = mysqli_query($mysqli, "SELECT * FROM documents WHERE document_id = $document_id LIMIT 1");
$sql = mysqli_query($mysqli, "SELECT document_client_id, document_content, document_name FROM documents WHERE document_id = $document_id LIMIT 1");
$row = mysqli_fetch_assoc($sql);
$document_name = escapeHtml($row['document_name']);