AS1024/itflow
1
0
Fork 0
mirror of https://github.com/itflow-org/itflow synced 2026-08-17 04:55:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Query Optimization: Select only needed columns instead of SELECT * on looped queries

Browse Source
This commit is contained in:
johnnyq
2026-08-06 12:59:43 -04:00
parent 77defcf7d8
commit b8c9d5b4cf
117 changed files with 345 additions and 227 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
agent/modals/certificate/certificate_add.php
View File

@@ -93,7 +93,7 @@ ob_start();
<select class="form-control select2" name="domain_id">
<option value="">- Domain -</option>
<?php
$domains_sql = mysqli_query($mysqli, "SELECT * FROM domains WHERE domain_archived_at IS NULL AND domain_client_id = $client_id ORDER BY domain_name ASC");
$domains_sql = mysqli_query($mysqli, "SELECT domain_id, domain_name FROM domains WHERE domain_archived_at IS NULL AND domain_client_id = $client_id ORDER BY domain_name ASC");
while ($domain_row = mysqli_fetch_assoc($domains_sql)) {
$domain_id = intval($domain_row['domain_id']);
$domain_name = escapeHtml($domain_row['domain_name']);

3
agent/modals/certificate/certificate_edit.php
View File

@@ -20,7 +20,8 @@ $certificate_expire = escapeHtml($row['certificate_expire']);
$certificate_created_at = escapeHtml($row['certificate_created_at']);
$client_id = intval($row['certificate_client_id']);
$history_sql = mysqli_query($mysqli, "SELECT * FROM certificate_history WHERE certificate_history_certificate_id = $certificate_id");
$history_sql = mysqli_query($mysqli, "SELECT certificate_history_column, certificate_history_modified_at, certificate_history_new_value,
certificate_history_old_value FROM certificate_history WHERE certificate_history_certificate_id = $certificate_id");
enforceClientAccess();