AS1024/itflow
1
0
Fork 0
mirror of https://github.com/itflow-org/itflow synced 2026-08-17 04:55:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Query Optimization: Select only needed columns instead of SELECT * on looped queries

Browse Source
This commit is contained in:
johnnyq
2026-08-06 12:59:43 -04:00
parent 77defcf7d8
commit b8c9d5b4cf
117 changed files with 345 additions and 227 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
agent/modals/invoice/invoice_add.php
View File

@@ -32,7 +32,7 @@ ob_start();
<option value="">- Select a Client -</option>
<?php
//select unarchived clients
$sql = mysqli_query($mysqli, "SELECT * FROM clients WHERE client_archived_at IS NULL " . clientScopeSql('clients.client_id') . " ORDER BY client_name ASC");
$sql = mysqli_query($mysqli, "SELECT client_id, client_name FROM clients WHERE client_archived_at IS NULL " . clientScopeSql('clients.client_id') . " ORDER BY client_name ASC");
while ($row = mysqli_fetch_assoc($sql)) {
$client_id_select = intval($row['client_id']);
$client_name = escapeHtml($row['client_name']);

3
agent/modals/invoice/invoice_payments.php
View File

@@ -21,7 +21,8 @@ $invoice_badge_color = getInvoiceBadgeColor($invoice_status);
$sql_payments = mysqli_query(
$mysqli,
"SELECT * FROM payments
"SELECT account_archived_at, account_name, payment_amount, payment_currency_code, payment_date,
payment_id, payment_method, payment_reference FROM payments
LEFT JOIN accounts ON payment_account_id = account_id
WHERE payment_invoice_id = $invoice_id
AND payment_archived_at IS NULL