diff --git a/CHANGELOG.md b/CHANGELOG.md index efa3c24a1..4a7d36129 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ This file documents all notable changes made to ITFlow. ### Upgrading -Update from Maintenance > Update — Queue Update hands the job to cron and it applies on its own. There is no database change in this release, so nothing else is required. From 26.11.3 or earlier, the same update also brings 26.11.4 and its database changes - see its notes below. +Update from Maintenance > Update — Queue Update hands the job to cron and it applies on its own. There is no database change in this release, so nothing else is required. If clients have signed contracts with you, read the first Contracts entry under Bug Fixes: a signed copy may give shorter response times than the ones your SLAs time tickets by. From 26.11.3 or earlier, the same update also brings 26.11.4 and its database changes - see its notes below. ### New Features & Updates @@ -36,6 +36,8 @@ Update from Maintenance > Update — Queue Update hands the job to cron and it a - Backups: the window for exporting the master key said the key "is not written anywhere". An encrypted copy is filed with the other backups; the window now says so, and that every agent is notified of the export. - SLAs: business hours saved with the day ending before it starts were accepted, and SLA clocks then ran around the clock without saying so - a 4-hour target given late on a Friday came due that evening. They are now refused, with how to set cover around the clock. A warning percent outside 1 to 99 is kept within it. - SLAs: the message after saving an SLA with an apostrophe in its name showed a backslash in it. +- Contracts: a contract's response times - on its page, in its window and in the document the client signs - were worded in plain time, where SLA clocks count only your business hours. With a 9 to 5 day, a 48-hour resolution target read "2 days" and a 24-hour one "24 hrs", where the clock gives 6 and 3 business days. They now read as the clock counts them - "4 business hours", "6 business days" - the same as Admin > SLAs and the emails to clients. A contract already signed, or out for signature, keeps the wording it was sent with and is not marked as changed. Open the signed copy of any contract whose targets run to a business day or more: if it promises more than you meant, set the SLA's targets to what you meant in Admin > SLAs, or send the contract to be signed again. +- Contracts: because the wording now follows your business hours, changing them changes what a target of a business day or more comes to. A contract signed from this release on is then marked as changed since it was signed, as it is when its SLA's targets are changed. ### Developer Updates @@ -66,7 +68,8 @@ Update from Maintenance > Update — Queue Update hands the job to cron and it a - `admin/modals/sla/`: `sla_add.php` and `sla_edit.php` share the new `sla_form.php`, which posts `response_hours` and `response_minutes`, `resolution_hours` and `resolution_minutes`; `holiday_generate.php` is new, in place of the year box in the card's header; `holiday_add.php` is tidied. `add_sla` and `edit_sla` (`admin/post/sla.php`) add hours to minutes, so a caller that sends only `response_minutes` and `resolution_minutes` as totals gets what it did before. - `admin/post/sla.php`: `add_sla` and `edit_sla` check the name and targets first; `edit_sla_settings` takes the hours as HH:MM, refuses a day that ends before it starts when any day is picked, and keeps `warning_percent` within 1 to 99; the messages count tickets properly and say which ("1 ticket not yet closed", "80 tickets not yet closed" - a save works out again every ticket still to close, resolved ones included, which can be more than the open tickets a row counts), use the name as typed, and `generate_holidays` says when every one was already in. What is saved, the restamping of open tickets and the audit log are unchanged. - Removing a closure day is a `button.confirm-link` in its form (`js/confirm_modal.js`) in place of an inline `onsubmit="return confirm()"`, and Archive carries its own `data-confirm-*` text. -- Found and left alone: `slaMinutesText()` (`functions/contract.php`), which words an SLA on contracts and in the contract form, calls 2880 minutes "2 days" where the clock and `formatSlaMinutes()` make it 6 business days of a 9 to 5 day. +- `slaMinutesText()` (`functions/contract.php`), which words a target for `contractSlaTargets()` and the contract document, is now `formatSlaMinutes($minutes, true)`. `formatSlaMinutes()` gains `$exact`, which drops no remainder ("1 business day 7 hours 30 minutes"): a contract and Admin > SLAs say a target in full, and the emails keep the rounder wording, as the deadline is next to it there. +- The old wording stays behind `$old_wording` on `slaMinutesText()`, passed along by `contractSlaTargets()`, `contractSlaTableHtml()`, `contractPlaceholderValues()`, `contractFillTerms()` and `contractDocumentHtml()`, and only `contractDocumentIs($row, $as_of, $hash)` asks for it. `contractSignatureCheckChanged()` and `contractSignatureOutdated()` compare a round's `contract_signature_document_hash` through it - the document in today's wording, then in the old - so a round sent up to 26.11.7 is not withdrawn or marked outdated by the rewording alone. A document's fingerprint now depends on the business days and hours wherever a target is a business day or more. - Hooks for tests and scripts: `data-sla-view` on each view's link, `data-sla-list` with `data-sla-id` on each row, `data-sla-default-for`, `data-sla-archive` and `data-sla-restore`; `data-sla-days` with `data-sla-day` (the date) on each row; `data-sla-new`, `data-sla-new-day` and `data-sla-us-holidays`; `data-sla-default` (the priority) on each default's select, `data-sla-closures`, `data-sla-alerts-stopped` and `data-sla-now`. ## [26.11.7] diff --git a/admin/modals/sla/sla_form.php b/admin/modals/sla/sla_form.php index e1513e8f4..2cf01ccad 100644 --- a/admin/modals/sla/sla_form.php +++ b/admin/modals/sla/sla_form.php @@ -70,7 +70,7 @@ $f_day_minutes = slaBusinessDayMinutes();
SLAs are optional. A new ticket gets the SLA its client's contract gives its priority, else the default for the priority. With neither, it has none and nothing about it changes.
-Targets are business time. = $day_minutes > 0 ? 'Four hours given an hour before the day ends runs out three hours into the next business day - and 24 hours is ' . escapeHtml(formatSlaMinutes(1440)) . '.' : 'With no business days picked the clocks run around the clock, so a target is plain time.' ?>
+Targets are business time. = $day_minutes > 0 ? 'Four hours given an hour before the day ends runs out three hours into the next business day - and 24 hours is ' . escapeHtml(formatSlaMinutes(1440, true)) . '.' : 'With no business days picked the clocks run around the clock, so a target is plain time.' ?>
Two clocks. Response runs until the first reply. Resolution runs until the ticket is resolved, and stops while it is in a status that pauses it, like On Hold - set in Ticket Statuses.
How you're doing. The SLA Summary and SLA by Client reports show how often targets were met.
| Priority | Respond within | Resolve within | ||||
|---|---|---|---|---|---|---|
| ' . escapeHtml($priority) . ' | '; if ($sla) { - $html .= '' . escapeHtml(slaMinutesText($sla['sla_response_minutes'])) . ' | ' - . '' . (intval($sla['sla_resolution_minutes']) > 0 ? escapeHtml(slaMinutesText($sla['sla_resolution_minutes'])) : 'No set time') . ' | '; + $html .= '' . escapeHtml(slaMinutesText($sla['sla_response_minutes'], $old_wording)) . ' | ' + . '' . (intval($sla['sla_resolution_minutes']) > 0 ? escapeHtml(slaMinutesText($sla['sla_resolution_minutes'], $old_wording)) : 'No set time') . ' | '; } else { $html .= 'No set time | No set time | '; } @@ -135,8 +135,8 @@ function contractSlaTableHtml(array $row, $date = null) { return $html . '