From c094f97eeddf2de622e3db69093400e2f31c6990 Mon Sep 17 00:00:00 2001 From: johnnyq Date: Sat, 21 Nov 2026 02:29:20 -0500 Subject: [PATCH] QoL 63: counts in menus, tabs, list headers and the list footer have a thousands separator, as the dashboard, reports and audit log already did --- CHANGELOG.md | 1 + admin/categories.php | 4 +-- admin/includes/side_nav.php | 6 ++-- admin/rmm_clients.php | 2 +- admin/settings_client_portal.php | 2 +- admin/settings_mail.php | 6 ++-- admin/sign_ins.php | 2 +- admin/sla.php | 2 +- admin/users.php | 2 +- agent/asset.php | 2 +- agent/assets.php | 4 +-- agent/contact.php | 2 +- agent/contacts.php | 6 ++-- agent/files.php | 6 ++-- agent/global_search.php | 2 +- agent/includes/client_overview_side_nav.php | 22 ++++++------- agent/includes/client_side_nav.php | 32 +++++++++---------- agent/includes/side_nav.php | 16 +++++----- agent/invoice.php | 12 +++---- agent/kb.php | 2 +- agent/kb_article.php | 2 +- agent/license.php | 2 +- agent/location.php | 2 +- agent/modals/asset/asset.php | 2 +- agent/modals/billing/billing_item.php | 4 +-- agent/modals/contact/contact.php | 2 +- agent/modals/location/location.php | 2 +- agent/modals/software/software.php | 4 +-- agent/modals/vendor/vendor.php | 2 +- .../modals/vendor/vendor_template_update.php | 2 +- agent/network.php | 2 +- agent/networks.php | 4 +-- agent/product.php | 2 +- agent/project.php | 2 +- agent/recurring_invoice.php | 2 +- agent/software.php | 4 +-- agent/ticket.php | 2 +- agent/transactions.php | 2 +- agent/vendor.php | 2 +- client/activity.php | 2 +- client/assets.php | 2 +- client/contracts.php | 2 +- client/documents.php | 4 +-- client/domains.php | 4 +-- client/invoices.php | 2 +- client/kb.php | 4 +-- client/licenses.php | 2 +- client/quotes.php | 2 +- client/search.php | 2 +- client/tickets.php | 2 +- includes/filter_footer.php | 2 +- 51 files changed, 105 insertions(+), 104 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8c9d44e5d..097708f74 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -230,6 +230,7 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u - Client portal and emailed links: what a client sees after accepting or declining a quote, approving a task or sending a file reads the same from an emailed link as in the portal - Thank you - quote QUO-79 is accepted and our team has been told, rather than Quote Accepted. Card payment problems are in plain words - Card payments are not set up, rather than Stripe credentials missing. A link that isn't right, online payment that isn't available, or a payment that can't be confirmed shows the same page as a mistyped invoice link, rather than an Oops line on an empty page. - Wording: a ticket task's approval picker says agent rather than technician, with the same blank choice as other pickers - - Select one - and - Select an agent - rather than Select... and - Select a user -. Pickers that fill in as you go read like the rest: changing a ticket's client offers - Select a contact - (or - No contacts -), a project with no client offers - Nobody -, and an asset detail or statement line with nothing picked shows - None - or - Not for a client - rather than a bare dash. The Tickets list's Billing filter starts at - Any -, record pages say Upload Files rather than Upload File(s), and Maintenance > Cron's log counts 1 problem rather than 1 problem(s). - Screen readers: every window's close button is read out as Close, and the arrow beside a list's New button and the ⋮ menus on record pages as More actions, rather than as a button with no name or just More. +- Counts: the counts in menus, tabs, list headers and under every list - Showing 1 to 25 of 1,834 records - have a thousands separator, as the dashboard, reports and audit log already did. ### Bug Fixes diff --git a/admin/categories.php b/admin/categories.php index fe28b3f1e..e50959df5 100644 --- a/admin/categories.php +++ b/admin/categories.php @@ -162,8 +162,8 @@ $csrf = $_SESSION['csrf_token']; diff --git a/admin/includes/side_nav.php b/admin/includes/side_nav.php index 6a8072bec..321e131d0 100644 --- a/admin/includes/side_nav.php +++ b/admin/includes/side_nav.php @@ -20,7 +20,7 @@

Get Started - / + /

@@ -158,7 +158,7 @@ Managed Instances - +

@@ -188,7 +188,7 @@ Mail Queue - +

diff --git a/admin/rmm_clients.php b/admin/rmm_clients.php index 9135aa66f..c82d33626 100644 --- a/admin/rmm_clients.php +++ b/admin/rmm_clients.php @@ -162,7 +162,7 @@ $devices_in = intval(mysqli_fetch_row(mysqli_query($mysqli, "SELECT COUNT(*) FRO continue; } ?> - + diff --git a/admin/settings_client_portal.php b/admin/settings_client_portal.php index 24cb088ae..33272aaa5 100644 --- a/admin/settings_client_portal.php +++ b/admin/settings_client_portal.php @@ -83,7 +83,7 @@ $signup_clients = $signup_ready ? portalSignupClients() : []; Shown at the top of the portal's home page - to every client, or one - between their start and end. For a banner your agents see instead, use Agent Banners.
Current - Archived + Archived
diff --git a/admin/settings_mail.php b/admin/settings_mail.php index ed97c8921..931f7059f 100644 --- a/admin/settings_mail.php +++ b/admin/settings_mail.php @@ -358,9 +358,9 @@ if (!$config_module_enable_ticketing) { Mail Queue - - waiting - retrying - failed in the last day + waiting + retrying + failed in the last day Open the Mail Queue
diff --git a/admin/sign_ins.php b/admin/sign_ins.php index 8e0ec7d58..f839d2a11 100644 --- a/admin/sign_ins.php +++ b/admin/sign_ins.php @@ -302,7 +302,7 @@ $audit_url = function (array $query) use ($dates_query) { -
new
+
new
diff --git a/admin/sla.php b/admin/sla.php index 808d51641..1ab99d1b4 100644 --- a/admin/sla.php +++ b/admin/sla.php @@ -282,7 +282,7 @@ $pill_url = function ($view) use ($on_days) { $view) { if ($view_key === 'days') { ?> - + diff --git a/admin/users.php b/admin/users.php index 5e2e45766..ae750b9a2 100644 --- a/admin/users.php +++ b/admin/users.php @@ -380,7 +380,7 @@ $csrf = $_SESSION['csrf_token']; // The search and role narrow agents, and the search, client and sign-in narrow portal users - none follow to the other side $view_filters = ($key === 'portal') === ($show === 'portal') ? [] : ['q' => null, 'role' => null, 'client' => null, 'access' => null, 'sort' => null, 'order' => null]; ?> - + diff --git a/agent/asset.php b/agent/asset.php index 58347e4f0..5f2586c63 100644 --- a/agent/asset.php +++ b/agent/asset.php @@ -653,7 +653,7 @@ if (mysqli_num_rows($sql) == 0) { diff --git a/agent/global_search.php b/agent/global_search.php index 1a5b175bb..f934392b6 100644 --- a/agent/global_search.php +++ b/agent/global_search.php @@ -149,7 +149,7 @@ function searchResultBadge($badge) {

- +

diff --git a/agent/includes/client_overview_side_nav.php b/agent/includes/client_overview_side_nav.php index 79f671f19..0614354a1 100644 --- a/agent/includes/client_overview_side_nav.php +++ b/agent/includes/client_overview_side_nav.php @@ -62,7 +62,7 @@ $num_vendors = $row['num']; Contacts 0) { ?> - +

@@ -74,7 +74,7 @@ $num_vendors = $row['num']; Locations 0) { ?> - +

@@ -90,7 +90,7 @@ $num_vendors = $row['num']; Assets 0) { ?> - +

@@ -103,7 +103,7 @@ $num_vendors = $row['num']; Networks 0) { ?> - +

@@ -116,7 +116,7 @@ $num_vendors = $row['num']; Racks 0) { ?> - +

@@ -132,7 +132,7 @@ $num_vendors = $row['num']; Credentials 0) { ?> - +

@@ -146,7 +146,7 @@ $num_vendors = $row['num']; Certificates 0) { ?> - +

@@ -158,7 +158,7 @@ $num_vendors = $row['num']; Domains 0) { ?> - +

@@ -182,7 +182,7 @@ $num_vendors = $row['num']; Licenses 0) { ?> - +

@@ -196,7 +196,7 @@ $num_vendors = $row['num']; Vendors 0) { ?> - +

@@ -210,7 +210,7 @@ $num_vendors = $row['num']; Services 0) { ?> - +

diff --git a/agent/includes/client_side_nav.php b/agent/includes/client_side_nav.php index 11099add8..45270fbd4 100644 --- a/agent/includes/client_side_nav.php +++ b/agent/includes/client_side_nav.php @@ -105,7 +105,7 @@ Contacts 0) { ?> - +

@@ -118,7 +118,7 @@ Locations 0) { ?> - +

@@ -131,7 +131,7 @@ Vendors 0) { ?> - +

@@ -145,7 +145,7 @@ Calendar 0) { ?> - +

@@ -183,7 +183,7 @@ Recurring Tickets - +

@@ -196,7 +196,7 @@

Projects - +

@@ -216,7 +216,7 @@ Assets 0) { ?> - +

@@ -229,7 +229,7 @@ Networks 0) { ?> - +

@@ -242,7 +242,7 @@ Racks 0) { ?> - +

@@ -258,7 +258,7 @@ Credentials 0) { ?> - +

@@ -325,7 +325,7 @@ Services 0) { ?> - +

@@ -341,7 +341,7 @@ Files 0) { ?> - +

@@ -362,7 +362,7 @@ Quotes 0) { ?> - +

@@ -402,7 +402,7 @@ Recurring Invoices - +

@@ -430,7 +430,7 @@ Income 0) { ?> - +

@@ -445,7 +445,7 @@ Trips 0) { ?> - +

diff --git a/agent/includes/side_nav.php b/agent/includes/side_nav.php index 46eef1c04..1952a0907 100644 --- a/agent/includes/side_nav.php +++ b/agent/includes/side_nav.php @@ -59,7 +59,7 @@

Clients - +

@@ -104,7 +104,7 @@

Tickets - +

@@ -125,7 +125,7 @@ Texts - +

@@ -137,7 +137,7 @@

Recurring Tickets - +

@@ -148,7 +148,7 @@

Projects - +

@@ -166,7 +166,7 @@

Quotes - +

@@ -177,7 +177,7 @@

Invoices - +

@@ -209,7 +209,7 @@

Recurring Invoices - +

diff --git a/agent/invoice.php b/agent/invoice.php index b607ee6df..c1a1cf8d5 100644 --- a/agent/invoice.php +++ b/agent/invoice.php @@ -414,10 +414,10 @@ echo agentBannersHtml($client_id);
-

Hardware

+

Hardware

@@ -434,7 +434,7 @@ echo agentBannersHtml($client_id); = $line['units']) { ?> On assets - of + of
@@ -471,7 +471,7 @@ echo agentBannersHtml($client_id);

Tickets

@@ -507,7 +507,7 @@ echo agentBannersHtml($client_id);

Expenses

@@ -554,7 +554,7 @@ echo agentBannersHtml($client_id);

Travel

diff --git a/agent/kb.php b/agent/kb.php index 49508cbee..8bf2a5340 100644 --- a/agent/kb.php +++ b/agent/kb.php @@ -127,7 +127,7 @@ $csrf = $_SESSION['csrf_token'];
diff --git a/agent/kb_article.php b/agent/kb_article.php index 716773389..4c80740de 100644 --- a/agent/kb_article.php +++ b/agent/kb_article.php @@ -324,7 +324,7 @@ $page_title = $row['kb_article_title'];

Feedback - +

1) { ?>
diff --git a/agent/license.php b/agent/license.php index 8c7bf6875..59ec153c2 100644 --- a/agent/license.php +++ b/agent/license.php @@ -325,7 +325,7 @@ if (!$license || ($client_url && intval($license['software_client_id']) !== intv diff --git a/agent/location.php b/agent/location.php index 596e50248..f6d591efa 100644 --- a/agent/location.php +++ b/agent/location.php @@ -373,7 +373,7 @@ if (!$location || ($client_url && intval($location['location_client_id']) !== in diff --git a/agent/modals/billing/billing_item.php b/agent/modals/billing/billing_item.php index 3a75c87ae..62a791642 100644 --- a/agent/modals/billing/billing_item.php +++ b/agent/modals/billing/billing_item.php @@ -153,7 +153,7 @@ ob_start(); $type_id = 'seatType' . substr(md5($asset_type), 0, 8); ?> > - + The client has no devices yet. @@ -178,7 +178,7 @@ ob_start(); $type_id = 'seatManagedType' . substr(md5($asset_type), 0, 8); ?> > - + None of the client's devices are in your RMM yet - link the client on its RMM provider's Clients page. diff --git a/agent/modals/contact/contact.php b/agent/modals/contact/contact.php index 7aa8fb6b7..e208e8119 100644 --- a/agent/modals/contact/contact.php +++ b/agent/modals/contact/contact.php @@ -235,7 +235,7 @@ ob_start(); $tab) { ?> diff --git a/agent/modals/location/location.php b/agent/modals/location/location.php index 2a05c03a2..c2e8eacca 100644 --- a/agent/modals/location/location.php +++ b/agent/modals/location/location.php @@ -144,7 +144,7 @@ ob_start(); $tab) { ?> diff --git a/agent/modals/software/software.php b/agent/modals/software/software.php index 9caf676d5..2ba2dce46 100644 --- a/agent/modals/software/software.php +++ b/agent/modals/software/software.php @@ -76,7 +76,7 @@ ob_start(); Archived - over seats + over seats
@@ -167,7 +167,7 @@ ob_start(); $tab) { ?> diff --git a/agent/modals/vendor/vendor.php b/agent/modals/vendor/vendor.php index 8c0e44742..c2a6299fc 100644 --- a/agent/modals/vendor/vendor.php +++ b/agent/modals/vendor/vendor.php @@ -199,7 +199,7 @@ ob_start(); $tab) { ?> diff --git a/agent/modals/vendor/vendor_template_update.php b/agent/modals/vendor/vendor_template_update.php index ab62301dc..4f07ae1b7 100644 --- a/agent/modals/vendor/vendor_template_update.php +++ b/agent/modals/vendor/vendor_template_update.php @@ -93,7 +93,7 @@ ob_start(); - differ + differ
diff --git a/agent/network.php b/agent/network.php index 1d55ed2b5..500210ed5 100644 --- a/agent/network.php +++ b/agent/network.php @@ -321,7 +321,7 @@ if (!$network || ($client_url && intval($network['network_client_id']) !== intva diff --git a/agent/networks.php b/agent/networks.php index 03f0df086..6d049b801 100644 --- a/agent/networks.php +++ b/agent/networks.php @@ -272,7 +272,7 @@ $csrf = $_SESSION['csrf_token']; diff --git a/agent/product.php b/agent/product.php index bdb3dc9a2..b26d135d7 100644 --- a/agent/product.php +++ b/agent/product.php @@ -405,7 +405,7 @@ if (!$product) { diff --git a/agent/project.php b/agent/project.php index 5cee738fa..5fc197df1 100644 --- a/agent/project.php +++ b/agent/project.php @@ -353,7 +353,7 @@ echo agentBannersHtml($project_client_id);
diff --git a/client/invoices.php b/client/invoices.php index 3b6010e84..655e5d888 100644 --- a/client/invoices.php +++ b/client/invoices.php @@ -101,7 +101,7 @@ function invoicesUrl(array $changes) { $t) { ?> - + diff --git a/client/kb.php b/client/kb.php index d0bf428ca..96cb27be6 100644 --- a/client/kb.php +++ b/client/kb.php @@ -86,9 +86,9 @@ function kbPortalUrl(array $changes) { 1) { ?> diff --git a/client/licenses.php b/client/licenses.php index 0ea17b2a5..98ca3fc44 100644 --- a/client/licenses.php +++ b/client/licenses.php @@ -68,7 +68,7 @@ function licensesUrl(array $changes) { $t) { ?> - + diff --git a/client/quotes.php b/client/quotes.php index aea7d2ed4..3c41b1624 100644 --- a/client/quotes.php +++ b/client/quotes.php @@ -72,7 +72,7 @@ function quotesUrl(array $changes) { $t) { ?> - + diff --git a/client/search.php b/client/search.php index ea25b9c6f..dd04b84a7 100644 --- a/client/search.php +++ b/client/search.php @@ -111,7 +111,7 @@ $found = array_sum(array_column($sections, 'total')); } ?>
-

+

count($section['rows'])) { ?> See all diff --git a/client/tickets.php b/client/tickets.php index 1af6a2319..67c2cfb2a 100644 --- a/client/tickets.php +++ b/client/tickets.php @@ -96,7 +96,7 @@ $empty_titles = [ $t) { ?> - + diff --git a/includes/filter_footer.php b/includes/filter_footer.php index d83dfc918..6c3149c61 100644 --- a/includes/filter_footer.php +++ b/includes/filter_footer.php @@ -62,7 +62,7 @@ if ($total_found_rows > 5) {

- Showing to of records + Showing to of records