From c094f97eeddf2de622e3db69093400e2f31c6990 Mon Sep 17 00:00:00 2001
From: johnnyq
Date: Sat, 21 Nov 2026 02:29:20 -0500
Subject: [PATCH] QoL 63: counts in menus, tabs, list headers and the list
footer have a thousands separator, as the dashboard, reports and audit log
already did
---
CHANGELOG.md | 1 +
admin/categories.php | 4 +--
admin/includes/side_nav.php | 6 ++--
admin/rmm_clients.php | 2 +-
admin/settings_client_portal.php | 2 +-
admin/settings_mail.php | 6 ++--
admin/sign_ins.php | 2 +-
admin/sla.php | 2 +-
admin/users.php | 2 +-
agent/asset.php | 2 +-
agent/assets.php | 4 +--
agent/contact.php | 2 +-
agent/contacts.php | 6 ++--
agent/files.php | 6 ++--
agent/global_search.php | 2 +-
agent/includes/client_overview_side_nav.php | 22 ++++++-------
agent/includes/client_side_nav.php | 32 +++++++++----------
agent/includes/side_nav.php | 16 +++++-----
agent/invoice.php | 12 +++----
agent/kb.php | 2 +-
agent/kb_article.php | 2 +-
agent/license.php | 2 +-
agent/location.php | 2 +-
agent/modals/asset/asset.php | 2 +-
agent/modals/billing/billing_item.php | 4 +--
agent/modals/contact/contact.php | 2 +-
agent/modals/location/location.php | 2 +-
agent/modals/software/software.php | 4 +--
agent/modals/vendor/vendor.php | 2 +-
.../modals/vendor/vendor_template_update.php | 2 +-
agent/network.php | 2 +-
agent/networks.php | 4 +--
agent/product.php | 2 +-
agent/project.php | 2 +-
agent/recurring_invoice.php | 2 +-
agent/software.php | 4 +--
agent/ticket.php | 2 +-
agent/transactions.php | 2 +-
agent/vendor.php | 2 +-
client/activity.php | 2 +-
client/assets.php | 2 +-
client/contracts.php | 2 +-
client/documents.php | 4 +--
client/domains.php | 4 +--
client/invoices.php | 2 +-
client/kb.php | 4 +--
client/licenses.php | 2 +-
client/quotes.php | 2 +-
client/search.php | 2 +-
client/tickets.php | 2 +-
includes/filter_footer.php | 2 +-
51 files changed, 105 insertions(+), 104 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8c9d44e5d..097708f74 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -230,6 +230,7 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u
- Client portal and emailed links: what a client sees after accepting or declining a quote, approving a task or sending a file reads the same from an emailed link as in the portal - Thank you - quote QUO-79 is accepted and our team has been told, rather than Quote Accepted. Card payment problems are in plain words - Card payments are not set up, rather than Stripe credentials missing. A link that isn't right, online payment that isn't available, or a payment that can't be confirmed shows the same page as a mistyped invoice link, rather than an Oops line on an empty page.
- Wording: a ticket task's approval picker says agent rather than technician, with the same blank choice as other pickers - - Select one - and - Select an agent - rather than Select... and - Select a user -. Pickers that fill in as you go read like the rest: changing a ticket's client offers - Select a contact - (or - No contacts -), a project with no client offers - Nobody -, and an asset detail or statement line with nothing picked shows - None - or - Not for a client - rather than a bare dash. The Tickets list's Billing filter starts at - Any -, record pages say Upload Files rather than Upload File(s), and Maintenance > Cron's log counts 1 problem rather than 1 problem(s).
- Screen readers: every window's close button is read out as Close, and the arrow beside a list's New button and the ⋮ menus on record pages as More actions, rather than as a button with no name or just More.
+- Counts: the counts in menus, tabs, list headers and under every list - Showing 1 to 25 of 1,834 records - have a thousands separator, as the dashboard, reports and audit log already did.
### Bug Fixes
diff --git a/admin/categories.php b/admin/categories.php
index fe28b3f1e..e50959df5 100644
--- a/admin/categories.php
+++ b/admin/categories.php
@@ -162,8 +162,8 @@ $csrf = $_SESSION['csrf_token'];
diff --git a/admin/includes/side_nav.php b/admin/includes/side_nav.php
index 6a8072bec..321e131d0 100644
--- a/admin/includes/side_nav.php
+++ b/admin/includes/side_nav.php
@@ -20,7 +20,7 @@
Get Started
- = $nav_getting_started['done'] ?>/= $nav_getting_started['total'] ?>
+ = number_format(intval($nav_getting_started['done'])) ?>/= $nav_getting_started['total'] ?>
@@ -188,7 +188,7 @@
Mail Queue
- = $nav_mail_failed ?>
+ = number_format(intval($nav_mail_failed)) ?>
diff --git a/admin/rmm_clients.php b/admin/rmm_clients.php
index 9135aa66f..c82d33626 100644
--- a/admin/rmm_clients.php
+++ b/admin/rmm_clients.php
@@ -162,7 +162,7 @@ $devices_in = intval(mysqli_fetch_row(mysqli_query($mysqli, "SELECT COUNT(*) FRO
continue;
} ?>
- = escapeHtml($view['label']) ?> = $view_counts[$key] ?>
+ = escapeHtml($view['label']) ?> = number_format(intval($view_counts[$key])) ?>
diff --git a/admin/settings_client_portal.php b/admin/settings_client_portal.php
index 24cb088ae..33272aaa5 100644
--- a/admin/settings_client_portal.php
+++ b/admin/settings_client_portal.php
@@ -83,7 +83,7 @@ $signup_clients = $signup_ready ? portalSignupClients() : [];
Shown at the top of the portal's home page - to every client, or one - between their start and end. For a banner your agents see instead, use Agent Banners.