QoL 45: intval and floatval in place of int and float casts and a string cast in place of strval, redirect in place of raw Location headers wherever functions.php is loaded, redirect fallback escapes the URL with json_encode and escapeHtml, escapeHtml for the last htmlspecialchars on a page, and the plain-HTTP cookie notice through flashAlert

This commit is contained in:
johnnyq
2026-11-21 00:20:16 -05:00
parent 5cb09cee0b
commit eb79252ca0
78 changed files with 169 additions and 193 deletions

View File

@@ -43,7 +43,7 @@ $managed_kept = $managed_mode === 'active' ? [] : (MANAGED_KEEP_JOBS[$managed_mo
$install_root = dirname(__DIR__);
$file_owner = '';
if (function_exists('posix_getpwuid')) {
$file_owner = (string) (posix_getpwuid((int) @fileowner($install_root . '/cron/cron.php'))['name'] ?? '');
$file_owner = (string) (posix_getpwuid(intval(@fileowner($install_root . '/cron/cron.php')))['name'] ?? '');
}
$shell_word = function ($word) {
return preg_match('/^[A-Za-z0-9_\/.@%+=:,-]+$/', $word) ? $word : escapeshellarg($word);
@@ -194,9 +194,9 @@ $took = function ($seconds) {
if ($seconds < 60) {
return round($seconds) . ' s';
}
$minutes = intdiv((int) round($seconds), 60);
$minutes = intdiv(intval(round($seconds)), 60);
if ($minutes < 60) {
return $minutes . ' min ' . ((int) round($seconds) % 60) . ' s';
return $minutes . ' min ' . (intval(round($seconds)) % 60) . ' s';
}
return intdiv($minutes, 60) . ' h ' . ($minutes % 60) . ' min';
};