From f0b4e3419b538f9bfba2439b6c966678ab6ac6da Mon Sep 17 00:00:00 2001 From: johnnyq Date: Sat, 21 Nov 2026 02:18:41 -0500 Subject: [PATCH] QoL 61: the task approval picker says agent with the usual blank choices, pickers filled in by script use the same blank choices as when rendered, asset details and statement lines show None or Not for a client instead of a dash, the ticket Billing filter starts at Any, record pages say Upload Files and cron counts problems without (s) --- CHANGELOG.md | 1 + agent/asset.php | 2 +- agent/contact.php | 2 +- agent/expense_import.php | 4 ++-- agent/js/project_modal.js | 2 +- agent/js/ticket_change_client.js | 6 +++--- agent/license.php | 2 +- agent/location.php | 2 +- agent/modals/asset/asset_form.php | 2 +- agent/modals/ticket/ticket_task_approver_add.php | 12 ++++++------ agent/modals/ticket/ticket_task_edit.php | 4 ++-- agent/tickets.php | 2 +- agent/vendor.php | 2 +- functions/cron_health.php | 12 +++++++++--- 14 files changed, 31 insertions(+), 24 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 049425611..d9ebd9600 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -228,6 +228,7 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u - Forms: hints inside empty fields are plain examples - example.com, Contracts, Closing remarks - rather than e.g. ..., ex. ... and Enter a ..., and address fields bring up the web keyboard on a phone. New Location and New Network open at the size their Edit windows do, and the transactions list's amount filters take 1,000.00 like every other money field. - Messages: the message after a window closes matches its button - created after Create, saved after Save - where some said added, updated or edited. Copying an invoice says which invoice it was copied to, making one recurring names the new recurring invoice, a payment on several invoices says how many it paid and who the receipt was queued to, and attaching files to a ticket without a reply says so rather than Ticket updated. - Client portal and emailed links: what a client sees after accepting or declining a quote, approving a task or sending a file reads the same from an emailed link as in the portal - Thank you - quote QUO-79 is accepted and our team has been told, rather than Quote Accepted. Card payment problems are in plain words - Card payments are not set up, rather than Stripe credentials missing. A link that isn't right, online payment that isn't available, or a payment that can't be confirmed shows the same page as a mistyped invoice link, rather than an Oops line on an empty page. +- Wording: a ticket task's approval picker says agent rather than technician, with the same blank choice as other pickers - - Select one - and - Select an agent - rather than Select... and - Select a user -. Pickers that fill in as you go read like the rest: changing a ticket's client offers - Select a contact - (or - No contacts -), a project with no client offers - Nobody -, and an asset detail or statement line with nothing picked shows - None - or - Not for a client - rather than a bare dash. The Tickets list's Billing filter starts at - Any -, record pages say Upload Files rather than Upload File(s), and Maintenance > Cron's log counts 1 problem rather than 1 problem(s). ### Bug Fixes diff --git a/agent/asset.php b/agent/asset.php index 63b51bfa7..9b6860f5e 100644 --- a/agent/asset.php +++ b/agent/asset.php @@ -352,7 +352,7 @@ if (mysqli_num_rows($sql) == 0) { Document - Upload File(s) + Upload Files Note diff --git a/agent/contact.php b/agent/contact.php index 4b4d0bbf8..b042b5a2b 100644 --- a/agent/contact.php +++ b/agent/contact.php @@ -279,7 +279,7 @@ if (!$can_support) { Document - Upload File(s) + Upload Files License diff --git a/agent/expense_import.php b/agent/expense_import.php index 05dfe0fe5..85a90d981 100644 --- a/agent/expense_import.php +++ b/agent/expense_import.php @@ -252,7 +252,7 @@ $steps = ['upload' => 'Statement', 'columns' => 'Columns', 'review' => 'Review'] @@ -331,7 +331,7 @@ $steps = ['upload' => 'Statement', 'columns' => 'Columns', 'review' => 'Review']
diff --git a/agent/js/project_modal.js b/agent/js/project_modal.js index a5ab3502b..3140bf3b3 100644 --- a/agent/js/project_modal.js +++ b/agent/js/project_modal.js @@ -22,7 +22,7 @@ return; } contactSelect.innerHTML = ''; - contactSelect.add(new Option('Nobody', '0')); + contactSelect.add(new Option('- Nobody -', '0')); const internal = !clientId || clientId === '0'; if (contactField) { contactField.hidden = internal; diff --git a/agent/js/ticket_change_client.js b/agent/js/ticket_change_client.js index 7bab07777..e9338e700 100644 --- a/agent/js/ticket_change_client.js +++ b/agent/js/ticket_change_client.js @@ -31,7 +31,7 @@ itflowReady(function () { .then(function (response) { contactSelect.innerHTML = ''; if (response.contacts && response.contacts.length > 0) { - contactSelect.appendChild(new Option('Select a contact', '')); + contactSelect.appendChild(new Option('- Select a contact -', '')); response.contacts.forEach(function (contact) { // new Option() sets text content, so contact names are // never parsed as markup. The picker draws their avatar @@ -50,12 +50,12 @@ itflowReady(function () { contactSelect.appendChild(option); }); } else { - contactSelect.appendChild(new Option('No contacts found', '')); + contactSelect.appendChild(new Option('- No contacts -', '')); } }) .catch(function (error) { console.error('AJAX Error:', error); - contactSelect.innerHTML = ''; + contactSelect.innerHTML = ''; }); } diff --git a/agent/license.php b/agent/license.php index 351441dae..8c7bf6875 100644 --- a/agent/license.php +++ b/agent/license.php @@ -161,7 +161,7 @@ if (!$license || ($client_url && intval($license['software_client_id']) !== intv Document - Upload File(s) + Upload Files
diff --git a/agent/location.php b/agent/location.php index 13769a16c..596e50248 100644 --- a/agent/location.php +++ b/agent/location.php @@ -216,7 +216,7 @@ if (!$location || ($client_url && intval($location['location_client_id']) !== in Document - Upload File(s) + Upload Files diff --git a/agent/modals/asset/asset_form.php b/agent/modals/asset/asset_form.php index d7cf6fbdd..cd06f6355 100644 --- a/agent/modals/asset/asset_form.php +++ b/agent/modals/asset/asset_form.php @@ -262,7 +262,7 @@ $asset_form_icons = [ - + @@ -119,15 +119,15 @@ ob_start(); if (scope === 'internal') { setOptions(typeSelect, [ - ['', 'Select...'], - ['any', 'Any other technician'], - ['specific', 'A specific technician'] + ['', '- Select one -'], + ['any', 'Any other agent'], + ['specific', 'A specific agent'] ]); } if (scope === 'client') { setOptions(typeSelect, [ - ['', 'Select...'], + ['', '- Select one -'], ['any', 'Ticket contact'], ['technical', 'Technical contacts'], ['billing', 'Billing contacts'] diff --git a/agent/modals/ticket/ticket_task_edit.php b/agent/modals/ticket/ticket_task_edit.php index d7e4def21..dd88c5ec9 100644 --- a/agent/modals/ticket/ticket_task_edit.php +++ b/agent/modals/ticket/ticket_task_edit.php @@ -88,9 +88,9 @@ ob_start(); // In words - the raw scope/type pair ("Internal", "Any") meant nothing on screen if ($approval_scope == 'internal' && $approval_type == 'specific') { - $approval_who = $approval_user_name ?: 'A specific technician'; + $approval_who = $approval_user_name ?: 'A specific agent'; } elseif ($approval_scope == 'internal') { - $approval_who = 'Any other technician'; + $approval_who = 'Any other agent'; } elseif ($approval_type == 'technical') { $approval_who = "The client's technical contacts"; } elseif ($approval_type == 'billing') { diff --git a/agent/tickets.php b/agent/tickets.php index 3803c6a11..e68ec727c 100644 --- a/agent/tickets.php +++ b/agent/tickets.php @@ -493,7 +493,7 @@ $export_extra = [