diff --git a/CHANGELOG.md b/CHANGELOG.md index 7d060a02a..b24509f75 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -225,6 +225,7 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u - Lists: the first click on a column you aren't sorting by sorts names A-Z and dates, money and counts newest or largest first, and a second click flips it. It used to go the opposite way to the column you were on, so the first click could go either way. - Badges and blanks: every badge is a rounded pill, the menu counts included, and an empty value shows as a grey dash everywhere. A request that can't be done - credit over the balance, say - shows in red like every other error, and the client portal's search boxes read Search ... like the agent pages'. - Sizes and lengths of time: a file or backup size reads 512 B or 1.5 MB everywhere - some pages said 1.53 MB, a portal attachment never less than 1 KB, and setup bytes. Booking lengths, the dispatch board and how long a cron job ran are written 1h 30m like time logged everywhere else - they read 1 hour 30 min and 2 min 5 s - and hours as a number are 12.5 h, project hours included. +- Forms: hints inside empty fields are plain examples - example.com, Contracts, Closing remarks - rather than e.g. ..., ex. ... and Enter a ..., and address fields bring up the web keyboard on a phone. New Location and New Network open at the size their Edit windows do, and the transactions list's amount filters take 1,000.00 like every other money field. ### Bug Fixes @@ -456,6 +457,7 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u - Messages: `flashAlert()` and `itflowToast()` are called with 'success', 'info', 'warning' and 'error' only - the 'danger' and 'alert' callers now say 'error' (both are still understood), and the unused 'errpr' alias is gone. Column headings are sentence case like field labels. - Menus: 30 menu items carried `text-dark`, which no other menu item has; it's gone. - Sizes: `formatBytes()` (one decimal, whole bytes, a unit at 1024) is the one formatter - `backupFormatBytes()` calls it, and the portal and setup scripts write sizes the same way. +- New-tab links: every `target="_blank"` link has `rel="noopener"`, and `noopener noreferrer` when it leaves ITFlow. ## [26.11.8] diff --git a/admin/modals/custom_link/custom_link_form.php b/admin/modals/custom_link/custom_link_form.php index bde4e3931..0f1ded6d7 100644 --- a/admin/modals/custom_link/custom_link_form.php +++ b/admin/modals/custom_link/custom_link_form.php @@ -49,7 +49,7 @@ $l_description = (string) ($l['custom_link_description'] ?? '');
- +
diff --git a/admin/modals/managed_instance/managed_instance_form.php b/admin/modals/managed_instance/managed_instance_form.php index b00146d61..1b8b51829 100644 --- a/admin/modals/managed_instance/managed_instance_form.php +++ b/admin/modals/managed_instance/managed_instance_form.php @@ -91,7 +91,7 @@ if (!managerEnabled()) { ?>
- > + >
What it's called here - its own company name shows from its reports.
@@ -101,7 +101,7 @@ if (!managerEnabled()) { ?>
- +
Where it's reached, without https:// - it goes in the command that sets up a new install for it. Once it connects, it's the address it says it has.
@@ -199,7 +199,7 @@ if (!managerEnabled()) { ?>
- +
What its people see while it's read-only or suspended, with your company's email and phone. Left empty, a plain notice.
diff --git a/admin/modals/payment_method/payment_method_delete.php b/admin/modals/payment_method/payment_method_delete.php index 47ff38116..9c46b9d85 100644 --- a/admin/modals/payment_method/payment_method_delete.php +++ b/admin/modals/payment_method/payment_method_delete.php @@ -37,7 +37,7 @@ if (!$payment_method) { ?>
Used on . - See them + See them
diff --git a/admin/modals/ticket_status/ticket_status_remove.php b/admin/modals/ticket_status/ticket_status_remove.php index 44eb2eca9..8cfa13967 100644 --- a/admin/modals/ticket_status/ticket_status_remove.php +++ b/admin/modals/ticket_status/ticket_status_remove.php @@ -50,7 +50,7 @@ if (!$ticket_status || ticketStatusIsBuiltIn($ticket_status['ticket_status_id'])
in it. - See them + See them
diff --git a/admin/modals/user/user_form.php b/admin/modals/user/user_form.php index dfca126db..8ba1a7c78 100644 --- a/admin/modals/user/user_form.php +++ b/admin/modals/user/user_form.php @@ -107,7 +107,7 @@ $value = function ($key) use ($form) {
>
-
What they can see and change. Roles
+
What they can see and change. Roles
diff --git a/admin/modals/vendor_template/vendor_template_form.php b/admin/modals/vendor_template/vendor_template_form.php index ecbdf9ee2..6f576aa0b 100644 --- a/admin/modals/vendor_template/vendor_template_form.php +++ b/admin/modals/vendor_template/vendor_template_form.php @@ -103,7 +103,7 @@ $contact_phone_value = ($vt['contact_phone'] ?? '') !== '' ? escapeHtml(formatPh
- +
diff --git a/agent/ajax.php b/agent/ajax.php index 31b4e6e35..d10199127 100644 --- a/agent/ajax.php +++ b/agent/ajax.php @@ -2282,7 +2282,7 @@ if (isset($_GET['asset_duplicate_check'])) { if ($row) { $what = $field === 'mac' ? 'This MAC address' : 'This serial number'; $message = hasClientAccess($row['asset_client_id']) - ? "$what is already on " . escapeHtml($row['asset_name']) . "" + ? "$what is already on " . escapeHtml($row['asset_name']) . "" . " at " . escapeHtml($row['client_name']) . ($row['asset_archived_at'] ? ' (archived)' : '') : "$what is already on an asset of a client you cannot open."; } @@ -2533,7 +2533,7 @@ if (isset($_GET['contact_email_check'])) { WHERE contact_email = '$email' AND contact_id != $exclude_contact ORDER BY contact_archived_at IS NOT NULL, contact_id DESC LIMIT 1"); if ($row = mysqli_fetch_assoc($sql_contacts)) { $response['message'] = hasClientAccess($row['contact_client_id']) - ? "Already on file: " . escapeHtml($row['contact_name']) . "" + ? "Already on file: " . escapeHtml($row['contact_name']) . "" . " at " . escapeHtml($row['client_name']) . ($row['contact_archived_at'] ? ' (archived)' : '') : "Already on file for a client you cannot open."; } diff --git a/agent/client_onboarding/agreement.php b/agent/client_onboarding/agreement.php index 828fc0906..f774c5db2 100644 --- a/agent/client_onboarding/agreement.php +++ b/agent/client_onboarding/agreement.php @@ -43,7 +43,7 @@ foreach ($co_templates as $co_template_id => $co_template) {
  • - +
    , - out to sign diff --git a/agent/client_onboarding/kickoff.php b/agent/client_onboarding/kickoff.php index e2dbc46a1..5ff5dabaf 100644 --- a/agent/client_onboarding/kickoff.php +++ b/agent/client_onboarding/kickoff.php @@ -52,7 +52,7 @@ while ($co_contact = mysqli_fetch_assoc($co_sql)) {
  • - +
    ticket
    Completed diff --git a/agent/clients.php b/agent/clients.php index 8cbcebb8d..b844f5e62 100644 --- a/agent/clients.php +++ b/agent/clients.php @@ -632,7 +632,7 @@ $total_leads = intval($row['leads']);
  • - + Add primary location diff --git a/agent/expenses.php b/agent/expenses.php index 756fab0f3..96b8cef49 100644 --- a/agent/expenses.php +++ b/agent/expenses.php @@ -364,7 +364,7 @@ $month_change = $stats['last_to_date'] > 0 ? round(($stats['month'] - $stats['la > - + diff --git a/agent/includes/client_details.php b/agent/includes/client_details.php index dde0ae3a0..e8eef7c5f 100644 --- a/agent/includes/client_details.php +++ b/agent/includes/client_details.php @@ -53,7 +53,7 @@ $location_map_query = rawurlencode(html_entity_decode(trim("$location_address $l - Add primary location + Add primary location None diff --git a/agent/includes/inc_canned_response_picker.php b/agent/includes/inc_canned_response_picker.php index 4d760dd2f..57e075acd 100644 --- a/agent/includes/inc_canned_response_picker.php +++ b/agent/includes/inc_canned_response_picker.php @@ -68,7 +68,7 @@ if (!empty($canned_picker_groups) || intval($canned_picker_ticket_id) > 0) { ?> Save Your Reply as a Canned Response - + Your Canned Responses diff --git a/agent/includes/inc_kb_picker.php b/agent/includes/inc_kb_picker.php index 0cc525a71..6fb5692ba 100644 --- a/agent/includes/inc_kb_picker.php +++ b/agent/includes/inc_kb_picker.php @@ -41,7 +41,7 @@ if (kbCan(1)) {
    - Open the Knowledge Base + Open the Knowledge Base
    diff --git a/agent/invoice.php b/agent/invoice.php index 204eba528..b607ee6df 100644 --- a/agent/invoice.php +++ b/agent/invoice.php @@ -227,13 +227,13 @@ echo agentBannersHtml($client_id);
    - +
    - +
    Shown to the client in their portal.
    diff --git a/agent/modals/asset/asset_interface_multiple_add.php b/agent/modals/asset/asset_interface_multiple_add.php index 51bdb6871..554e4e90c 100644 --- a/agent/modals/asset/asset_interface_multiple_add.php +++ b/agent/modals/asset/asset_interface_multiple_add.php @@ -97,7 +97,7 @@ ob_start();
    - +
    diff --git a/agent/modals/client/client_add.php b/agent/modals/client/client_add.php index d7fdbe390..63b4ea3ac 100644 --- a/agent/modals/client/client_add.php +++ b/agent/modals/client/client_add.php @@ -88,7 +88,7 @@ ob_start();
    - +
    @@ -294,7 +294,7 @@ ob_start();
    - +
    diff --git a/agent/modals/client/client_bulk_add_ticket.php b/agent/modals/client/client_bulk_add_ticket.php index 2913524c1..571aa0cb1 100644 --- a/agent/modals/client/client_bulk_add_ticket.php +++ b/agent/modals/client/client_bulk_add_ticket.php @@ -32,7 +32,7 @@ ob_start();
    - +
    diff --git a/agent/modals/client/client_bulk_edit_industry.php b/agent/modals/client/client_bulk_edit_industry.php index bd3e3142c..15eb201c9 100644 --- a/agent/modals/client/client_bulk_edit_industry.php +++ b/agent/modals/client/client_bulk_edit_industry.php @@ -25,7 +25,7 @@ ob_start();
    - +
    diff --git a/agent/modals/client/client_credit_add.php b/agent/modals/client/client_credit_add.php index dcdf36c84..a6aa8c490 100644 --- a/agent/modals/client/client_credit_add.php +++ b/agent/modals/client/client_credit_add.php @@ -42,7 +42,7 @@
    - +
    diff --git a/agent/modals/client/client_edit.php b/agent/modals/client/client_edit.php index 0537c4651..8475e4131 100644 --- a/agent/modals/client/client_edit.php +++ b/agent/modals/client/client_edit.php @@ -120,7 +120,7 @@ ob_start();
    -
    @@ -182,7 +182,7 @@ ob_start();
    - +
    diff --git a/agent/modals/client/client_statement.php b/agent/modals/client/client_statement.php index e02e79ace..34f21d4b6 100644 --- a/agent/modals/client/client_statement.php +++ b/agent/modals/client/client_statement.php @@ -131,7 +131,7 @@ ob_start(); -
    + Download PDF diff --git a/agent/modals/contact/contact_bulk_edit_phone.php b/agent/modals/contact/contact_bulk_edit_phone.php index 7ee6cccf6..ac10ba487 100644 --- a/agent/modals/contact/contact_bulk_edit_phone.php +++ b/agent/modals/contact/contact_bulk_edit_phone.php @@ -23,7 +23,7 @@ ob_start();
    - +
    diff --git a/agent/modals/contract/contract_countersign.php b/agent/modals/contract/contract_countersign.php index 5f39fde93..52d53984d 100644 --- a/agent/modals/contract/contract_countersign.php +++ b/agent/modals/contract/contract_countersign.php @@ -52,7 +52,7 @@ if (!$round || $state['key'] !== 'countersign') { ?> diff --git a/agent/modals/contract/contract_send.php b/agent/modals/contract/contract_send.php index 7c222bcfe..50a9609ad 100644 --- a/agent/modals/contract/contract_send.php +++ b/agent/modals/contract/contract_send.php @@ -108,7 +108,7 @@ if (!$contract || !contractSignaturesReady() || in_array($contract['contract_sta diff --git a/agent/modals/credential/credential_form.php b/agent/modals/credential/credential_form.php index 52c7e3bb3..6978e8c9e 100644 --- a/agent/modals/credential/credential_form.php +++ b/agent/modals/credential/credential_form.php @@ -132,7 +132,7 @@ $form_id = 'credentialForm' . ($credential_form_mode === 'edit' ? $credential_id
    - +
    @@ -140,7 +140,7 @@ $form_id = 'credentialForm' . ($credential_form_mode === 'edit' ? $credential_id
    - +
    diff --git a/agent/modals/document/document_form.php b/agent/modals/document/document_form.php index 1abe9a169..867e44b58 100644 --- a/agent/modals/document/document_form.php +++ b/agent/modals/document/document_form.php @@ -17,7 +17,7 @@
    - > + >
    diff --git a/agent/modals/expense/expense.php b/agent/modals/expense/expense.php index f9f4a0f2b..5651437a9 100644 --- a/agent/modals/expense/expense.php +++ b/agent/modals/expense/expense.php @@ -97,7 +97,7 @@ ob_start();
    - Receipt + Receipt diff --git a/agent/modals/expense/expense_form.php b/agent/modals/expense/expense_form.php index e1f17f238..a5284e058 100644 --- a/agent/modals/expense/expense_form.php +++ b/agent/modals/expense/expense_form.php @@ -120,7 +120,7 @@ $form_markup = $form_row && !$form_refund ? floatval($form_row['expense_markup'] - +
    @@ -310,7 +310,7 @@ $form_markup = $form_row && !$form_refund ? floatval($form_row['expense_markup'] ['title' => 'Receipt', 'shapes' => 'free', 'box' => 'tall', 'max' => 2400, 'accept' => 'image/*,application/pdf']) ?>
    -
    +
    Click it to - on a phone, Take a photo opens the camera.
    diff --git a/agent/modals/file/file.php b/agent/modals/file/file.php index fc3aac48c..772562824 100644 --- a/agent/modals/file/file.php +++ b/agent/modals/file/file.php @@ -76,7 +76,7 @@ ob_start();
    - <?= $file_name ?> + <?= $file_name ?> diff --git a/agent/modals/folder/folder_add.php b/agent/modals/folder/folder_add.php index 863dec12c..cf46ba321 100644 --- a/agent/modals/folder/folder_add.php +++ b/agent/modals/folder/folder_add.php @@ -30,7 +30,7 @@ ob_start();
    - +
    diff --git a/agent/modals/kb/kb_article_form.php b/agent/modals/kb/kb_article_form.php index aa9758f58..6e8c90ce3 100644 --- a/agent/modals/kb/kb_article_form.php +++ b/agent/modals/kb/kb_article_form.php @@ -31,7 +31,7 @@ $kb_form_audience = $kb_form_mode === 'edit' ? kbAudienceFields($kb_form) : ['vi
    - > + >
    diff --git a/agent/modals/network/network_form.php b/agent/modals/network/network_form.php index f6e4252c3..5388fcf7e 100644 --- a/agent/modals/network/network_form.php +++ b/agent/modals/network/network_form.php @@ -129,7 +129,7 @@ $value = function ($key) use ($form) {
    - +
    diff --git a/agent/modals/recurring_expense/recurring_expense_form.php b/agent/modals/recurring_expense/recurring_expense_form.php index fcbda2813..bc968347b 100644 --- a/agent/modals/recurring_expense/recurring_expense_form.php +++ b/agent/modals/recurring_expense/recurring_expense_form.php @@ -83,7 +83,7 @@ while ($row = mysqli_fetch_assoc($sql)) { - + diff --git a/agent/modals/ticket/ticket_add.php b/agent/modals/ticket/ticket_add.php index c512ad1f4..a8ac629b8 100644 --- a/agent/modals/ticket/ticket_add.php +++ b/agent/modals/ticket/ticket_add.php @@ -401,7 +401,7 @@ ob_start();
    -
    diff --git a/agent/modals/ticket/ticket_bulk_resolve.php b/agent/modals/ticket/ticket_bulk_resolve.php index ea3d6988b..a681260fa 100644 --- a/agent/modals/ticket/ticket_bulk_resolve.php +++ b/agent/modals/ticket/ticket_bulk_resolve.php @@ -23,7 +23,7 @@ ob_start();
    diff --git a/agent/modals/vendor/vendor_form.php b/agent/modals/vendor/vendor_form.php index 9ca08267e..92967fb3f 100644 --- a/agent/modals/vendor/vendor_form.php +++ b/agent/modals/vendor/vendor_form.php @@ -188,7 +188,7 @@ $form_id = 'vendorForm' . ($vendor_form_mode === 'edit' ? $vendor_id : 'New');
    - +
    diff --git a/agent/networks.php b/agent/networks.php index 345a722a3..f0f962833 100644 --- a/agent/networks.php +++ b/agent/networks.php @@ -397,7 +397,7 @@ $csrf = $_SESSION['csrf_token']; Quick Look - + Open in a New Tab diff --git a/agent/projects.php b/agent/projects.php index 204fd5126..147a92a5f 100644 --- a/agent/projects.php +++ b/agent/projects.php @@ -408,7 +408,7 @@ $hidden_filter_count = $date_filter_active ? 1 : 0; Quick Look - + Open in a New Tab diff --git a/agent/purchase_order.php b/agent/purchase_order.php index 1745e41f5..ab0fede55 100644 --- a/agent/purchase_order.php +++ b/agent/purchase_order.php @@ -115,7 +115,7 @@ if (!$po || !poAccessible($po['po_id'])) {