From f39b0eb3679ee81dcbf0e381afc1ca0a0ec595fe Mon Sep 17 00:00:00 2001 From: wrongecho Date: Thu, 2 Jan 2025 21:05:03 +0000 Subject: [PATCH] Tidying per sonar recommendations --- scripts/cron.php | 9 +++++---- scripts/cron_ticket_email_parser.php | 2 -- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/scripts/cron.php b/scripts/cron.php index 543c11ad..f149d60b 100644 --- a/scripts/cron.php +++ b/scripts/cron.php @@ -162,7 +162,7 @@ if ($config_enable_alert_domain_expire == 1) { $sql = mysqli_query( $mysqli, "SELECT * FROM domains - LEFT JOIN clients ON domain_client_id = client_id + LEFT JOIN clients ON domain_client_id = client_id WHERE domain_expire IS NOT NULL AND domain_expire = CURDATE() + INTERVAL $day DAY" ); @@ -192,7 +192,7 @@ foreach ($certificateAlertArray as $day) { $sql = mysqli_query( $mysqli, "SELECT * FROM certificates - LEFT JOIN clients ON certificate_client_id = client_id + LEFT JOIN clients ON certificate_client_id = client_id WHERE certificate_expire = CURDATE() + INTERVAL $day DAY" ); @@ -397,7 +397,7 @@ if (mysqli_num_rows($sql_scheduled_tickets) > 0) { $sql_resolved_tickets_to_close = mysqli_query( $mysqli, - "SELECT * FROM tickets + "SELECT * FROM tickets WHERE ticket_status = 4 AND ticket_updated_at < NOW() - INTERVAL $config_ticket_autoclose_hours HOUR" ); @@ -682,7 +682,8 @@ while ($row = mysqli_fetch_array($sql_recurring)) { mysqli_query($mysqli,"INSERT INTO history SET history_status = 'Paid', history_description = 'Payment added via Auto Pay', history_invoice_id = $new_invoice_id"); // Logging - logAction("Invoice", "Payment", "Auto Payment amount of " . numfmt_format_currency($currency_format, $recurring_amount, $recurring_payment_currency_code) . " added to invoice $invoice_prefix$invoice_number", $client_id, $new_invoice_id); + logAction("Invoice", "Payment", "Auto Payment amount of " . numfmt_format_currency($currency_format, $recurring_amount, $recurring_payment_currency_code) . " added to invoice $invoice_prefix$invoice_number", $client_id, $new_invoice_id); + } //End Auto Payment } //End Recurring Invoices Loop diff --git a/scripts/cron_ticket_email_parser.php b/scripts/cron_ticket_email_parser.php index e8b3e637..22b21d96 100644 --- a/scripts/cron_ticket_email_parser.php +++ b/scripts/cron_ticket_email_parser.php @@ -556,5 +556,3 @@ if (file_exists($lock_file_path)) { } echo "Processed Emails into tickets: $processed_count\n"; echo "Unprocessed Emails: $unprocessed_count\n"; - -?>