diff --git a/CHANGELOG.md b/CHANGELOG.md index 08f5155dc..9e1c7951b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -232,6 +232,7 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u - Screen readers: every window's close button is read out as Close, and the arrow beside a list's New button and the ⋮ menus on record pages as More actions, rather than as a button with no name or just More. - Counts: the counts in menus, tabs, list headers and under every list - Showing 1 to 25 of 1,834 records - have a thousands separator, as the dashboard, reports and audit log already did. - Confirmations: archiving a credential from an asset, contact, vendor, service or license page no longer asks first, as archiving anywhere else doesn't - the message's Undo puts it back. Taking a related ticket off a ticket, or a ticket off a service's page, asks first, as the ticket page's other × buttons do. Hints under a few fields - a statement's From, a cron job's schedule, a quote's price per hour - look like every other field's. +- Required fields: every field marked * has to be filled in before the window saves, and every field that has to be filled in is marked * - a few had one without the other, such as a credit's note, the comment when merging several tickets, and the dates when activating, renewing or ending a contract. Hints under fields look the same in every window. ### Bug Fixes @@ -296,6 +297,7 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u - Payments: editing a payment said "Payment edited to amount ... added" in your company's currency rather than the payment's, and its audit log entry didn't say who edited it or which client it was for. - Invoice links: asking to pay by card when card payments weren't set up went to a page that doesn't exist. It goes back to the invoice and says card payments are not set up. - Assets: Bulk Action > Delete deleted the ticked assets straight away, without asking first as every other list's Delete does. +- Assets: moving the ticked assets to another client with no client picked moved them to no client at all. It now asks for the client. ### Developer Updates diff --git a/admin/modals/category/category_form.php b/admin/modals/category/category_form.php index f77d077f1..4864cab0f 100644 --- a/admin/modals/category/category_form.php +++ b/admin/modals/category/category_form.php @@ -112,7 +112,7 @@ $c_max = $c_config['max'] ?? 200; - Asset statuses show as a badge in their color - the icon shows in the status picker. +
Asset statuses show as a badge in their color - the icon shows in the status picker.
diff --git a/admin/modals/contract_template/contract_template_form.php b/admin/modals/contract_template/contract_template_form.php index 6defb3b62..a2cd4d9cd 100644 --- a/admin/modals/contract_template/contract_template_form.php +++ b/admin/modals/contract_template/contract_template_form.php @@ -158,7 +158,7 @@ $tab = 'templateTab' . bin2hex(random_bytes(3)); - From Admin > SLAs. While the contract is in force, the client's new tickets get them, and the default for a priority left on the default. +
From Admin > SLAs. While the contract is in force, the client's new tickets get them, and the default for a priority left on the default.
diff --git a/admin/modals/document_template/document_template_form.php b/admin/modals/document_template/document_template_form.php index 15e8479ae..b5df435d1 100644 --- a/admin/modals/document_template/document_template_form.php +++ b/admin/modals/document_template/document_template_form.php @@ -45,7 +45,7 @@ $ai_model = aiReady('Documentation') ? getAiModel('Documentation') : null;
- Replaces what is in the editor below. +
Replaces what is in the editor below.
diff --git a/admin/modals/document_template/document_template_use.php b/admin/modals/document_template/document_template_use.php index 43624f42e..5dd9a9b44 100644 --- a/admin/modals/document_template/document_template_use.php +++ b/admin/modals/document_template/document_template_use.php @@ -67,7 +67,7 @@ if (!$template || $template['document_template_archived_at']) { ?> - It goes in the client's Files at the top level, and opens to fill in. +
It goes in the client's Files at the top level, and opens to fill in.
- Each goes in its client's Files at the top level, named and summed up as the template is. +
Each goes in its client's Files at the top level, named and summed up as the template is.
- Merges into the method you pick. To leave its records as they are, archive it instead - it stops being offered, and they keep saying . +
Merges into the method you pick. To leave its records as they are, archive it instead - it stops being offered, and they keep saying .

Nothing has been paid this way, so nothing else changes.

diff --git a/admin/modals/payment_method/payment_method_form.php b/admin/modals/payment_method/payment_method_form.php index 182166cdc..cbe9e1429 100644 --- a/admin/modals/payment_method/payment_method_form.php +++ b/admin/modals/payment_method/payment_method_form.php @@ -24,9 +24,9 @@ $m_usage = $m ? paymentMethodUsageFor($m_name) : ['total' => 0]; > - Card payments clients make online are recorded as , so its name stays. +
Card payments clients make online are recorded as , so its name stays.
- Renaming it renames it on the that used it. +
Renaming it renames it on the that used it.
@@ -48,5 +48,5 @@ $m_usage = $m ? paymentMethodUsageFor($m_name) : ['total' => 0]; - Which pickers offer it - money in is payments from clients and other income; money out is expenses, recurring expenses, reimbursements and mileage claims. Transfers between accounts offer every method. +
Which pickers offer it - money in is payments from clients and other income; money out is expenses, recurring expenses, reimbursements and mileage claims. Transfers between accounts offer every method.
diff --git a/admin/modals/sla/holiday_generate.php b/admin/modals/sla/holiday_generate.php index 606fb3ea0..5534285b8 100644 --- a/admin/modals/sla/holiday_generate.php +++ b/admin/modals/sla/holiday_generate.php @@ -46,11 +46,11 @@ ob_start(); - +
[$in, $total]) { ?> - - +
A day already on the list is left as it is, name and all. Adding them works the targets out again on every ticket with an SLA that isn't closed yet.
diff --git a/admin/modals/sla/sla_form.php b/admin/modals/sla/sla_form.php index 454b3058c..81cae7f6c 100644 --- a/admin/modals/sla/sla_form.php +++ b/admin/modals/sla/sla_form.php @@ -52,7 +52,7 @@ $f_day_minutes = slaBusinessDayMinutes(); minutes - How long there is to first reply to a new ticket. +
How long there is to first reply to a new ticket.
@@ -64,7 +64,7 @@ $f_day_minutes = slaBusinessDayMinutes(); minutes
- How long there is to resolve it. Leave both empty for an SLA that only times the first reply. +
How long there is to resolve it. Leave both empty for an SLA that only times the first reply.
diff --git a/admin/modals/tag/tag_form.php b/admin/modals/tag/tag_form.php index a4e17a2f3..aef2c54fd 100644 --- a/admin/modals/tag/tag_form.php +++ b/admin/modals/tag/tag_form.php @@ -56,7 +56,7 @@ if (!in_array($t_icon, $t_icons, true)) {
- In use, so it stays +
In use, so it stays
@@ -67,7 +67,7 @@ if (!in_array($t_icon, $t_icons, true)) { - Shown on the tag and in the tag picker +
Shown on the tag and in the tag picker
diff --git a/admin/modals/tax/tax_archive.php b/admin/modals/tax/tax_archive.php index ce24a4a7f..a6fdfe0ba 100644 --- a/admin/modals/tax/tax_archive.php +++ b/admin/modals/tax/tax_archive.php @@ -54,7 +54,7 @@ if (!$tax || $tax['tax_archived_at']) { ?>
- Left where they are, recurring invoices and drafts keep charging it, products and clients fall back to the next rate along for new lines. +
Left where they are, recurring invoices and drafts keep charging it, products and clients fall back to the next rate along for new lines.
diff --git a/admin/modals/tax/tax_form.php b/admin/modals/tax/tax_form.php index e2fec15ff..496773a23 100644 --- a/admin/modals/tax/tax_form.php +++ b/admin/modals/tax/tax_form.php @@ -71,7 +71,7 @@ $tax_part_row = function ($key, array $part = []) { - Printed with this tax on invoices +
Printed with this tax on invoices
diff --git a/admin/modals/ticket_status/ticket_status_form.php b/admin/modals/ticket_status/ticket_status_form.php index e04cb4b6c..b466dcd09 100644 --- a/admin/modals/ticket_status/ticket_status_form.php +++ b/admin/modals/ticket_status/ticket_status_form.php @@ -50,7 +50,7 @@ $s_reply_value = $s_reply_to && isset($s_reply_choices["to-$s_reply_to"]) ? "to- data-ticket-status-name> - ITFlow's own statuses keep their names. +
ITFlow's own statuses keep their names.
@@ -60,7 +60,7 @@ $s_reply_value = $s_reply_to && isset($s_reply_choices["to-$s_reply_to"]) ? "to- - Shown when the status is hovered - in the pickers, on the board and on tickets. +
Shown when the status is hovered - in the pickers, on the board and on tickets.
@@ -93,10 +93,10 @@ $s_reply_value = $s_reply_to && isset($s_reply_choices["to-$s_reply_to"]) ? "to-
- +
Fixed for ITFlow's own statuses. A ticket in a paused status never warns or breaches on resolution - the time already spent is kept, and the deadline moves out when it comes back. The response clock always runs. - +
@@ -113,13 +113,13 @@ $s_reply_value = $s_reply_to && isset($s_reply_choices["to-$s_reply_to"]) ? "to-
- +
A closed ticket takes no replies. By email, in the portal or by text. Move it to a status such as "Client responded" to see at a glance which tickets have a new answer; back to Open suits a status that waits on the client. Whoever it is assigned to is told either way. - +
@@ -133,9 +133,9 @@ $s_reply_value = $s_reply_to && isset($s_reply_choices["to-$s_reply_to"]) ? "to- - +
An agent moving a ticket into this status before anyone has answered the client meets - or misses - the SLA's response target then: setting it by hand or in a reply, or assigning a new ticket, which moves it to Open. Once per ticket. With the email, the contact and watchers get the "ticket assigned" message from Settings > Tickets, kept on the ticket as a public note; if nobody could be emailed, it doesn't count. - +
diff --git a/admin/modals/ticket_status/ticket_status_remove.php b/admin/modals/ticket_status/ticket_status_remove.php index 10ffc7e02..49b976882 100644 --- a/admin/modals/ticket_status/ticket_status_remove.php +++ b/admin/modals/ticket_status/ticket_status_remove.php @@ -65,7 +65,7 @@ if (!$ticket_status || ticketStatusIsBuiltIn($ticket_status['ticket_status_id']) - Each says so in its history, and its SLA clock follows the status it goes to. +
Each says so in its history, and its SLA clock follows the status it goes to.

No tickets are in it.

diff --git a/agent/modals/asset/asset_bulk_transfer_client.php b/agent/modals/asset/asset_bulk_transfer_client.php index 0d2e65f28..435b2f8d5 100644 --- a/agent/modals/asset/asset_bulk_transfer_client.php +++ b/agent/modals/asset/asset_bulk_transfer_client.php @@ -31,7 +31,7 @@ ob_start();
-
- +
- +
diff --git a/agent/modals/client/client_add.php b/agent/modals/client/client_add.php index 75e191f62..a75303b89 100644 --- a/agent/modals/client/client_add.php +++ b/agent/modals/client/client_add.php @@ -278,7 +278,7 @@ ob_start();
- Emailed as set in Invoice Settings. Off, this client gets neither - invoices can still be sent by hand. +
Emailed as set in Invoice Settings. Off, this client gets neither - invoices can still be sent by hand.
- +
diff --git a/agent/modals/client/client_bulk_edit_industry.php b/agent/modals/client/client_bulk_edit_industry.php index 3f65bfe6e..7dfe5f486 100644 --- a/agent/modals/client/client_bulk_edit_industry.php +++ b/agent/modals/client/client_bulk_edit_industry.php @@ -22,7 +22,7 @@ ob_start(); diff --git a/agent/modals/client/client_edit.php b/agent/modals/client/client_edit.php index b193dca93..984fd76be 100644 --- a/agent/modals/client/client_edit.php +++ b/agent/modals/client/client_edit.php @@ -166,7 +166,7 @@ ob_start(); >
- Emailed as set in Invoice Settings. Off, this client gets neither - invoices can still be sent by hand. +
Emailed as set in Invoice Settings. Off, this client gets neither - invoices can still be sent by hand.
- For new lines on its invoices and quotes - where it is, for sales tax +
For new lines on its invoices and quotes - where it is, for sales tax
@@ -43,7 +43,7 @@ $ct_expires = (string) ($ct['client_tax_exempt_expires'] ?? ''); >
- Its new lines get no tax, and its invoices and quotes say it is exempt +
Its new lines get no tax, and its invoices and quotes say it is exempt
diff --git a/agent/modals/contract/contract_activate.php b/agent/modals/contract/contract_activate.php index a021f5837..8747305b6 100644 --- a/agent/modals/contract/contract_activate.php +++ b/agent/modals/contract/contract_activate.php @@ -30,15 +30,15 @@ if (!$contract || $contract['contract_status'] !== 'Draft') { ?> - Reminded before it renews or ends. +
Reminded before it renews or ends.
@@ -322,7 +322,7 @@ $tab = 'contractTab' . bin2hex(random_bytes(3)); - From Admin > SLAs. While the contract is in force, the client's new tickets get them, and the default for a priority left on the default. +
From Admin > SLAs. While the contract is in force, the client's new tickets get them, and the default for a priority left on the default.
@@ -335,7 +335,7 @@ $tab = 'contractTab' . bin2hex(random_bytes(3));
- Only agents see these. +
Only agents see these.
diff --git a/agent/modals/contract/contract_hours_add.php b/agent/modals/contract/contract_hours_add.php index 3a52b89c4..abac175f7 100644 --- a/agent/modals/contract/contract_hours_add.php +++ b/agent/modals/contract/contract_hours_add.php @@ -88,7 +88,7 @@ if (!$contract || !contractHoursReady() || !($contract['contract_status'] === 'D - One line, at the client's usual tax rate for time. Send it from the invoice when it is ready. +
One line, at the client's usual tax rate for time. Send it from the invoice when it is ready.
- +
diff --git a/agent/modals/product/product_bulk_edit_category.php b/agent/modals/product/product_bulk_edit_category.php index 76f0b029b..93e08daf1 100644 --- a/agent/modals/product/product_bulk_edit_category.php +++ b/agent/modals/product/product_bulk_edit_category.php @@ -27,7 +27,7 @@ ob_start();
- diff --git a/agent/modals/product/product_form.php b/agent/modals/product/product_form.php index 5e1a11851..c6e78f753 100644 --- a/agent/modals/product/product_form.php +++ b/agent/modals/product/product_form.php @@ -91,7 +91,7 @@ if ($form_vendor_id && !isset($form_vendors[$form_vendor_id]) && $form_value('ve
- Taxed, its lines take the client's own rate when it has one +
Taxed, its lines take the client's own rate when it has one
diff --git a/agent/modals/recurring_ticket/recurring_ticket_bulk_next_run_edit.php b/agent/modals/recurring_ticket/recurring_ticket_bulk_next_run_edit.php index 6ca109996..790256574 100644 --- a/agent/modals/recurring_ticket/recurring_ticket_bulk_next_run_edit.php +++ b/agent/modals/recurring_ticket/recurring_ticket_bulk_next_run_edit.php @@ -27,7 +27,7 @@ ob_start();
- " max="2999-12-31"> + " max="2999-12-31" required>
diff --git a/agent/modals/software/software_key_add.php b/agent/modals/software/software_key_add.php index 22fac4c55..287b189f6 100644 --- a/agent/modals/software/software_key_add.php +++ b/agent/modals/software/software_key_add.php @@ -30,7 +30,7 @@ ob_start(); diff --git a/agent/modals/ticket/ticket_bulk_merge.php b/agent/modals/ticket/ticket_bulk_merge.php index 0904ee7d8..9639ddfee 100644 --- a/agent/modals/ticket/ticket_bulk_merge.php +++ b/agent/modals/ticket/ticket_bulk_merge.php @@ -83,7 +83,7 @@ ob_start();
- +
diff --git a/agent/modals/ticket/ticket_quote_add.php b/agent/modals/ticket/ticket_quote_add.php index 9e72c0f9a..e2cd92d3c 100644 --- a/agent/modals/ticket/ticket_quote_add.php +++ b/agent/modals/ticket/ticket_quote_add.php @@ -129,7 +129,7 @@ ob_start();
- "> + " required>
diff --git a/agent/modals/ticket/ticket_reply_edit.php b/agent/modals/ticket/ticket_reply_edit.php index 9371d92ea..fe3a4e01a 100644 --- a/agent/modals/ticket/ticket_reply_edit.php +++ b/agent/modals/ticket/ticket_reply_edit.php @@ -61,7 +61,7 @@ ob_start(); > - Public replies show in the client portal. Saving here never sends an email. +
Public replies show in the client portal. Saving here never sends an email.
diff --git a/agent/modals/ticket/ticket_sla.php b/agent/modals/ticket/ticket_sla.php index 32881b2c7..956e9f171 100644 --- a/agent/modals/ticket/ticket_sla.php +++ b/agent/modals/ticket/ticket_sla.php @@ -40,7 +40,7 @@ ob_start(); - The response and resolution deadlines are worked out again from when the ticket was opened. +
The response and resolution deadlines are worked out again from when the ticket was opened.
diff --git a/agent/post/asset.php b/agent/post/asset.php index ee924a62b..bc89d76fa 100644 --- a/agent/post/asset.php +++ b/agent/post/asset.php @@ -527,7 +527,11 @@ if (isset($_POST['bulk_transfer_client_asset'])) { enforceUserPermission('module_support', 2); - $new_client_id = intval($_POST['bulk_client_id']); + $new_client_id = intval($_POST['bulk_client_id'] ?? 0); + if (!$new_client_id || !getFieldById('clients', $new_client_id, 'client_name')) { + flashAlert('Pick the client to move them to.', 'error'); + redirect(); + } enforceClientAccess($new_client_id); diff --git a/agent/post/credit.php b/agent/post/credit.php index 991e16a70..5b790a179 100644 --- a/agent/post/credit.php +++ b/agent/post/credit.php @@ -27,7 +27,7 @@ if (isset($_POST['add_credit'])) { logAudit("Credit", "Create", "$session_name added " . billingMoney($amount, $session_company_currency) . "", $client_id, $credit_id); - flashAlert(billingMoney($amount, $session_company_currency) . " Credit Added"); + flashAlert("Credit of " . billingMoney($amount, $session_company_currency) . " added"); redirect();