AS1024
/
Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add restriction to disable task drag and drop for a project

This commit is contained in:
Frederic Guillot 2016-10-07 08:45:18 -04:00
parent 4cc856344f
commit 096b000c59
No known key found for this signature in database
GPG Key ID: 92D77191BA7FBC99
28 changed files with 50 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
app/Helper/ProjectRoleHelper.php
View File

@ -62,7 +62,7 @@ class ProjectRoleHelper extends Base
}
}
return empty($sortableColumns);
return empty($sortableColumns) && $this->isAllowedToMoveTask($project_id, $role);
}
return true;
@ -97,7 +97,7 @@ class ProjectRoleHelper extends Base
}
}
return empty($sortableColumns);
return empty($sortableColumns) && $this->isAllowedToMoveTask($project_id, $role);
}
return true;
@ -263,4 +263,24 @@ class ProjectRoleHelper extends Base
return true;
}
/**
* Check if the role can move task in the given project
*
* @param int $project_id
* @param string $role
* @return bool
*/
protected function isAllowedToMoveTask($project_id, $role)
{
$projectRestrictions = $this->projectRoleRestrictionCacheDecorator->getAllByRole($project_id, $role);
foreach ($projectRestrictions as $restriction) {
if ($restriction['rule'] == ProjectRoleRestrictionModel::RULE_TASK_MOVE) {
return false;
}
}
return true;
}
}

1
app/Locale/bs_BA/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/cs_CZ/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/da_DK/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/de_DE/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/el_GR/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/es_ES/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/fi_FI/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/fr_FR/translations.php
View File

@ -1276,4 +1276,5 @@ return array(
'Do you really want to remove this project restriction: "%s"?' => 'Voulez-vous vraiment supprimer cette restriction de projet : « %s » ?',
'Duplicate to multiple projects' => 'Dupliquer vers plusieurs projets',
'This field is required' => 'Ce champ est requis',
'Moving a task is not permitted' => 'Déplaçer une tâche n\'est pas autorisé',
);

1
app/Locale/hu_HU/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/id_ID/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/it_IT/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/ja_JP/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/ko_KR/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/my_MY/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/nb_NO/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/nl_NL/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/pl_PL/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/pt_BR/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/pt_PT/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
'Do you really want to remove this project restriction: "%s"?' => 'Tem a certeza que quer remover a restrição de projeto: "%s"?',
'Duplicate to multiple projects' => 'Duplicar para vários projetos',
'This field is required' => 'Este campo é obrigatório',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/ru_RU/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/sr_Latn_RS/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/sv_SE/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/th_TH/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/tr_TR/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

1
app/Locale/zh_CN/translations.php
View File

@ -1275,4 +1275,5 @@ return array(
// 'Do you really want to remove this project restriction: "%s"?' => '',
// 'Duplicate to multiple projects' => '',
// 'This field is required' => '',
// 'Moving a task is not permitted' => '',
);

2
app/Model/ProjectRoleRestrictionModel.php
View File

@ -16,6 +16,7 @@ class ProjectRoleRestrictionModel extends Base
const RULE_TASK_CREATION = 'task_creation';
const RULE_TASK_OPEN_CLOSE = 'task_open_close';
const RULE_TASK_MOVE = 'task_move';
/**
* Get rules
@ -27,6 +28,7 @@ class ProjectRoleRestrictionModel extends Base
return array(
self::RULE_TASK_CREATION => t('Task creation is not permitted'),
self::RULE_TASK_OPEN_CLOSE => t('Closing or opening a task is not permitted'),
self::RULE_TASK_MOVE => t('Moving a task is not permitted'),
);
}

2
tests/units/Model/ProjectRoleRestrictionModelTest.php
View File

@ -90,7 +90,7 @@ class ProjectRoleRestrictionModelTest extends Base
$projectRoleRestrictionModel = new ProjectRoleRestrictionModel($this->container);
$rules = $projectRoleRestrictionModel->getRules();
$this->assertCount(2, $rules);
$this->assertCount(3, $rules);
$this->assertArrayHasKey(ProjectRoleRestrictionModel::RULE_TASK_OPEN_CLOSE, $rules);
}
}