Fix some Scrutinizer issues

This commit is contained in:
Frédéric Guillot
2014-11-26 21:16:19 -05:00
parent 20b60bc628
commit 3ba8e06632
8 changed files with 16 additions and 16 deletions

View File

@@ -51,7 +51,7 @@ abstract class Base implements Listener
* Container instance * Container instance
* *
* @access protected * @access protected
* @var Pimple\Container * @var \Pimple\Container
*/ */
protected $container; protected $container;

View File

@@ -29,7 +29,7 @@ abstract class Base
* Container instance * Container instance
* *
* @access protected * @access protected
* @var Pimple\Container * @var \Pimple\Container
*/ */
protected $container; protected $container;

View File

@@ -104,7 +104,7 @@ class Ldap extends Base
{ {
$ldap = $this->connect(); $ldap = $this->connect();
if ($this->bind($ldap, $username, $password)) { if (is_resource($ldap) && $this->bind($ldap, $username, $password)) {
return $this->search($ldap, $username, $password); return $this->search($ldap, $username, $password);
} }

View File

@@ -3,7 +3,7 @@
namespace Controller; namespace Controller;
use Model\Project as ProjectModel; use Model\Project as ProjectModel;
use Model\SubTask; use Model\SubTask as SubTaskModel;
use Helper; use Helper;
/** /**
@@ -87,7 +87,7 @@ class App extends Base
*/ */
private function getSubtaskPagination($user_id, $paginate, $offset, $order, $direction) private function getSubtaskPagination($user_id, $paginate, $offset, $order, $direction)
{ {
$status = array(SubTask::STATUS_TODO, SubTask::STATUS_INPROGRESS); $status = array(SubTaskModel::STATUS_TODO, SubTaskModel::STATUS_INPROGRESS);
$limit = 10; $limit = 10;
if (! in_array($order, array('tasks.id', 'project_name', 'status', 'title'))) { if (! in_array($order, array('tasks.id', 'project_name', 'status', 'title'))) {

View File

@@ -55,7 +55,7 @@ abstract class Base
* Request instance * Request instance
* *
* @accesss protected * @accesss protected
* @var Core\Request * @var \Core\Request
*/ */
protected $request; protected $request;
@@ -63,7 +63,7 @@ abstract class Base
* Response instance * Response instance
* *
* @accesss protected * @accesss protected
* @var Core\Response * @var \Core\Response
*/ */
protected $response; protected $response;
@@ -71,7 +71,7 @@ abstract class Base
* Template instance * Template instance
* *
* @accesss protected * @accesss protected
* @var Core\Template * @var \Core\Template
*/ */
protected $template; protected $template;
@@ -79,7 +79,7 @@ abstract class Base
* Session instance * Session instance
* *
* @accesss public * @accesss public
* @var Core\Session * @var \Core\Session
*/ */
protected $session; protected $session;
@@ -87,7 +87,7 @@ abstract class Base
* Container instance * Container instance
* *
* @access private * @access private
* @var Pimple\Container * @var \Pimple\Container
*/ */
private $container; private $container;

View File

@@ -32,7 +32,7 @@ class Router
* Container instance * Container instance
* *
* @access private * @access private
* @var Pimple\Container * @var \Pimple\Container
*/ */
private $container; private $container;
@@ -40,9 +40,9 @@ class Router
* Constructor * Constructor
* *
* @access public * @access public
* @param Pimple\Container $container Container instance * @param \Pimple\Container $container Container instance
* @param string $controller Controller name * @param string $controller Controller name
* @param string $action Action name * @param string $action Action name
*/ */
public function __construct(Container $container, $controller = '', $action = '') public function __construct(Container $container, $controller = '', $action = '')
{ {

View File

@@ -25,7 +25,7 @@ abstract class Base implements Listener
* Container instance * Container instance
* *
* @access protected * @access protected
* @var Pimple\Container * @var \Pimple\Container
*/ */
protected $container; protected $container;

View File

@@ -63,7 +63,7 @@ abstract class Base
* Container instance * Container instance
* *
* @access protected * @access protected
* @var Pimple\Container * @var \Pimple\Container
*/ */
protected $container; protected $container;