Fix PHP notice when sending overdue notifications

This commit is contained in:
Frederic Guillot 2016-08-15 20:46:26 -04:00
parent 70104eff15
commit 5f82a942c0
No known key found for this signature in database
GPG Key ID: 92D77191BA7FBC99
3 changed files with 10 additions and 1 deletions

View File

@ -13,6 +13,10 @@ Improvements:
* Show project name in task forms
* Convert vanilla CSS to SASS
Bug fixes:
* Fix PHP notice when sending overdue notifications
Version 1.0.32
--------------

View File

@ -80,7 +80,7 @@ class MailNotification extends Base implements NotificationInterface
{
return sprintf(
'[%s] %s',
$eventData['task']['project_name'],
isset($eventData['project_name']) ? $eventData['project_name'] : $eventData['task']['project_name'],
$this->notificationModel->getTitleWithoutAuthor($eventName, $eventData)
);
}

View File

@ -58,6 +58,11 @@ class MailNotificationTest extends Base
$this->assertNotEmpty($mailNotification->getMailContent($eventName, $eventData));
$this->assertStringStartsWith('[test] ', $mailNotification->getMailSubject($eventName, $eventData));
}
$this->assertStringStartsWith('[Test1, Test2] ', $mailNotification->getMailSubject(TaskModel::EVENT_OVERDUE, array(
'tasks' => array(array('id' => 123), array('id' => 456)),
'project_name' => 'Test1, Test2',
)));
}
public function testSendWithEmailAddress()