Remove some warnings for Scrutinizer-ci

actions/task_assign_color_user.php

@@ -12,6 +12,14 @@ require_once __DIR__.'/base.php';
  */
 class TaskAssignColorUser extends Base
 {
+    /**
+     * Task model
+     *
+     * @accesss private
+     * @var \Model\Task
+     */
+    private $task;
+
     /**
      * Constructor
      *

actions/task_assign_current_user.php

@@ -12,6 +12,22 @@ require_once __DIR__.'/base.php';
  */
 class TaskAssignCurrentUser extends Base
 {
+    /**
+     * Task model
+     *
+     * @accesss private
+     * @var \Model\Task
+     */
+    private $task;
+
+    /**
+     * Acl model
+     *
+     * @accesss private
+     * @var \Model\Acl
+     */
+    private $acl;
+
     /**
      * Constructor
      *

actions/task_assign_specific_user.php

@@ -12,6 +12,14 @@ require_once __DIR__.'/base.php';
  */
 class TaskAssignSpecificUser extends Base
 {
+    /**
+     * Task model
+     *
+     * @accesss private
+     * @var \Model\Task
+     */
+    private $task;
+
     /**
      * Constructor
      *

actions/task_close.php

@@ -12,6 +12,14 @@ require_once __DIR__.'/base.php';
  */
 class TaskClose extends Base
 {
+    /**
+     * Task model
+     *
+     * @accesss private
+     * @var \Model\Task
+     */
+    private $task;
+
     /**
      * Constructor
      *

actions/task_duplicate_another_project.php

@@ -12,6 +12,14 @@ require_once __DIR__.'/base.php';
  */
 class TaskDuplicateAnotherProject extends Base
 {
+    /**
+     * Task model
+     *
+     * @accesss private
+     * @var \Model\Task
+     */
+    private $task;
+
     /**
      * Constructor
      *

controllers/base.php

@@ -10,6 +10,38 @@ namespace Controller;
  */
 abstract class Base
 {
+    /**
+     * Request instance
+     *
+     * @accesss public
+     * @var \Core\Request
+     */
+    public $request;
+
+    /**
+     * Response instance
+     *
+     * @accesss public
+     * @var \Core\Response
+     */
+    public $response;
+
+    /**
+     * Template instance
+     *
+     * @accesss public
+     * @var \Core\Template
+     */
+    public $template;
+
+    /**
+     * Session instance
+     *
+     * @accesss public
+     * @var \Core\Session
+     */
+    public $session;
+
     /**
      * Acl model
      *

core/session.php

@@ -20,7 +20,7 @@ class Session
         );
 
         // Avoid session id in the URL
-        ini_set('session.use_only_cookies', true);
+        ini_set('session.use_only_cookies', '1');
 
         // Ensure session ID integrity
         ini_set('session.entropy_file', '/dev/urandom');

locales/es_ES/translations.php

@@ -303,4 +303,5 @@ return array(
     // 'Link my Google Account' => '',
     // 'Unlink my Google Account' => '',
     // 'Login with my Google Account' => '',
+    // 'Project not found.' => '',
 );

locales/fr_FR/translations.php

@@ -303,4 +303,5 @@ return array(
     'Link my Google Account' => 'Lier mon compte Google',
     'Unlink my Google Account' => 'Ne plus utiliser mon compte Google',
     'Login with my Google Account' => 'Se connecter avec mon compte Google',
+    'Project not found.' => 'Projet introuvable.'
 );

locales/pl_PL/translations.php

@@ -308,4 +308,5 @@ return array(
     // 'Link my Google Account' => '',
     // 'Unlink my Google Account' => '',
     // 'Login with my Google Account' => '',
+    // 'Project not found.' => '',
 );

locales/pt_BR/translations.php

@@ -304,4 +304,5 @@ return array(
     // 'Link my Google Account' => '',
     // 'Unlink my Google Account' => '',
     // 'Login with my Google Account' => '',
+    // 'Project not found.' => '',
 );

models/google.php

@@ -144,7 +144,9 @@ class Google extends Base
             $googleService->requestAccessToken($code);
             return json_decode($googleService->request('https://www.googleapis.com/oauth2/v1/userinfo'), true);
         }
-        catch (TokenResponseException $e) {}
+        catch (TokenResponseException $e) {
+            return false;
+        }
 
         return false;
     }