AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(mssql): omit ORDER BY in Task WithoutTags & WithGivenTag subqueries

Browse Source 
MSSQL does not allow ORDER BY in subquery without TOP or FETCH/LIMIT
This commit is contained in:
Joe Nahmias
2022-08-23 14:48:33 -04:00
committed by Frédéric Guillot
parent 81caabbc74
commit c39932050c
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Filter/TaskTagFilter.php
View File

@@ -72,7 +72,6 @@ class TaskTagFilter extends BaseFilter implements FilterInterface
return $this->db return $this->db
->table(TaskModel::TABLE) ->table(TaskModel::TABLE)
->columns(TaskModel::TABLE . '.id') ->columns(TaskModel::TABLE . '.id')
->asc(TaskModel::TABLE . '.project_id')
->left(TaskTagModel::TABLE, 'tg', 'task_id', TaskModel::TABLE, 'id') ->left(TaskTagModel::TABLE, 'tg', 'task_id', TaskModel::TABLE, 'id')
->isNull('tg.tag_id'); ->isNull('tg.tag_id');
} }
@@ -83,7 +82,6 @@ class TaskTagFilter extends BaseFilter implements FilterInterface
->table(TagModel::TABLE) ->table(TagModel::TABLE)
->columns(TaskTagModel::TABLE.'.task_id') ->columns(TaskTagModel::TABLE.'.task_id')
->ilike(TagModel::TABLE.'.name', $this->value) ->ilike(TagModel::TABLE.'.name', $this->value)
->asc(TagModel::TABLE.'.project_id')
->join(TaskTagModel::TABLE, 'tag_id', 'id'); ->join(TaskTagModel::TABLE, 'tag_id', 'id');
} }
} }