Avoid PHP warning caused by session_regenerate_id()

Fixes #5268
2023-05-26 17:58:10 -07:00 · 2023-05-26 17:58:10 -07:00 · cda45ddb30
parent 4121940ff1
commit cda45ddb30
1 changed files with 2 additions and 1 deletions
--- a/app/Core/User/UserSession.php
+++ b/app/Core/User/UserSession.php
@ -45,7 +45,8 @@ class UserSession extends Base
        $user['twofactor_activated'] = isset($user['twofactor_activated']) ? (bool) $user['twofactor_activated'] : false;

        if (session_status() === PHP_SESSION_ACTIVE) {
-            session_regenerate_id(true);
+            // Note: Do not delete the old session to avoid possible race condition and a PHP warning.
+            session_regenerate_id(false);
        }

        session_set('user', $user);