Minor code improvements

.scrutinizer.yml

@@ -2,8 +2,7 @@ filter:
     excluded_paths:
         - 'vendor/*'
         - 'tests/*'
-        - 'bin/*'
-        - 'library/*'
+        - 'app/Templates/*'
     paths: {  }
 tools:
     php_sim:
@@ -13,8 +12,7 @@ tools:
             excluded_paths:
                 - 'vendor/*'
                 - 'tests/*'
-                - 'bin/*'
-                - 'library/*'
+                - 'app/Templates/*'
             paths: {  }
     php_pdepend:
         enabled: true
@@ -26,8 +24,7 @@ tools:
             excluded_paths:
                 - 'vendor/*'
                 - 'tests/*'
-                - 'bin/*'
-                - 'library/*'
+                - 'app/Templates/*'
             paths: {  }
     php_analyzer:
         enabled: true
@@ -38,8 +35,7 @@ tools:
             excluded_paths:
                 - 'vendor/*'
                 - 'tests/*'
-                - 'bin/*'
-                - 'library/*'
+                - 'app/Templates/*'
             paths: {  }
         path_configs: {  }
     php_changetracking:
@@ -53,6 +49,5 @@ tools:
             excluded_paths:
                 - 'vendor/*'
                 - 'tests/*'
-                - 'bin/*'
-                - 'library/*'
+                - 'app/Templates/*'
             paths: {  }

app/Controller/Action.php

@@ -91,7 +91,7 @@ class Action extends Base
 
         $values = $this->request->getValues();
 
-        list($valid, $errors) = $this->action->validateCreation($values);
+        list($valid,) = $this->action->validateCreation($values);
 
         if ($valid) {
 

app/Controller/Base.php

@@ -19,10 +19,10 @@ use Model\LastLogin;
  * @property \Model\Config      $config
  * @property \Model\File        $file
  * @property \Model\Google      $google
- * @property \Model\LastLogin   $lastlogin
+ * @property \Model\LastLogin   $lastLogin
  * @property \Model\Ldap        $ldap
  * @property \Model\Project     $project
- * @property \Model\RememberMe  $rememberme
+ * @property \Model\RememberMe  $rememberMe
  * @property \Model\Task        $task
  * @property \Model\User        $user
  */

app/Controller/Board.php

@@ -144,6 +144,8 @@ class Board extends Base
     public function index()
     {
         $projects = $this->project->getListByStatus(ProjectModel::ACTIVE);
+        $project_id = 0;
+        $project_name = '';
 
         if ($this->acl->isRegularUser()) {
             $projects = $this->project->filterListByAccess($projects, $this->acl->getUserId());

app/Core/Router.php

@@ -46,7 +46,7 @@ class Router
     {
         $this->registry = $registry;
         $this->controller = empty($_GET['controller']) ? $controller : $_GET['controller'];
-        $this->action = empty($_GET['action']) ? $controller : $_GET['action'];
+        $this->action = empty($_GET['action']) ? $action : $_GET['action'];
     }
 
     /**

app/Model/File.php

@@ -86,7 +86,7 @@ class File extends Base
      */
     public function getAll($task_id)
     {
-        return $listing = $this->db->table(self::TABLE)
+        return $this->db->table(self::TABLE)
             ->eq('task_id', $task_id)
             ->asc('name')
             ->findAll();

app/Model/Task.php

@@ -215,8 +215,6 @@ class Task extends Base
     {
         $this->db->startTransaction();
 
-        $boardModel = new Board($this->db, $this->event);
-
         // Get the original task
         $task = $this->getById($task_id);