Avoid passing application_url argument to all notification templates

app/Action/TaskEmail.php

@@ -88,7 +88,6 @@ class TaskEmail extends Base
                 $this->getParam('subject'),
                 $this->template->render('notification/task_create', array(
                     'task' => $data['task'],
-                    'application_url' => $this->configModel->get('application_url'),
                 ))
             );
 

app/Action/TaskEmailNoActivity.php

@@ -116,7 +116,7 @@ class TaskEmailNoActivity extends Base
             $user['email'],
             $user['name'] ?: $user['username'],
             $this->getParam('subject'),
-            $this->template->render('notification/task_create', array('task' => $task, 'application_url' => $this->configModel->get('application_url')))
+            $this->template->render('notification/task_create', array('task' => $task))
         );
 
         return true;

app/Notification/MailNotification.php

@@ -62,10 +62,7 @@ class MailNotification extends Base implements NotificationInterface
      */
     public function getMailContent($event_name, array $event_data)
     {
-        return $this->template->render(
-            'notification/'.str_replace('.', '_', $event_name),
-            $event_data + array('application_url' => $this->configModel->get('application_url'))
-        );
+        return $this->template->render('notification/'.str_replace('.', '_', $event_name), $event_data);
     }
 
     /**

app/Template/notification/comment_create.php

@@ -8,4 +8,4 @@
 
 <?= $this->text->markdown($comment['comment'], true) ?>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/comment_delete.php

@@ -4,4 +4,4 @@
 
 <?= $this->text->markdown($comment['comment'], true) ?>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/comment_update.php

@@ -4,4 +4,4 @@
 
 <?= $this->text->markdown($comment['comment'], true) ?>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/comment_user_mention.php

@@ -4,4 +4,4 @@
 
 <?= $this->text->markdown($comment['comment'], true) ?>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/footer.php

@@ -1,7 +1,7 @@
 <hr/>
 Kanboard
 
-<?php if (isset($application_url) && ! empty($application_url)): ?>
+<?php if ($this->app->config('application_url') != ''): ?>
     - <?= $this->url->absoluteLink(t('view the task on Kanboard'), 'TaskViewController', 'show', array('task_id' => $task['id'], 'project_id' => $task['project_id'])) ?>
     - <?= $this->url->absoluteLink(t('view the board on Kanboard'), 'BoardViewController', 'show', array('project_id' => $task['project_id'])) ?>
 <?php endif ?>

app/Template/notification/subtask_create.php

@@ -14,4 +14,4 @@
     </li>
 </ul>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/subtask_delete.php

@@ -8,4 +8,4 @@
     <li><?= t('Assignee:') ?> <?= $this->text->e($subtask['name'] ?: $subtask['username'] ?: '?') ?></li>
 </ul>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/subtask_update.php

@@ -18,4 +18,4 @@
     </li>
 </ul>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/task_assignee_change.php

@@ -17,4 +17,4 @@
     <?= $this->text->markdown($task['description'], true) ?: t('There is no description.') ?>
 <?php endif ?>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/task_close.php

@@ -2,4 +2,4 @@
 
 <p><?= t('The task #%d have been closed.', $task['id']) ?></p>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/task_create.php

@@ -40,4 +40,4 @@
     <?= $this->text->markdown($task['description'], true) ?>
 <?php endif ?>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/task_file_create.php

@@ -2,4 +2,4 @@
 
 <p><?= t('New attachment added "%s"', $file['name']) ?></p>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/task_internal_link_create_update.php

@@ -8,4 +8,4 @@
     ) ?>
 </p>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/task_internal_link_delete.php

@@ -8,4 +8,4 @@
     ) ?>
 </p>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/task_move_column.php

@@ -8,4 +8,4 @@
     <li><?= t('Task position:').' '.$this->text->e($task['position']) ?></li>
 </ul>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/task_move_position.php

@@ -8,4 +8,4 @@
     <li><?= t('Task position:').' '.$this->text->e($task['position']) ?></li>
 </ul>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/task_move_swimlane.php

@@ -16,4 +16,4 @@
     <li><?= t('Task position:').' '.$this->text->e($task['position']) ?></li>
 </ul>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/task_open.php

@@ -2,4 +2,4 @@
 
 <p><?= t('The task #%d have been opened.', $task['id']) ?></p>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/task_update.php

@@ -1,4 +1,4 @@
 <h2><?= $this->text->e($task['title']) ?> (#<?= $task['id'] ?>)</h2>
 
 <?= $this->render('task/changes', array('changes' => $changes, 'task' => $task, 'public' => true)) ?>
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/notification/task_user_mention.php

@@ -4,4 +4,4 @@
 <h2><?= t('Description') ?></h2>
 <?= $this->text->markdown($task['description'], true) ?>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $application_url)) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>

app/Template/task_mail/email.php

@@ -43,4 +43,4 @@
     <?= $this->text->markdown($task['description'], true) ?>
 <?php endif ?>
 
-<?= $this->render('notification/footer', array('task' => $task, 'application_url' => $this->app->config('application_url'))) ?>
+<?= $this->render('notification/footer', array('task' => $task)) ?>