AS1024/Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

In PHP-7.4, nested ternary operators are to be bracketed

Browse Source 
(as their default association is counter-intuitive)
https://wiki.php.net/rfc/ternary_associativity
This commit is contained in:
Lorinczy Zsigmond
2019-11-15 15:39:32 +01:00
committed by Frédéric Guillot
parent 12d55408fe
commit dcdbd3758b
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Model/ActionParameterModel.php
View File

@@ -156,7 +156,7 @@ class ActionParameterModel extends Base
case 'dst_column_id': case 'dst_column_id':
case 'column_id': case 'column_id':
$column = $this->columnModel->getById($value); $column = $this->columnModel->getById($value);
return empty($column) ? false : $this->columnModel->getColumnIdByTitle($project_id, $column['title']) ?: false; return empty($column) ? false : ($this->columnModel->getColumnIdByTitle($project_id, $column['title']) ?: false);
case 'user_id': case 'user_id':
case 'owner_id': case 'owner_id':
if ($value == 0) { if ($value == 0) {
@@ -165,7 +165,7 @@ class ActionParameterModel extends Base
return $this->projectPermissionModel->isAssignable($project_id, $value) ? $value : false; return $this->projectPermissionModel->isAssignable($project_id, $value) ? $value : false;
case 'swimlane_id': case 'swimlane_id':
$column = $this->swimlaneModel->getById($value); $column = $this->swimlaneModel->getById($value);
return empty($column) ? false : $this->swimlaneModel->getIdByName($project_id, $column['name']) ?: false; return empty($column) ? false : ($this->swimlaneModel->getIdByName($project_id, $column['name']) ?: false);
default: default:
return $value; return $value;
} }