AS1024
/
Kanboard-Prod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix bug: Automatic action listeners were using the same instance

This commit is contained in:
Frederic Guillot 2016-01-10 14:00:34 -05:00
parent 26e3996014
commit ff1de5c06d
3 changed files with 45 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ChangeLog
View File

@ -5,6 +5,10 @@ New features:
* Forgot Password
Bug fixes:
* Automatic action listeners were using the same instance
Version 1.0.23
--------------

3
app/Core/Action/ActionManager.php
View File

@ -127,7 +127,8 @@ class ActionManager extends Base
}
foreach ($actions as $action) {
$listener = $this->getAction($action['action_name'])->setProjectId($action['project_id']);
$listener = clone $this->getAction($action['action_name']);
$listener->setProjectId($action['project_id']);
foreach ($action['params'] as $param_name => $param_value) {
$listener->setParam($param_name, $param_value);

39
tests/units/Core/Action/ActionManagerTest.php
View File

@ -154,4 +154,43 @@ class ActionManagerTest extends Base
$this->assertEquals(2, $listeners[0][0]->getProjectId());
}
public function testThatEachListenerAreDifferentInstance()
{
$projectModel = new Project($this->container);
$projectUserRoleModel = new ProjectUserRole($this->container);
$actionModel = new Action($this->container);
$actionTaskAssignColorColumn = new TaskAssignColorColumn($this->container);
$actionManager = new ActionManager($this->container);
$actionManager->register($actionTaskAssignColorColumn);
$this->assertEquals(1, $projectModel->create(array('name' =>'test1')));
$actions = $actionManager->getAvailableActions();
$this->assertEquals(1, $actionModel->create(array(
'project_id' => 1,
'event_name' => Task::EVENT_MOVE_COLUMN,
'action_name' => key($actions),
'params' => array('column_id' => 2, 'color_id' => 'green'),
)));
$this->assertEquals(2, $actionModel->create(array(
'project_id' => 1,
'event_name' => Task::EVENT_MOVE_COLUMN,
'action_name' => key($actions),
'params' => array('column_id' => 1, 'color_id' => 'red'),
)));
$actionManager->attachEvents();
$listeners = $this->container['dispatcher']->getListeners(Task::EVENT_MOVE_COLUMN);
$this->assertCount(2, $listeners);
$this->assertFalse($listeners[0][0] === $listeners[1][0]);
$this->assertEquals(2, $listeners[0][0]->getParam('column_id'));
$this->assertEquals('green', $listeners[0][0]->getParam('color_id'));
$this->assertEquals(1, $listeners[1][0]->getParam('column_id'));
$this->assertEquals('red', $listeners[1][0]->getParam('color_id'));
}
}