QoL 64: bulk asset delete asks first, credential archive from a record page no longer asks as no other archive does, related ticket and service ticket removal ask first like the other ticket page removals, and four field hints use form-text

This commit is contained in:
johnnyq
2026-11-21 02:37:15 -05:00
parent c094f97eed
commit 2e2cbea773
8 changed files with 13 additions and 11 deletions

View File

@@ -231,6 +231,7 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u
- Wording: a ticket task's approval picker says agent rather than technician, with the same blank choice as other pickers - - Select one - and - Select an agent - rather than Select... and - Select a user -. Pickers that fill in as you go read like the rest: changing a ticket's client offers - Select a contact - (or - No contacts -), a project with no client offers - Nobody -, and an asset detail or statement line with nothing picked shows - None - or - Not for a client - rather than a bare dash. The Tickets list's Billing filter starts at - Any -, record pages say Upload Files rather than Upload File(s), and Maintenance > Cron's log counts 1 problem rather than 1 problem(s).
- Screen readers: every window's close button is read out as Close, and the arrow beside a list's New button and the ⋮ menus on record pages as More actions, rather than as a button with no name or just More.
- Counts: the counts in menus, tabs, list headers and under every list - Showing 1 to 25 of 1,834 records - have a thousands separator, as the dashboard, reports and audit log already did.
- Confirmations: archiving a credential from an asset, contact, vendor, service or license page no longer asks first, as archiving anywhere else doesn't - the message's Undo puts it back. Taking a related ticket off a ticket, or a ticket off a service's page, asks first, as the ticket page's other × buttons do. Hints under a few fields - a statement's From, a cron job's schedule, a quote's price per hour - look like every other field's.
### Bug Fixes
@@ -294,6 +295,7 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u
- Audit Logs: income was filed as Income or Revenue, and transfers as Transfer or Account Transfer, depending on where they were made, so the Type filter listed each twice. Each now has one name, and licenses and license templates are License and License Template rather than Software. Entries already in the log are renamed when you update. Entries for RMM providers, collation repairs, the demo reset and Undo have their own icons.
- Payments: editing a payment said "Payment edited to amount ... added" in your company's currency rather than the payment's, and its audit log entry didn't say who edited it or which client it was for.
- Invoice links: asking to pay by card when card payments weren't set up went to a page that doesn't exist. It goes back to the invoice and says card payments are not set up.
- Assets: Bulk Action > Delete deleted the ticked assets straight away, without asking first as every other list's Delete does.
### Developer Updates

View File

@@ -44,7 +44,7 @@ ob_start();
<input type="checkbox" class="form-check-input" name="enabled" value="1" id="cronJobEnabledSwitch" <?= $cron_job_enabled == 1 ? 'checked' : '' ?>>
<label class="form-check-label" for="cronJobEnabledSwitch">Runs on its schedule</label>
</div>
<small class="text-body-secondary">Switched off, it only runs when someone asks it to with Run now.</small>
<div class="form-text">Switched off, it only runs when someone asks it to with Run now.</div>
</div>
<div class="mb-3">
@@ -59,7 +59,7 @@ ob_start();
</select>
</div>
<?php if (!$cron_job_interval_safe) { ?>
<small class="text-body-secondary">It only runs once a day - run more often, its work would be done twice.</small>
<div class="form-text">It only runs once a day - run more often, its work would be done twice.</div>
<?php } ?>
</div>
@@ -70,7 +70,7 @@ ob_start();
<input type="number" class="form-control" name="interval_minutes" value="<?= $cron_job_interval_minutes ?>" min="1" max="1440">
<span class="input-group-text">minutes</span>
</div>
<small class="text-body-secondary">Cron wakes once a minute, so 1 is as often as anything can run.</small>
<div class="form-text">Cron wakes once a minute, so 1 is as often as anything can run.</div>
</div>
<div class="mb-3" id="cronJobDailyGroup">
@@ -79,7 +79,7 @@ ob_start();
<span class="input-group-text"><i class="fas fa-fw fa-clock"></i></span>
<input type="time" class="form-control" name="daily_at" value="<?= $cron_job_daily_at ?>">
</div>
<small class="text-body-secondary">In ITFlow's time zone<?= !empty($session_timezone) ? ', ' . escapeHtml($session_timezone) : '' ?>. A run missed because the server was off happens when it's back, not a day later.</small>
<div class="form-text">In ITFlow's time zone<?= !empty($session_timezone) ? ', ' . escapeHtml($session_timezone) : '' ?>. A run missed because the server was off happens when it's back, not a day later.</div>
</div>
</div>

View File

@@ -449,7 +449,7 @@ $search_noun = $type_filter ? $asset_type_tabs[$type_filter]['label'] : 'assets'
<i class="fas fa-fw fa-redo me-2"></i>Restore
</button>
<?php if ($can_delete) { ?>
<button class="dropdown-item text-danger fw-bold"
<button class="dropdown-item text-danger fw-bold confirm-link"
type="submit" form="bulkActions" name="bulk_delete_assets">
<i class="fas fa-fw fa-trash me-2"></i>Delete
</button>

View File

@@ -110,7 +110,7 @@ ob_start();
<span class="input-group-text"><i class="fas fa-fw fa-calendar"></i></span>
<input type="date" class="form-control" name="dtf" max="2999-12-31" data-statement-option>
</div>
<small class="text-body-secondary">Leave blank for all history</small>
<div class="form-text">Leave blank for all history</div>
</div>
<div class="col-sm-6 mb-3">
<label class="form-label">To</label>

View File

@@ -181,9 +181,9 @@ ob_start();
<span class="input-group-text"><i class="fas fa-fw fa-dollar-sign"></i></span>
<input type="text" class="form-control" inputmode="decimal" pattern="-?[0-9]*\.?[0-9]{0,2}" name="price" value="<?= number_format($client_rate, 2, '.', '') ?>" required>
</div>
<small class="form-text text-body-secondary">
<div class="form-text">
<?= escapeHtml(ucfirst($client_rate_info['note'])) ?> is <strong><?= billingMoney($client_rate, $session_company_currency); ?></strong> an hour
</small>
</div>
</div>
</div>
</div>

View File

@@ -614,7 +614,7 @@ if (!$service || ($client_url && intval($service['service_client_id']) !== intva
<span>Raised about the service:</span>
<?php foreach ($linked_tickets as $row) { ?>
<span class="itflow-contact-chip"><?= escapeHtml(ticketReference($row)) ?>
<a class="text-body-secondary ms-1" href="post.php?unlink_service_ticket=<?= intval($row['ticket_id']) ?>&service_id=<?= $service_id ?>&csrf_token=<?= $_SESSION['csrf_token'] ?>" title="Not about this service"><i class="fas fa-times"></i></a>
<a class="text-body-secondary ms-1 confirm-link" href="post.php?unlink_service_ticket=<?= intval($row['ticket_id']) ?>&service_id=<?= $service_id ?>&csrf_token=<?= $_SESSION['csrf_token'] ?>" title="Not about this service"><i class="fas fa-times"></i></a>
</span>
<?php } ?>
</div>

View File

@@ -1577,7 +1577,7 @@ if (isset($_GET['ticket_id'])) {
<div class="d-flex align-items-start gap-2">
<div class="text-truncate flex-grow-1"><?= ticketLink($other) ?></div>
<?php if ($can_edit_ticket && (!intval($other['ticket_client_id']) || hasClientAccess($other['ticket_client_id']))) { ?>
<a class="text-body-secondary" href="post.php?unlink_ticket=<?= $other_id ?>&amp;csrf_token=<?= $_SESSION['csrf_token'] ?>" title="No longer related"><i class="fas fa-times"></i></a>
<a class="text-body-secondary confirm-link" href="post.php?unlink_ticket=<?= $other_id ?>&amp;csrf_token=<?= $_SESSION['csrf_token'] ?>" title="No longer related"><i class="fas fa-times"></i></a>
<?php } ?>
</div>
<div class="d-flex align-items-center gap-2 mt-1 text-body-secondary">

View File

@@ -376,7 +376,7 @@ function credentialTableHtml(array $rows, array $options = []) {
$actions .= '<a class="dropdown-item" href="' . escapeHtml($unlink_url) . '"><i class="fas fa-fw fa-unlink text-secondary me-2"></i>Unlink</a>';
}
if ($can_edit && !$archived) {
$actions .= '<a class="dropdown-item text-danger confirm-link" href="post.php?archive_credential=' . $id . '&amp;csrf_token=' . escapeHtml($csrf) . '"><i class="fas fa-fw fa-archive me-2"></i>Archive</a>';
$actions .= '<a class="dropdown-item text-danger" href="post.php?archive_credential=' . $id . '&amp;csrf_token=' . escapeHtml($csrf) . '"><i class="fas fa-fw fa-archive me-2"></i>Archive</a>';
}
$html .= '<td class="text-end"><div class="dropdown dropstart"><button class="btn btn-sm btn-light" title="More actions" type="button" data-bs-toggle="dropdown"><i class="fas fa-fw fa-ellipsis-v"></i></button>'
. '<div class="dropdown-menu">' . $actions . '</div></div></td></tr>';