AS1024/itflow
1
0
Fork 0
mirror of https://github.com/itflow-org/itflow synced 2026-09-01 12:25:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add Chevron to show top client collapse

Browse Source
This commit is contained in:
johnnyq
2026-08-29 00:46:30 -04:00
parent 087c75f3d7
commit f6e03b2196
3 changed files with 73 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
agent/includes/inc_client_top_head.php
View File

@@ -1,9 +1,19 @@
<?php $show_add_credit = 0; // Remove once credits is added hides the button ?>
<?php
/*
* #clientHeader starts open on the client overview and closed everywhere else.
* The flag is worked out once because the disclosure chevron needs it too:
* Bootstrap only writes aria-expanded onto a data-api trigger after the first
* click, so without seeding it here the chevron points the wrong way until
* something is clicked.
*/
$client_header_open = basename($_SERVER["PHP_SELF"]) == "client_overview.php";
?>
<div class="card mb-3 d-print-none">
<div class="card-header pb-1 pt-2 px-3">
<div class="card-title">
<a href="#" data-bs-toggle="collapse" data-bs-target="#clientHeader"><h4 class="text-dark" data-bs-toggle="tooltip" data-bs-placement="right" title="Client ID: <?= $client_id ?>"><strong><?= $client_name ?></strong> <?php if ($client_archived_at) { echo "(archived)"; } ?></h4></a>
<a href="#" class="client-header-toggle<?= $client_header_open ? '' : ' collapsed' ?>" data-bs-toggle="collapse" data-bs-target="#clientHeader" aria-controls="clientHeader" aria-expanded="<?= $client_header_open ? 'true' : 'false' ?>"><h4 class="text-dark" data-bs-toggle="tooltip" data-bs-placement="right" title="Client ID: <?= $client_id ?>"><i class="fas fa-fw fa-chevron-right client-header-chevron" aria-hidden="true"></i><strong><?= $client_name ?></strong> <?php if ($client_archived_at) { echo "(archived)"; } ?></h4></a>
</div>
<?php if (!empty($client_tag_name_display_array)) { ?><div class="card-title ms-2"><?= $client_tags_display ?></div> <?php } ?>
<?php if (lookupUserPermission("module_client") >= 2) { ?>
@@ -64,7 +74,7 @@
</div>
</div>
<div class="collapse <?php if (basename($_SERVER["PHP_SELF"]) == "client_overview.php") { echo "show"; } ?>" id="clientHeader">
<div class="collapse<?= $client_header_open ? ' show' : '' ?>" id="clientHeader">
<div class="card-group mb-3">
<div class="card card-body px-3 py-2">

23
css/itflow_custom.css
View File

@@ -1532,3 +1532,26 @@ html {
max-width: 100%;
}
/* Client header disclosure - agent/includes/inc_client_top_head.php
The client name is the collapse trigger for #clientHeader, but links carry no
underline in this app and the h4 is text-dark, so nothing said the heading was
clickable or that a panel was folded behind it. Bootstrap maintains
aria-expanded on the trigger itself, so the chevron reads the real state
rather than a second copy of it kept somewhere in JS. */
.client-header-chevron {
font-size: .7em;
margin-right: .25rem;
vertical-align: middle;
color: var(--bs-secondary-color);
transition: transform .15s ease-in-out;
}
.client-header-toggle:hover .client-header-chevron {
color: var(--bs-body-color);
}
.client-header-toggle[aria-expanded="true"] .client-header-chevron {
transform: rotate(90deg);
}

50
js/app.js
View File

@@ -588,23 +588,49 @@ function itflowInit() {
}
});
// Password reveal. Replaces Show-Hide-Passwords-Bootstrap-4, which has no
// Bootstrap 5 release. Same data-toggle="password" contract as before.
document.querySelectorAll('[data-toggle="password"]').forEach(function (btn) {
btn.addEventListener('click', function () {
var group = btn.closest('.input-group');
var input = group && group.querySelector('input');
if (!input) {
// Password reveal. Replaces Show-Hide-Passwords-Bootstrap-4, which has no Bootstrap 5
// release. The data-toggle="password" contract stays on the INPUT, which is where all
// 15 call sites write it and where the old plugin expected it - but the plugin built
// its own toggle button, and the click has to land on the eye SPAN beside the field.
// Binding it to the input instead meant the eye did nothing at all, and clicking into
// the field to type your password switched it to type="text" while you typed it.
itflowStep('password-reveal', function () {
document.querySelectorAll('input[data-toggle="password"]').forEach(function (input) {
var group = input.closest('.input-group');
var icon = group && group.querySelector('.fa-eye, .fa-eye-slash');
var toggle = icon && icon.closest('span, button, a');
// includes/modal_footer.php re-executes this file on every ajax modal open, so
// without a marker anything already on the page collects a second handler and
// the next click toggles twice, which looks exactly like nothing happening.
if (!toggle || toggle.dataset.itflowPasswordToggle) {
return;
}
var hidden = input.type === 'password';
input.type = hidden ? 'text' : 'password';
var icon = btn.querySelector('i');
if (icon) {
toggle.dataset.itflowPasswordToggle = '1';
// The eye is a plain <span>, so it needs the role to get a pointer cursor and
// the tabindex to be reachable at all without a mouse.
toggle.setAttribute('role', 'button');
toggle.setAttribute('tabindex', '0');
toggle.setAttribute('aria-pressed', 'false');
toggle.setAttribute('aria-label', 'Show password');
function toggleReveal() {
var hidden = input.type === 'password';
input.type = hidden ? 'text' : 'password';
icon.classList.toggle('fa-eye', !hidden);
icon.classList.toggle('fa-eye-slash', hidden);
toggle.setAttribute('aria-pressed', hidden ? 'true' : 'false');
toggle.setAttribute('aria-label', hidden ? 'Hide password' : 'Show password');
}
btn.setAttribute('aria-pressed', hidden ? 'true' : 'false');
toggle.addEventListener('click', toggleReveal);
toggle.addEventListener('keydown', function (e) {
if (e.key === 'Enter' || e.key === ' ') {
e.preventDefault();
toggleReveal();
}
});
});
});