Commit Graph

4365 Commits

Author SHA1 Message Date
mundry d90987a09c chore: add missing CSS dependency jQuery UI 2022-11-14 20:42:58 -08:00
Frédéric Guillot 8bf55d1307 Update ChangeLog 2022-11-12 17:41:51 -08:00
Frédéric Guillot 63f3216447 Update German translation 2022-11-12 17:08:51 -08:00
Frédéric Guillot 2b4e02c974 Fix incorrect placeholder in documentation link 2022-11-12 17:08:02 -08:00
Frédéric Guillot eda5ba2308 Do not run unit tests on each push 2022-11-12 16:44:34 -08:00
Frédéric Guillot ba2200866d Add OpenContainers labels to Dockerfile 2022-11-12 14:58:04 -08:00
Frédéric Guillot 80c073432f Update links to the new documentation website 2022-11-12 11:49:19 -08:00
dependabot[bot] a376ffbe53 build(deps-dev): bump phpunit/phpunit from 9.5.25 to 9.5.26
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 9.5.25 to 9.5.26.
- [Release notes](https://github.com/sebastianbergmann/phpunit/releases)
- [Changelog](https://github.com/sebastianbergmann/phpunit/blob/main/ChangeLog-9.5.md)
- [Commits](https://github.com/sebastianbergmann/phpunit/compare/9.5.25...9.5.26)

---
updated-dependencies:
- dependency-name: phpunit/phpunit
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-30 09:50:16 -07:00
Frédéric Guillot 3a61060047 Keep GitHub Actions up to date 2022-10-29 21:39:55 -07:00
Joe Nahmias fc31da6bda run unit tests on push 2022-10-29 21:11:15 -07:00
Joe Nahmias 8e2f85926c run unit tests for MSSQL via GitHub Actions 2022-10-29 21:11:15 -07:00
Joe Nahmias 8b550ff552 tests(odbc): skip ProjectModelTest::testCreationForAllLanguages due to bug in pdo_odbc 2022-10-29 21:11:15 -07:00
Joe Nahmias ab353a3d8f tests: configure unit tests to run on MSSQL [odbc/dblib] 2022-10-29 21:11:15 -07:00
Joe Nahmias 33852e9ea0 feature: add Microsoft SQL Server database support
can be used via the pdo_dblib or pdo_odbc extensions.
requires Microsoft SQL Server 2016 or later.

* add schema/migrations
* add database provider
* add setup check for pdo module needed by selected driver (dblib/odbc)
* add default config doc
2022-10-29 21:11:15 -07:00
Joe Nahmias 338d02a2f6 tests: add test start/end markers to log and dump all SQL at end 2022-10-29 21:11:15 -07:00
Joe Nahmias af4fd62b55 fix(tests): use assertEqualsWithDelta() when checking currency rate
it is stored as a real (float) value, so needs a delta comparison
2022-10-29 21:11:15 -07:00
Joe Nahmias e9f040d1c6 fix(tests): ensure translations are unloaded on error 2022-10-29 21:11:15 -07:00
Joe Nahmias 3df89f9df2 fix(mssql): when updating an object by id, omit the id itself
It is a useless update and id is an identity column in MSSQL,
which is not updatable and throws an error if you try.

This affects the following seven objects (Models):
- Category
- CustomFilter
- Group
- Project
- Subtask
- TaskExternalLink
- User
2022-10-29 18:17:35 -07:00
Joe Nahmias 29df527979 fix(mssql): do not needlessly qualify columns in ProjectRoleRestrictionModel
this allows the ORM to properly escape the rule column
needed on MSSQL as it is a reserved word
2022-10-29 18:17:35 -07:00
Joe Nahmias cf739273d5 fix(mssql): do not needlessly qualify columns in ColumnRestrictionModel
this allows the ORM to properly escape the rule column, as needed on MSSQL
2022-10-29 18:17:35 -07:00
Joe Nahmias 70bc427470 fix(mssql): use picodb ORM for subtask timer query, rather than hardcoded SQL
the hardcoded SQL was failing on MSSQL because 'end' is a reserved keyword
and thus must be escaped
escape identifiers within subtask timer subquery conditions
serialize and interpolate values into text after generation
2022-10-29 18:17:35 -07:00
Joe Nahmias c39932050c fix(mssql): omit ORDER BY in Task WithoutTags & WithGivenTag subqueries
MSSQL does not allow ORDER BY in subquery without TOP or FETCH/LIMIT
2022-10-29 18:17:35 -07:00
Joe Nahmias 81caabbc74 fix: do not hardcode link_id of 'is a milestone of' in TaskFinderModel
instead lookup which link_id was automatically assigned by the databsae
based on the label
2022-10-29 18:17:35 -07:00
Joe Nahmias ee6cdb3565 picodb(mssql): support all MSSQL pdo drivers
For MSSQL make all connection attributes optional.
Handle differing DB connection params based on driver used.
connection can be made via ODBC DSN or server/hostname
username/password can be embedded in DSN definition or simply
omitted and single-signon will be attempted.
2022-10-23 16:19:50 -07:00
Joe Nahmias bb7f8b4621 picodb(mssql): recognize 2627 and 23000 as dup key errors 2022-10-23 16:19:50 -07:00
Joe Nahmias 104f492301 picodb(mssql): fix retrieval of DB version on MSSQL 2022-10-23 16:19:50 -07:00
Joe Nahmias 66d55e5be0 picodb(mssql): fix implementation of getLastId() on MSSQL 2022-10-23 16:19:50 -07:00
Joe Nahmias 37bc859df5 picodb(mssql): teach picodb to use TOP for limits on MSSQL 2022-10-23 16:19:50 -07:00
Joe Nahmias 5493c2997e picodb(mssql): fix disable/enable foreign keys by removing GO 2022-10-23 16:19:50 -07:00
Joe Nahmias 0047efe803 picodb(mssql): fix conditional creation of schema table 2022-10-23 16:19:50 -07:00
Joe Nahmias 55c80aa090 picodb(mssql): escape closing brackets within identifiers
Ref: https://docs.microsoft.com/en-us/sql/t-sql/functions/quotename-transact-sql
2022-10-23 16:19:50 -07:00
Joe Nahmias 427abb9961 picodb: include error code in SQLException error message 2022-10-23 16:19:50 -07:00
Joe Nahmias 64f589f759 picodb: Table::buildSelectQuery() should default columns to current table 2022-10-23 16:19:50 -07:00
Joe Nahmias e3b9b2ce8f picodb: when logging SQL, include params as well 2022-10-23 16:19:50 -07:00
Joe Nahmias bff5c15544 fix(picodb): do not include useless OFFSET 0 clauses
throws an error on MSSQL
2022-10-23 16:19:50 -07:00
Christoph Reiter 0b8a270bbb tests: port assertEquals() with delta to assertEqualsWithDelta()
assertEquals() in phpunit 9.5 no longer takes a delta parameter
and has assertEqualsWithDelta() as a replacement. This means
float get compared without a delta atm, and a recent phpunit
release (9.5.25) has made float comparisons stricter resulting in
test suite errors such as:

1) SubtaskTimeTrackingModelTest::testCalculateSubtaskTime
Total spent
Failed asserting that 3.3000000000000003 matches expected 3.3.
tests/units/Model/SubtaskTimeTrackingModelTest.php:186

This replaces all assertEquals() calls that pass a delta value
with assertEqualsWithDelta().
2022-10-10 18:57:22 -07:00
Frédéric Guillot 2d4ee932da Update ChangeLog 2022-10-09 15:55:33 -07:00
Frédéric Guillot 669b5c7e2e Avoid deprecation warning when the task description is null 2022-10-09 15:44:25 -07:00
greyaz 1664f4c304
Update zh_CN translations 2022-10-09 15:17:10 -07:00
dependabot[bot] a1bdca646a Bump symfony/stopwatch from 5.4.5 to 5.4.13
Bumps [symfony/stopwatch](https://github.com/symfony/stopwatch) from 5.4.5 to 5.4.13.
- [Release notes](https://github.com/symfony/stopwatch/releases)
- [Changelog](https://github.com/symfony/stopwatch/blob/6.1/CHANGELOG.md)
- [Commits](https://github.com/symfony/stopwatch/compare/v5.4.5...v5.4.13)

---
updated-dependencies:
- dependency-name: symfony/stopwatch
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-03 17:42:07 -07:00
Frédéric Guillot bc673cf6dc Set explicitly the time picker control to select 2022-09-28 20:55:29 -07:00
Frédéric Guillot 11edef20d2 No internal link creation on subtask to task conversion if language is not English 2022-09-28 20:28:16 -07:00
Marco van Duijvenbode 55a3b242bf
Move version.txt to app folder 2022-09-28 19:42:35 -07:00
dependabot[bot] c6b5f4ac5f Bump phpunit/phpunit from 9.5.24 to 9.5.25
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 9.5.24 to 9.5.25.
- [Release notes](https://github.com/sebastianbergmann/phpunit/releases)
- [Changelog](https://github.com/sebastianbergmann/phpunit/blob/main/ChangeLog-9.5.md)
- [Commits](https://github.com/sebastianbergmann/phpunit/compare/9.5.24...9.5.25)

---
updated-dependencies:
- dependency-name: phpunit/phpunit
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-09-26 16:09:39 -07:00
greyaz 8443f60748 Update translations.php
some translations of colors are wrong
2022-09-21 17:33:08 -07:00
irdc 4b76bc5b32
Use a HMAC to sign and validate CSRF tokens, instead of generating random ones and storing them in the session data
* Use a HMAC to sign and validate CSRF tokens, instead of generating random
ones and storing them in the session data. Reduces number of writes to
sessions table and fixes kanboard issue #4942.
* Added missing CSRF check for starting/stopping subtask timers.

Co-authored-by: Willemijn Coene <willemijn@irdc.nl>
2022-09-17 17:23:41 -07:00
Frédéric Guillot f68996b9c7 Remove assertion to avoid flaky test 2022-09-16 18:08:32 -07:00
Pascal Rigaux 829c47ee60 fix re-opening dropdown-menu
This fixes the following case:

1. open the dropdown menu of a "Filename"
2. click elsewhere on the page to close the dropdown menu
   (or click on a submenu element)
3. try to open the same dropdown menu => it fails the first time (since it does not have the "dropdown-menu" class)
2022-09-16 18:05:53 -07:00
greyaz edf31ab20b Update TaskAssignDueDateOnMoveColumn.php 2022-09-15 21:08:59 -07:00
greyaz b7761b05e1 More precise zh_CN translations 2022-09-15 20:30:50 -07:00