Bump Version and Changelog

This commit is contained in:
johnnyq
2026-11-11 12:59:23 -05:00
parent feb068f16c
commit 6d7ec51723
2 changed files with 22 additions and 10 deletions

View File

@@ -2,17 +2,17 @@
This file documents all notable changes made to ITFlow.
## [26.11.5]
## [26.11.6]
### Upgrading
Update from Maintenance > Update — Queue Update hands the job to cron, which updates the files and applies this release's one database change (3.6.2 to 3.6.3) in the same pass. Nothing else is required. From 26.11.3 or earlier, the same update also brings 26.11.4 and its database changes - see its notes below. Nobody needs to clear their browser's cache afterwards.
Update from Maintenance > Update — Queue Update hands the job to cron, which updates the files and applies this release's one database change (3.6.2 to 3.6.3) in the same pass. Nothing else is required. This release has three security fixes - see Security. From 26.11.3 or earlier, the same update also brings 26.11.4 and its database changes - see its notes below.
### Security
- API: a key whose user has Full access to Clients could read anything in the database - other clients' records, users and their password hashes - whatever that user's role and client access allow. Deleting a client through the API (`clients/delete`) wrote the client's name into the audit log as it was, so a client given a name made for the purpose ran a database query when it was deleted. Every release from 26.09 to 26.11.4 is affected, and there is nothing to do after updating. The audit log, notifications, and the ticket and invoice histories now take any text safely, wherever in ITFlow it comes from.
- Sign-in: the lockout after 15 failed sign-ins in 10 minutes, and the limit of 5 wrong two-step codes, could be got around. A request whose browser identification (its User-Agent) was longer than 250 characters failed to write to the audit log, and both limits count what the log holds - so failed sign-ins sent that way were never counted, never showed in Admin > Sign-ins and never alerted anyone. Anything an agent or an API key did from such a browser went unlogged as well, and ended on an error page although it had been done. Everything is logged now whatever the browser sends, with a long identification cut to fit. Every release up to 26.11.4 is affected.
- Invoices: Charge Saved Card could charge a different client's card. The window only ever listed the cards of the invoice's own client, but an agent who can take payments could send the request with another client's saved card in its place - a client they have no access to included. That client's card was charged, and the payment recorded on the invoice it was sent for. Only a card on file for the invoice's client is accepted now, and only while its payment provider is turned on. Every release up to 26.11.4 is affected. In Stripe, a payment made this way shows one client as the customer and names another in its description.
- API: a key whose user has Full access to Clients could read anything in the database - other clients' records, users and their password hashes - whatever that user's role and client access allow. Deleting a client through the API (`clients/delete`) wrote the client's name into the audit log as it was, so a client given a name made for the purpose ran a database query when it was deleted. Every release from 26.09 to 26.11.5 is affected, and there is nothing to do after updating. The audit log, notifications, and the ticket and invoice histories now take any text safely, wherever in ITFlow it comes from.
- Sign-in: the lockout after 15 failed sign-ins in 10 minutes, and the limit of 5 wrong two-step codes, could be got around. A request whose browser identification (its User-Agent) was longer than 250 characters failed to write to the audit log, and both limits count what the log holds - so failed sign-ins sent that way were never counted, never showed in Admin > Sign-ins and never alerted anyone. Anything an agent or an API key did from such a browser went unlogged as well, and ended on an error page although it had been done. Everything is logged now whatever the browser sends, with a long identification cut to fit. Every release up to 26.11.5 is affected.
- Invoices: Charge Saved Card could charge a different client's card. The window only ever listed the cards of the invoice's own client, but an agent who can take payments could send the request with another client's saved card in its place - a client they have no access to included. That client's card was charged, and the payment recorded on the invoice it was sent for. Only a card on file for the invoice's client is accepted now, and only while its payment provider is turned on. Every release up to 26.11.5 is affected. In Stripe, a payment made this way shows one client as the customer and names another in its description.
### New Features & Updates
@@ -20,7 +20,6 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u
### Bug Fixes
- Updates: after an update, pages could act up - menus, buttons, editors and forms not working, or pages looking half old and half new - until each person cleared their browser's cache, and sometimes closed the browser and cleared it again. Browsers kept the copies of ITFlow's scripts and stylesheets from before the update and went on using them with the new pages, for days or weeks. Each one is now asked for by an address that changes when the file does, so after an update browsers fetch what changed straight away and keep using what didn't. This starts with this update: nobody needs to clear their cache for it.
- Contract Templates: on an install updated in 25.11, adding a contract template could fail with "Field 'company_id' doesn't have a default value", and Maintenance > Debug listed `contract_templates.company_id` as an extra column. 25.11's update gave the table a column nothing used, and no later update took it away. This update removes it. Installs set up or updated after 25.11 never had it.
- Contracts: in Safari, New Contract opened from the Contracts page listed every client's contacts under Contact at the client, whichever client was picked. The list now holds only the contacts of the client picked, in every browser, with its primary contact picked.
- Contracts: the contract windows use the same pickers as the rest of ITFlow. Contacts and owners show with their picture or initials and their title, and templates, types, terms, SLAs and categories open as the searchable list used everywhere else - in New, Edit and Copy Contract, sending one to be signed, adding hours, its recurring invoice, and Admin > Contract Templates.
@@ -31,9 +30,6 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u
### Developer Updates
- `staticFileUrl($path)` in `functions/app.php` returns `$path?v=` and the file's `filemtime()`, or the path as it is when the file isn't there. Every `<script src>` and `<link href>` to a file in ITFlow - `libs/` included - goes through it, and those that were relative to the page (`libs/...`, `../js/...`, `css/ticket.css`) are now from the site root. ITFlow sends no caching headers for static files, so browsers used heuristic freshness - a share of the time since the file last changed - and reused old copies without asking. `.htaccess` and server configuration are unchanged. New tags must use it (CONTRIBUTING.md).
- `js/tinymce_defaults.js`, loaded straight after `tinymce.min.js` in `includes/footer.php` and `client/includes/footer.php`, sets TinyMCE's `cache_suffix` through `tinymce.overrideDefaults()` to the `?v=` of `tinymce.min.js`'s own tag, so the plugins, theme, icons, model and skins TinyMCE fetches by itself are versioned too. A file, not an inline script, as the portal's pages with `Content-Security-Policy: default-src 'self'` allow no inline scripts.
- `agent/ticket.php` loads `agent/js/ticket_collision_detection.js` only when a ticket is shown (`isset($ticket_is_open)`). On Nothing to see here it found no `#ticket_id` and threw.
- Database 3.6.3 (`admin/database_updates/3.6.3.php`) drops `contract_templates.company_id` where it exists. The 2.3.7 migration shipped in v25.11 creating it as `INT NOT NULL` with no default, so strict SQL mode - MariaDB's default - refused any insert that didn't set it; `abb97ad99` then took it out of the migration, which an install that had already run 2.3.7 never runs again. A database from v25.10 upgraded through v25.11's 2.3.7 and every migration since now matches a fresh `db.sql` in every table and column. The one difference left is the name of the index behind `contracts_ibfk_1` on `contract_client_id` - `contracts_ibfk_1` there, `contract_client_id` in `db.sql` - the same index, left as it is.
- `js/contract_form.js` no longer hides other clients' contacts with `option.hidden`: WebKit ignores `hidden` on an `<option>` (https://bugs.webkit.org/show_bug.cgi?id=255335), and the picker doesn't read it either. `agent/modals/contract/contract_form.php` now renders only the contacts of the contract's client, and with no client yet the list is filled from `ajax.php?get_client_contacts` when one is picked, as the project and ticket forms do - it used to put every client's contacts in the page. Every `<select>` in `agent/modals/contract/` and `admin/modals/contract_template/` is a `select2` picker with the usual option extras (`selectOptionContact()`, `selectOptionUser()`, `selectOptionData()`), except `frequency` and `tax_id` in `contract_recurring.php`, plain as they are in `billing_form.php`.
- `admin/users.php` has a `portal` view (`?show=portal`) with its own query, sort columns, filters (`client`, `access`) and table, as Invited has, and the search now applies to the side being looked at - agents or portal users - without changing the other side's counts. Its handlers are in `admin/post/portal_users.php`: `portal_user_reset_link`, `portal_user_invite`, `portal_user_reset_mfa`, `portal_user_forget_browsers`, `portal_user_access_off`, `portal_user_access_on` (from `admin/modals/portal_user/portal_user_access.php`), and `bulk_portal_reset_links`, `bulk_portal_reset_mfa` and `bulk_portal_access_off` over `user_ids[]` - each in the audit log as a Contact edit against the contact. New in `functions/portal.php`: `PORTAL_USER_ON_SQL`, `portalUserRow()`, `portalUserOffWhy()`, `portalLastSignIns()`, `portalUserAccessOff()` and `portalUserAccessOn()`. Access off is `user_auth_method = ''`, as the contact form and the portal's People page set it; `portalContactAccessOff()` in `client/functions.php` now goes through `portalUserAccessOff()`, which also deletes the user's `remember_tokens`.
@@ -45,6 +41,22 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u
- `add_payment_stripe` (`agent/post/payment.php`) looks the card up with `saved_payment_client_id = $client_id AND payment_provider_active = 1`, as `agent/modals/payment/payment_saved_method_add.php` lists them, and stops with a message when there is no such row. It took `saved_payment_id` alone, after `enforceClientAccess()` on the invoice's client only. Its join to `client_payment_provider` is on the card's provider as well as its client. The other lookups by `saved_payment_id` were already tied to the client: `set_recurring_payment` for agents and in the portal, the portal's `delete_saved_payment`, `billingStripeChargeSaved()`, and autopay in `cron/nightly_tasks.php`.
- `js/tinymce_defaults.js` puts a `paste` handler on every editor (`tinymce.on('AddEditor')`, ahead of TinyMCE's own). TinyMCE pastes an image file only when the clipboard has no `text/html` or `text/plain`, and Copy image puts both the bitmap and an `<img src="https://...">` there, so the HTML won. When the clipboard holds exactly one image file and its HTML is a single `<img>` with no text or other content, the handler cancels the paste and dispatches a `paste` whose `DataTransfer` holds only the file, which TinyMCE inserts as it does a screenshot. Nothing is fetched, by the browser or the server; HTML with text in it is left to TinyMCE as before.
## [26.11.5]
### Upgrading
Update from Maintenance > Update — Queue Update hands the job to cron and it applies on its own. There is no database change in this release, so nothing else is required. From 26.11.3 or earlier, the same update also brings 26.11.4 and its database changes - see its notes below. Nobody needs to clear their browser's cache afterwards.
### Bug Fixes
- Updates: after an update, pages could act up - menus, buttons, editors and forms not working, or pages looking half old and half new - until each person cleared their browser's cache, and sometimes closed the browser and cleared it again. Browsers kept the copies of ITFlow's scripts and stylesheets from before the update and went on using them with the new pages, for days or weeks. Each one is now asked for by an address that changes when the file does, so after an update browsers fetch what changed straight away and keep using what didn't. This starts with this update: nobody needs to clear their cache for it.
### Developer Updates
- `staticFileUrl($path)` in `functions/app.php` returns `$path?v=` and the file's `filemtime()`, or the path as it is when the file isn't there. Every `<script src>` and `<link href>` to a file in ITFlow - `libs/` included - goes through it, and those that were relative to the page (`libs/...`, `../js/...`, `css/ticket.css`) are now from the site root. ITFlow sends no caching headers for static files, so browsers used heuristic freshness - a share of the time since the file last changed - and reused old copies without asking. `.htaccess` and server configuration are unchanged. New tags must use it (CONTRIBUTING.md).
- `js/tinymce_defaults.js`, loaded straight after `tinymce.min.js` in `includes/footer.php` and `client/includes/footer.php`, sets TinyMCE's `cache_suffix` through `tinymce.overrideDefaults()` to the `?v=` of `tinymce.min.js`'s own tag, so the plugins, theme, icons, model and skins TinyMCE fetches by itself are versioned too. A file, not an inline script, as the portal's pages with `Content-Security-Policy: default-src 'self'` allow no inline scripts.
- `agent/ticket.php` loads `agent/js/ticket_collision_detection.js` only when a ticket is shown (`isset($ticket_is_open)`). On Nothing to see here it found no `#ticket_id` and threw.
## [26.11.4]
### Upgrading

View File

@@ -5,4 +5,4 @@
* Update this file each time we merge develop into master. Format is YY.MM (add a .v if there is more than one release a month.
*/
DEFINE("APP_VERSION", "26.11.5");
DEFINE("APP_VERSION", "26.11.6");