QoL 65: fields marked with an asterisk are required and required fields are marked, a bulk asset move needs a client picked instead of moving them to no client, field hints use form-text everywhere, and the credit message is in sentence case

This commit is contained in:
johnnyq
2026-11-21 02:42:52 -05:00
parent 2e2cbea773
commit fba791c2fd
40 changed files with 66 additions and 60 deletions

View File

@@ -232,6 +232,7 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u
- Screen readers: every window's close button is read out as Close, and the arrow beside a list's New button and the ⋮ menus on record pages as More actions, rather than as a button with no name or just More.
- Counts: the counts in menus, tabs, list headers and under every list - Showing 1 to 25 of 1,834 records - have a thousands separator, as the dashboard, reports and audit log already did.
- Confirmations: archiving a credential from an asset, contact, vendor, service or license page no longer asks first, as archiving anywhere else doesn't - the message's Undo puts it back. Taking a related ticket off a ticket, or a ticket off a service's page, asks first, as the ticket page's other × buttons do. Hints under a few fields - a statement's From, a cron job's schedule, a quote's price per hour - look like every other field's.
- Required fields: every field marked * has to be filled in before the window saves, and every field that has to be filled in is marked * - a few had one without the other, such as a credit's note, the comment when merging several tickets, and the dates when activating, renewing or ending a contract. Hints under fields look the same in every window.
### Bug Fixes
@@ -296,6 +297,7 @@ Update from Maintenance > Update — Queue Update hands the job to cron, which u
- Payments: editing a payment said "Payment edited to amount ... added" in your company's currency rather than the payment's, and its audit log entry didn't say who edited it or which client it was for.
- Invoice links: asking to pay by card when card payments weren't set up went to a page that doesn't exist. It goes back to the invoice and says card payments are not set up.
- Assets: Bulk Action > Delete deleted the ticked assets straight away, without asking first as every other list's Delete does.
- Assets: moving the ticked assets to another client with no client picked moved them to no client at all. It now asks for the client.
### Developer Updates

View File

@@ -112,7 +112,7 @@ $c_max = $c_config['max'] ?? 200;
<div class="small text-secondary p-2" data-category-icon-none hidden>No icon by that name here - type its whole name to use it</div>
</div>
<?php if ($kind === 'asset_status') { ?>
<small class="text-secondary">Asset statuses show as a badge in their color - the icon shows in the status picker.</small>
<div class="form-text">Asset statuses show as a badge in their color - the icon shows in the status picker.</div>
<?php } ?>
</div>
</div>

View File

@@ -158,7 +158,7 @@ $tab = 'templateTab' . bin2hex(random_bytes(3));
</select>
</div>
<?php } ?>
<small class="text-secondary">From Admin > SLAs. While the contract is in force, the client's new tickets get them, and the default for a priority left on the default.</small>
<div class="form-text">From Admin > SLAs. While the contract is in force, the client's new tickets get them, and the default for a priority left on the default.</div>
</div>
<div class="tab-pane fade" id="<?= $tab ?>Terms" role="tabpanel">

View File

@@ -45,7 +45,7 @@ $ai_model = aiReady('Documentation') ? getAiModel('Documentation') : null;
<input type="text" class="form-control" id="documentTemplatePrompt" placeholder="What it is for - a network troubleshooting guide for junior technicians" data-document-template-prompt>
<button class="btn btn-info" type="button" data-document-template-generate><i class="fas fa-fw fa-magic me-1"></i>Draft</button>
</div>
<small class="text-secondary">Replaces what is in the editor below.</small>
<div class="form-text">Replaces what is in the editor below.</div>
</div>
<?php } ?>

View File

@@ -67,7 +67,7 @@ if (!$template || $template['document_template_archived_at']) { ?>
<input type="text" class="form-control" name="description" placeholder="<?= escapeHtml($template['document_template_description'] ?: 'One line on what it covers') ?>" maxlength="500">
</div>
</div>
<small class="text-secondary">It goes in the client's Files at the top level, and opens to fill in.</small>
<div class="form-text">It goes in the client's Files at the top level, and opens to fill in.</div>
</div>
<div class="modal-footer">
<button type="submit" name="add_document_from_template" class="btn btn-primary fw-bold"><i class="fas fa-check me-2"></i>Create</button>

View File

@@ -84,7 +84,7 @@ if (!$template || $template['document_template_archived_at']) { ?>
</div>
<?php } ?>
<small class="text-secondary">Each goes in its client's Files at the top level, named and summed up as the template is.</small>
<div class="form-text">Each goes in its client's Files at the top level, named and summed up as the template is.</div>
</div>
<div class="modal-footer">
<button type="submit" name="make_documents_from_template" class="btn btn-primary fw-bold"><i class="fas fa-check me-2"></i>Create</button>

View File

@@ -50,7 +50,7 @@ if (!$payment_method) { ?>
<?php } ?>
</select>
</div>
<small class="text-secondary">Merges <?= $name ?> into the method you pick<?= $is_default ? ', which also takes its place as a default' : '' ?>. To leave its records as they are, archive it instead - it stops being offered, and they keep saying <?= $name ?>.</small>
<div class="form-text">Merges <?= $name ?> into the method you pick<?= $is_default ? ', which also takes its place as a default' : '' ?>. To leave its records as they are, archive it instead - it stops being offered, and they keep saying <?= $name ?>.</div>
</div>
<?php } else { ?>
<p class="mb-2">Nothing has been paid this way, so nothing else changes.</p>

View File

@@ -24,9 +24,9 @@ $m_usage = $m ? paymentMethodUsageFor($m_name) : ['total' => 0];
<input type="text" class="form-control" name="name" maxlength="200" placeholder="Check, ACH, Cash, Company Amex" value="<?= escapeHtml($m_name) ?>" required<?= $m_online ? ' readonly' : ($m ? '' : ' autofocus') ?>>
</div>
<?php if ($m_online) { ?>
<small class="text-secondary"><i class="fas fa-fw fa-lock me-1"></i>Card payments clients make online are recorded as <?= escapeHtml(PAYMENT_METHOD_ONLINE) ?>, so its name stays.</small>
<div class="form-text"><i class="fas fa-fw fa-lock me-1"></i>Card payments clients make online are recorded as <?= escapeHtml(PAYMENT_METHOD_ONLINE) ?>, so its name stays.</div>
<?php } elseif ($m && $m_usage['total']) { ?>
<small class="text-secondary">Renaming it renames it on the <?= escapeHtml(paymentMethodUsageText($m_usage)) ?> that used it.</small>
<div class="form-text">Renaming it renames it on the <?= escapeHtml(paymentMethodUsageText($m_usage)) ?> that used it.</div>
<?php } ?>
</div>
@@ -48,5 +48,5 @@ $m_usage = $m ? paymentMethodUsageFor($m_name) : ['total' => 0];
<?php } ?>
</select>
</div>
<small class="text-secondary">Which pickers offer it - money in is payments from clients and other income; money out is expenses, recurring expenses, reimbursements and mileage claims. Transfers between accounts offer every method.</small>
<div class="form-text">Which pickers offer it - money in is payments from clients and other income; money out is expenses, recurring expenses, reimbursements and mileage claims. Transfers between accounts offer every method.</div>
</div>

View File

@@ -46,11 +46,11 @@ ob_start();
<span class="input-group-text"><i class="fas fa-fw fa-calendar-alt"></i></span>
<input type="number" class="form-control" name="holiday_year" min="2000" max="2100" step="1" value="<?= $offer_year ?>" required autofocus>
</div>
<small class="text-secondary">
<div class="form-text">
<?php foreach ($years as $year => [$in, $total]) { ?>
<span class="d-block"><?= $year ?> - <?= $in === $total ? "all $total are in" : ($in ? "$in of $total are in" : 'none are in yet') ?></span>
<?php } ?>
</small>
</div>
</div>
<div class="small text-secondary"><i class="fas fa-fw fa-stopwatch me-1"></i>A day already on the list is left as it is, name and all. Adding them works the targets out again on every ticket with an SLA that isn't closed yet.</div>

View File

@@ -52,7 +52,7 @@ $f_day_minutes = slaBusinessDayMinutes();
<input type="number" class="form-control" name="response_minutes" min="0" max="59" step="1" placeholder="0" value="<?= $f_minutes($f_response) ?>" aria-label="Response target, minutes">
<span class="input-group-text">minutes</span>
</div>
<small class="text-secondary">How long there is to first reply to a new ticket.</small>
<div class="form-text">How long there is to first reply to a new ticket.</div>
</div>
<div class="mb-3">
@@ -64,7 +64,7 @@ $f_day_minutes = slaBusinessDayMinutes();
<input type="number" class="form-control" name="resolution_minutes" min="0" max="59" step="1" placeholder="0" value="<?= $f_minutes($f_resolution) ?>" aria-label="Resolution target, minutes">
<span class="input-group-text">minutes</span>
</div>
<small class="text-secondary">How long there is to resolve it. Leave both empty for an SLA that only times the first reply.</small>
<div class="form-text">How long there is to resolve it. Leave both empty for an SLA that only times the first reply.</div>
</div>
<div class="small text-secondary mb-1">

View File

@@ -56,7 +56,7 @@ if (!in_array($t_icon, $t_icons, true)) {
</select>
</div>
<?php if ($t_kind_locked) { ?>
<small class="text-secondary">In use, so it stays <?= tagKindPhrase($type) ?></small>
<div class="form-text">In use, so it stays <?= tagKindPhrase($type) ?></div>
<?php } ?>
</div>
</div>
@@ -67,7 +67,7 @@ if (!in_array($t_icon, $t_icons, true)) {
<span class="input-group-text"><i class="fas fa-fw fa-align-left"></i></span>
<input type="text" class="form-control" name="description" maxlength="255" placeholder="What it means, and when to use it" value="<?= escapeHtml($t['tag_description'] ?? '') ?>">
</div>
<small class="text-secondary">Shown on the tag and in the tag picker</small>
<div class="form-text">Shown on the tag and in the tag picker</div>
</div>
<div class="mb-3">

View File

@@ -54,7 +54,7 @@ if (!$tax || $tax['tax_archived_at']) { ?>
<?php } ?>
</select>
</div>
<small class="text-secondary">Left where they are, recurring invoices and drafts keep charging it, products and clients fall back to the next rate along for new lines<?= $usage['default'] ? ', and there is no default until you pick one' : '' ?>.</small>
<div class="form-text">Left where they are, recurring invoices and drafts keep charging it, products and clients fall back to the next rate along for new lines<?= $usage['default'] ? ', and there is no default until you pick one' : '' ?>.</div>
</div>
<?php } ?>
</div>

View File

@@ -71,7 +71,7 @@ $tax_part_row = function ($key, array $part = []) {
<span class="input-group-text"><i class="fas fa-fw fa-id-card"></i></span>
<input type="text" class="form-control" name="registration" maxlength="100" placeholder="Permit, GST/HST or VAT number" value="<?= escapeHtml($t['tax_registration_number'] ?? '') ?>">
</div>
<small class="text-secondary">Printed with this tax on invoices</small>
<div class="form-text">Printed with this tax on invoices</div>
</div>
</div>

View File

@@ -50,7 +50,7 @@ $s_reply_value = $s_reply_to && isset($s_reply_choices["to-$s_reply_to"]) ? "to-
<input type="text" class="form-control" name="name" maxlength="200" placeholder="Waiting on Vendor, Scheduled, Parts Ordered" value="<?= escapeHtml($s_name) ?>" required<?= $s_builtin ? ' readonly' : ($s ? '' : ' autofocus') ?> data-ticket-status-name>
</div>
<?php if ($s_builtin) { ?>
<small class="text-secondary"><i class="fas fa-fw fa-lock me-1"></i>ITFlow's own statuses keep their names. <?= escapeHtml($s_builtin['set_by']) ?></small>
<div class="form-text"><i class="fas fa-fw fa-lock me-1"></i>ITFlow's own statuses keep their names. <?= escapeHtml($s_builtin['set_by']) ?></div>
<?php } ?>
</div>
@@ -60,7 +60,7 @@ $s_reply_value = $s_reply_to && isset($s_reply_choices["to-$s_reply_to"]) ? "to-
<span class="input-group-text"><i class="fas fa-fw fa-align-left"></i></span>
<input type="text" class="form-control" name="description" maxlength="255" placeholder="<?= escapeHtml($s_builtin ? $s_builtin['about'] : 'What it means, and when to use it') ?>" value="<?= escapeHtml($s_description) ?>">
</div>
<small class="text-secondary">Shown when the status is hovered - in the pickers, on the board and on tickets.</small>
<div class="form-text">Shown when the status is hovered - in the pickers, on the board and on tickets.</div>
</div>
<div class="mb-3">
@@ -93,10 +93,10 @@ $s_reply_value = $s_reply_to && isset($s_reply_choices["to-$s_reply_to"]) ? "to-
</select>
<?php } ?>
</div>
<small class="text-secondary">
<div class="form-text">
<?php if ($s_builtin) { ?><i class="fas fa-fw fa-lock me-1"></i>Fixed for ITFlow's own statuses. <?php } ?>
A ticket in a paused status never warns or breaches on resolution - the time already spent is kept, and the deadline moves out when it comes back. The response clock always runs.
</small>
</div>
</div>
<div class="<?= $s_id && !ticketStatusCanBeFirstResponse($s_id) ? 'mb-1' : 'mb-3' ?>">
@@ -113,13 +113,13 @@ $s_reply_value = $s_reply_to && isset($s_reply_choices["to-$s_reply_to"]) ? "to-
</select>
<?php } ?>
</div>
<small class="text-secondary">
<div class="form-text">
<?php if ($s_id === TICKET_STATUS_CLOSED) { ?>
<i class="fas fa-fw fa-lock me-1"></i>A closed ticket takes no replies.
<?php } else { ?>
By email, in the portal or by text. Move it to a status such as "Client responded" to see at a glance which tickets have a new answer; back to Open suits a status that waits on the client<?= $s_builtin ? '' : '; leave it for one like Scheduled, where a "thanks, see you then" shouldn\'t put it back in the queue' ?>. Whoever it is assigned to is told either way.
<?php } ?>
</small>
</div>
</div>
<?php if (ticketStatusReplyReady() && (!$s_id || ticketStatusCanBeFirstResponse($s_id))) { ?>
@@ -133,9 +133,9 @@ $s_reply_value = $s_reply_to && isset($s_reply_choices["to-$s_reply_to"]) ? "to-
<?php } ?>
</select>
</div>
<small class="text-secondary">
<div class="form-text">
An agent moving a ticket into this status before anyone has answered the client meets - or misses - the SLA's response target then: setting it by hand or in a reply, or assigning a new ticket, which moves it to Open. Once per ticket. With the email, the contact and watchers get the "ticket assigned" message from <a href="settings_ticket.php#messages">Settings &gt; Tickets</a>, kept on the ticket as a public note; if nobody could be emailed, it doesn't count.
</small>
</div>
</div>
<?php } ?>
</div>

View File

@@ -65,7 +65,7 @@ if (!$ticket_status || ticketStatusIsBuiltIn($ticket_status['ticket_status_id'])
<?php } ?>
</select>
</div>
<small class="text-secondary">Each says so in its history, and its SLA clock follows the status it goes to.</small>
<div class="form-text">Each says so in its history, and its SLA clock follows the status it goes to.</div>
</div>
<?php } else { ?>
<p class="small text-secondary"><i class="fas fa-fw fa-check me-1"></i>No tickets are in it.</p>

View File

@@ -31,7 +31,7 @@ ob_start();
<label class="form-label">Client <strong class="text-danger">*</strong></label>
<div class="input-group">
<span class="input-group-text"><i class="fas fa-fw fa-users"></i></span>
<select class="form-select select2" name="bulk_client_id">
<select class="form-select select2" name="bulk_client_id" required>
<option value="">- Select a client -</option>
<?php
$clients_sql = mysqli_query($mysqli, "SELECT client_id, client_name, client_abbreviation FROM clients WHERE client_archived_at IS NULL $client_select_query" . clientNotLeadSql() . clientScopeSql('client_id') . " ORDER BY client_name ASC");

View File

@@ -46,14 +46,14 @@ ob_start();
</div>
</div>
<div class="col-md-3 col-6">
<label class="form-label">First number</label>
<label class="form-label">First number <strong class="text-danger">*</strong></label>
<div class="input-group">
<span class="input-group-text"><i class="fas fa-fw fa-hashtag"></i></span>
<input type="number" class="form-control" name="interface_start" min="0" value="<?= $start ?>" required data-series="start">
</div>
</div>
<div class="col-md-4 col-6">
<label class="form-label">How many</label>
<label class="form-label">How many <strong class="text-danger">*</strong></label>
<div class="input-group">
<span class="input-group-text"><i class="fas fa-fw fa-ethernet"></i></span>
<input type="number" class="form-control" name="interfaces" min="1" max="128" value="<?= $count ?>" required data-series="count">

View File

@@ -278,7 +278,7 @@ ob_start();
<input type="checkbox" class="form-check-input" name="reminders" value="1" id="clientRemindersNew" checked>
<label class="form-check-label" for="clientRemindersNew">Payment reminders and statements</label>
</div>
<small class="text-secondary">Emailed as set in Invoice Settings. Off, this client gets neither - invoices can still be sent by hand.</small>
<div class="form-text">Emailed as set in Invoice Settings. Off, this client gets neither - invoices can still be sent by hand.</div>
</div>
<?php

View File

@@ -44,7 +44,7 @@ ob_start();
</div>
<div class="mb-3">
<label class="form-label">From</label>
<label class="form-label">From <strong class="text-danger">*</strong></label>
<div class="input-group">
<span class="input-group-text"><i class="fas fa-fw fa-calendar-day"></i></span>
<input type="date" class="form-control" name="contract_start" value="<?= date('Y-m-d') ?>" required>

View File

@@ -22,7 +22,7 @@ ob_start();
<div class="modal-body">
<div class="mb-3">
<label class="form-label">Industry</label>
<label class="form-label">Industry <strong class="text-danger">*</strong></label>
<div class="input-group">
<span class="input-group-text"><i class="fas fa-fw fa-briefcase"></i></span>
<input type="text" class="form-control" name="bulk_industry" placeholder="Healthcare, Legal, Construction" maxlength="200" required>

View File

@@ -20,11 +20,11 @@ if (billingStripeProvider()) {
<input type="checkbox" class="form-check-input" name="card_fee_exempt" value="1" id="clientCardFeeExempt<?= escapeHtml($ccf_key) ?>"<?= !empty($client_card_fee_exempt) ? ' checked' : '' ?>>
<label class="form-check-label" for="clientCardFeeExempt<?= escapeHtml($ccf_key) ?>">No card fee</label>
</div>
<small class="text-secondary">
<div class="form-text">
<?= $ccf_rates
? 'Clients pay a ' . escapeHtml(billingCardFeeText($ccf_rates)) . ' card fee when they pay by card - this one doesn\'t.'
: 'Clients don\'t pay a card fee now - if they are set to in Admin > Payment Providers, this one won\'t.' ?>
</small>
</div>
</div>
<?php
}

View File

@@ -42,7 +42,7 @@
<label class="form-label">Note <strong class="text-danger">*</strong></label>
<div class="input-group">
<span class="input-group-text"><i class="fas fa-fw fa-file-alt"></i></span>
<input type="text" class="form-control" name="note" placeholder="What the credit is for" maxlength="250">
<input type="text" class="form-control" name="note" placeholder="What the credit is for" maxlength="250" required>
</div>
</div>

View File

@@ -166,7 +166,7 @@ ob_start();
<input type="checkbox" class="form-check-input" name="reminders" value="1" id="clientReminders<?= $client_id ?>" <?= $client_reminders ? 'checked' : '' ?>>
<label class="form-check-label" for="clientReminders<?= $client_id ?>">Payment reminders and statements</label>
</div>
<small class="text-secondary">Emailed as set in Invoice Settings. Off, this client gets neither - invoices can still be sent by hand.</small>
<div class="form-text">Emailed as set in Invoice Settings. Off, this client gets neither - invoices can still be sent by hand.</div>
</div>
<?php

View File

@@ -35,7 +35,7 @@ $ct_expires = (string) ($ct['client_tax_exempt_expires'] ?? '');
<?php } ?>
</select>
</div>
<small class="text-secondary">For new lines on its invoices and quotes - where it is, for sales tax</small>
<div class="form-text">For new lines on its invoices and quotes - where it is, for sales tax</div>
</div>
<div class="mb-2">
@@ -43,7 +43,7 @@ $ct_expires = (string) ($ct['client_tax_exempt_expires'] ?? '');
<input type="checkbox" class="form-check-input" name="tax_exempt" value="1" id="clientTaxExempt<?= $ct_key ?>"<?= !empty($ct['client_tax_exempt']) ? ' checked' : '' ?>>
<label class="form-check-label" for="clientTaxExempt<?= $ct_key ?>">Tax exempt</label>
</div>
<small class="text-secondary">Its new lines get no tax, and its invoices and quotes say it is exempt</small>
<div class="form-text">Its new lines get no tax, and its invoices and quotes say it is exempt</div>
</div>
<div class="row">

View File

@@ -30,15 +30,15 @@ if (!$contract || $contract['contract_status'] !== 'Draft') { ?>
<input type="hidden" name="csrf_token" value="<?= $_SESSION['csrf_token'] ?>">
<input type="hidden" name="contract_id" value="<?= intval($contract['contract_id']) ?>">
<div class="modal-body">
<label class="form-label">In force from</label>
<label class="form-label">In force from <strong class="text-danger">*</strong></label>
<div class="input-group">
<span class="input-group-text"><i class="fas fa-fw fa-calendar-day"></i></span>
<input type="date" class="form-control" name="start_date" value="<?= escapeHtml($start) ?>" required>
</div>
<small class="text-secondary">
<div class="form-text">
<?= $contract['contract_end_date'] ? 'It ends on ' . escapeHtml(date('M j, Y', strtotime($contract['contract_end_date']))) . '.' : 'It runs for ' . escapeHtml(contractTermLabel($contract['contract_term_months'])) . ' from then.' ?>
<?= intval($contract['contract_auto_renew']) ? 'Then it renews itself.' : '' ?>
</small>
</div>
</div>
<div class="modal-footer">
<button type="submit" name="activate_contract" class="btn btn-primary fw-bold"><i class="fas fa-check me-2"></i>Make Active</button>

View File

@@ -40,7 +40,7 @@ if (!$contract || $contract['contract_status'] !== 'Active') { ?>
</p>
<?php } ?>
<div class="mb-3">
<label class="form-label">Last day in force</label>
<label class="form-label">Last day in force <strong class="text-danger">*</strong></label>
<div class="input-group">
<span class="input-group-text"><i class="fas fa-fw fa-calendar-times"></i></span>
<input type="date" class="form-control" name="last_day" value="<?= escapeHtml($last_day) ?>" required>

View File

@@ -115,7 +115,7 @@ $tab = 'contractTab' . bin2hex(random_bytes(3));
<?php } ?>
</select>
</div>
<small class="text-secondary">Fills in the type, term, cover and terms from it - change any of them after.</small>
<div class="form-text">Fills in the type, term, cover and terms from it - change any of them after.</div>
</div>
<?php } else { ?>
<input type="hidden" name="template_id" value="<?= intval($c_value('template_id', 0)) ?>">
@@ -189,7 +189,7 @@ $tab = 'contractTab' . bin2hex(random_bytes(3));
<?php } ?>
</select>
</div>
<small class="text-secondary">Reminded before it renews or ends.</small>
<div class="form-text">Reminded before it renews or ends.</div>
</div>
</div>
@@ -322,7 +322,7 @@ $tab = 'contractTab' . bin2hex(random_bytes(3));
</select>
</div>
<?php } ?>
<small class="text-secondary">From Admin > SLAs. While the contract is in force, the client's new tickets get them, and the default for a priority left on the default.</small>
<div class="form-text">From Admin > SLAs. While the contract is in force, the client's new tickets get them, and the default for a priority left on the default.</div>
</div>
<div class="tab-pane fade" id="<?= $tab ?>Terms" role="tabpanel">
@@ -335,7 +335,7 @@ $tab = 'contractTab' . bin2hex(random_bytes(3));
<span class="input-group-text align-items-start pt-2"><i class="fas fa-fw fa-sticky-note"></i></span>
<textarea class="form-control" name="notes" rows="8" maxlength="10000" placeholder="For your team - what was agreed, who to talk to about renewing"><?= escapeHtml($c_value('notes')) ?></textarea>
</div>
<small class="text-secondary">Only agents see these.</small>
<div class="form-text">Only agents see these.</div>
</div>
</div>
</div>

View File

@@ -88,7 +88,7 @@ if (!$contract || !contractHoursReady() || !($contract['contract_status'] === 'D
<?= categoryOptionsHtml('Income') ?>
</select>
</div>
<small class="text-secondary">One line, at the client's usual tax rate for time<?= $currency !== '' ? ', in ' . escapeHtml($currency) : '' ?>. Send it from the invoice when it is ready.</small>
<div class="form-text">One line, at the client's usual tax rate for time<?= $currency !== '' ? ', in ' . escapeHtml($currency) : '' ?>. Send it from the invoice when it is ready.</div>
<?php } ?>
</div>
<div class="modal-footer">

View File

@@ -39,12 +39,12 @@ if (!$contract || $contract['contract_status'] === 'Draft' || !$contract['contra
It <?= $end >= date('Y-m-d') ? 'ends' : 'ended' ?> on <?= escapeHtml(date('M j, Y', strtotime($end))) ?>.
<?= in_array($contract['contract_status'], ['Ended', 'Cancelled'], true) ? 'Renewing makes it active again.' : '' ?>
</p>
<label class="form-label">New last day</label>
<label class="form-label">New last day <strong class="text-danger">*</strong></label>
<div class="input-group">
<span class="input-group-text"><i class="fas fa-fw fa-calendar-check"></i></span>
<input type="date" class="form-control" name="end_date" value="<?= escapeHtml($new_end) ?>" min="<?= escapeHtml(date('Y-m-d')) ?>" required>
</div>
<small class="text-secondary">Another <?= escapeHtml(contractTermLabel($contract['contract_term_months'])) ?>. Its owner is reminded again before this one ends.</small>
<div class="form-text">Another <?= escapeHtml(contractTermLabel($contract['contract_term_months'])) ?>. Its owner is reminded again before this one ends.</div>
</div>
<div class="modal-footer">
<button type="submit" name="renew_contract" class="btn btn-primary fw-bold"><i class="fas fa-sync-alt me-2"></i>Renew</button>

View File

@@ -76,7 +76,7 @@ ob_start();
</div>
<div class="row g-3" data-add-ticket-lines>
<div class="col-12">
<label class="form-label">Line</label>
<label class="form-label">Line <strong class="text-danger">*</strong></label>
<div class="input-group">
<span class="input-group-text"><i class="fas fa-fw fa-cube"></i></span>
<input type="text" class="form-control" name="item_name" maxlength="200" value="<?= escapeHtml($rules['item_name']) ?>" required>

View File

@@ -27,7 +27,7 @@ ob_start();
<label class="form-label">Category <strong class="text-danger">*</strong></label>
<div class="input-group">
<span class="input-group-text"><i class="fas fa-fw fa-list"></i></span>
<select class="form-select select2" name="bulk_category_id">
<select class="form-select select2" name="bulk_category_id" required>
<?= categoryOptionsHtml('Income') ?>
</select>
<?= categoryAddButtonHtml('Income') ?>

View File

@@ -91,7 +91,7 @@ if ($form_vendor_id && !isset($form_vendors[$form_vendor_id]) && $form_value('ve
<?= taxOptionsHtml($form_taxes, $form_tax_id) ?>
</select>
</div>
<small class="text-secondary">Taxed, its lines take the client's own rate when it has one</small>
<div class="form-text">Taxed, its lines take the client's own rate when it has one</div>
</div>
<!-- What it sells for, what it costs us -->

View File

@@ -27,7 +27,7 @@ ob_start();
<label class="form-label">Next run date <strong class="text-danger">*</strong></label>
<div class="input-group">
<span class="input-group-text"><i class="fas fa-fw fa-calendar-day"></i></span>
<input class="form-control" type="date" name="next_run_date" min="<?= date("Y-m-d"); ?>" max="2999-12-31">
<input class="form-control" type="date" name="next_run_date" min="<?= date("Y-m-d"); ?>" max="2999-12-31" required>
</div>
</div>

View File

@@ -30,7 +30,7 @@ ob_start();
<input type="hidden" name="csrf_token" value="<?= $_SESSION['csrf_token'] ?>">
<input type="hidden" name="software_id" value="<?= $software_id ?>">
<div class="modal-body">
<label class="form-label">Keys</label>
<label class="form-label">Keys <strong class="text-danger">*</strong></label>
<textarea class="form-control font-monospace" name="keys" rows="8" placeholder="One key per line" required autofocus></textarea>
<div class="form-text">Paste straight from the vendor's portal or the order email - one per line. Keys it already has are skipped.</div>
</div>

View File

@@ -83,7 +83,7 @@ ob_start();
<label class="form-label">Reason for merge <strong class="text-danger">*</strong></label>
<div class="input-group">
<span class="input-group-text"><i class="fas fa-fw fa-sticky-note"></i></span>
<input type="text" class="form-control" name="merge_comment" placeholder="Comments">
<input type="text" class="form-control" name="merge_comment" placeholder="Noted on each ticket" required>
</div>
</div>

View File

@@ -129,7 +129,7 @@ ob_start();
<label class="form-label">Quote date <strong class="text-danger">*</strong></label>
<div class="input-group">
<span class="input-group-text"><i class="fas fa-fw fa-calendar"></i></span>
<input type="date" class="form-control" name="date" max="2999-12-31" value="<?= date("Y-m-d") ?>">
<input type="date" class="form-control" name="date" max="2999-12-31" value="<?= date("Y-m-d") ?>" required>
</div>
</div>
</div>

View File

@@ -61,7 +61,7 @@ ob_start();
<input class="btn-check" id="ticket_reply_type_opt1" type="radio" name="ticket_reply_type" value="Public" <?php if ($ticket_reply_type == 'Public') { echo "checked"; } ?>>
<label class="btn btn-outline-secondary" for="ticket_reply_type_opt1"><i class="fas fa-fw fa-eye me-1"></i>Public</label>
</div>
<small class="text-body-secondary">Public replies show in the client portal. Saving here never sends an email.</small>
<div class="form-text">Public replies show in the client portal. Saving here never sends an email.</div>
</div>
<?php if ($emailed_to !== '') { ?>

View File

@@ -40,7 +40,7 @@ ob_start();
<?php } ?>
</select>
</div>
<small class="text-body-secondary">The response and resolution deadlines are worked out again from when the ticket was opened.</small>
<div class="form-text">The response and resolution deadlines are worked out again from when the ticket was opened.</div>
</div>
</div>

View File

@@ -527,7 +527,11 @@ if (isset($_POST['bulk_transfer_client_asset'])) {
enforceUserPermission('module_support', 2);
$new_client_id = intval($_POST['bulk_client_id']);
$new_client_id = intval($_POST['bulk_client_id'] ?? 0);
if (!$new_client_id || !getFieldById('clients', $new_client_id, 'client_name')) {
flashAlert('Pick the client to move them to.', 'error');
redirect();
}
enforceClientAccess($new_client_id);

View File

@@ -27,7 +27,7 @@ if (isset($_POST['add_credit'])) {
logAudit("Credit", "Create", "$session_name added " . billingMoney($amount, $session_company_currency) . "", $client_id, $credit_id);
flashAlert(billingMoney($amount, $session_company_currency) . " Credit Added");
flashAlert("Credit of <strong>" . billingMoney($amount, $session_company_currency) . "</strong> added");
redirect();